MIME-Version: 1.0
In-Reply-To: <CAEoWx2=SLga-xH09Cq_PAvsHhQHrBK+V0vF821JKgzS=Bm0haA@mail.gmail.com>
References: <CAEoWx2=SLga-xH09Cq_PAvsHhQHrBK+V0vF821JKgzS=Bm0haA@mail.gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Mon, 12 Jan 2026 07:40:00 -0700
Message-ID: <CAKFQuwZXt2dAuHFs6MtRCzfMP6YZFzssuzdW2woJBVmco=CDdQ@mail.gmail.com>
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
To: Chao Li <li.evan.chao@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000905507064831d931"
Archived-At: <https://www.postgresql.org/message-id/CAKFQuwZXt2dAuHFs6MtRCzfMP6YZFzssuzdW2woJBVmco%3DCDdQ%40mail.gmail.com>
Precedence: bulk

--000000000000905507064831d931
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Monday, January 12, 2026, Chao Li <li.evan.chao@gmail.com> wrote:

>
> For now, I=E2=80=99ve limited the change to REPLICA IDENTITY to see wheth=
er there
> are objections to this approach. If there are none, I plan to extend the
> same warning behavior to the other sub-commands listed above. After that,
> users can reasonably assume that an ALTER TABLE partitioned_table
> ... action will recurse to child partitions unless a warning explicitly
> tells them otherwise.
>

It should be a notice, not a warning.

How about indicating how many partitions were affected in the notice and
allowing the absence of such a notice to be the indicator that cascading
did not happen?

David J.

--000000000000905507064831d931
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Monday, January 12, 2026, Chao Li &lt;<a href=3D"mailto:li.evan.chao@gma=
il.com">li.evan.chao@gmail.com</a>&gt; wrote:<br><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex"><div dir=3D"ltr"><div dir=3D"auto" style=3D"line-break:after-white-spa=
ce"><div><br></div><div>For now, I=E2=80=99ve limited the change to=C2=A0RE=
PLICA IDENTITY=C2=A0to see whether there are objections to this approach. I=
f there are none, I plan to extend the same warning behavior to the other s=
ub-commands listed above. After that, users can reasonably assume that an=
=C2=A0ALTER TABLE partitioned_table ...=C2=A0action will recurse to child p=
artitions=C2=A0unless=C2=A0a warning explicitly tells them otherwise.</div>=
</div></div></blockquote><div><br></div><div>It should be a notice, not a w=
arning.</div><div><br></div><div>How about indicating how many partitions w=
ere affected in the notice and allowing the absence of such a notice to be =
the indicator that cascading did not happen?</div><div><br></div><div>David=
 J.</div><div><br></div>

--000000000000905507064831d931--