Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t5bEj-007BuC-Dc for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Oct 2024 01:41:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t5bEf-00BQRP-Qr for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Oct 2024 01:41:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t5bEf-00BQRH-Gr for pgsql-hackers@lists.postgresql.org; Tue, 29 Oct 2024 01:41:29 +0000 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1t5bEd-003MSf-2R for pgsql-hackers@postgresql.org; Tue, 29 Oct 2024 01:41:28 +0000 Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5eb9ee4f14cso2115223eaf.1 for ; Mon, 28 Oct 2024 18:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730166086; x=1730770886; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Zw4we4IfwfWBTQAxMs7TP4dViy1ZkTBtRvXJpEdLkxU=; b=ApLeYr8CkAbi86puEzxUmGKx0Lx0uteHuNdp43Vb7461tWfePXHuHmWkk283FLuHR8 fXlWL0mhdQFMv0MZuEFCTA1DoNE3duC6947AZToXOjbPP3P3mNzylxza9ciYSlUeYpf8 hxKvfcvBts+3wZt5rmxXqXNVsCGs79VsY+QZSz9W4+QXC6gWPLsoODPYYIN2mTK1v6i9 3FZDyGTn7LMW34PUn1SXL2BDNtFCaTeapBkq+/6VUVDvy6xHCu1iyAuNz1AnVlpCDYQm 53IOmiz22j0aVsYTqt9cEkRm1SjlRNiOx7sJ9F8pTl4/YIPB/w3f270h4H7IyOuWhkg4 rCHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730166086; x=1730770886; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zw4we4IfwfWBTQAxMs7TP4dViy1ZkTBtRvXJpEdLkxU=; b=ojdqdg3sUx3iZi0s3Zf4DEEu2nhQyXG/Pa0aGR1kCgsDU1J7SHJLh3VwCX98j2wT3l TXMSr8ivgl7eNrpCPCibxOZRoWffnZOwK06uNr+ckZxO2Qyzhakf4qT7aeq1ONc+o3i0 /JHMTB3tJs26kQiIVvJ17OWVPnbKHecEPvGnJ4Fg2PU31ISX0Z1vMX1jRvcFY/e7H3Gg NkWBeSni5BxIK2kmfNyXa7L/y1E/3nO6id7ctKUiAYu+Efvszb1HMMhUvh21h7o3NvXT gNuMk52Ou00Ep6Xda/OV3meFQ/2pf9EAl1VBolVHOfr9LpaW/BBRfR7dOzomAFl2lqhc 1GvA== X-Forwarded-Encrypted: i=1; AJvYcCXsIdIZwJckDMppfX8YCatqPW9SOIFNLEj/C7BCrffpfzQhtZXW8gvqhJ8/MtQuDTNhXJBHD12z4p7i055x@postgresql.org X-Gm-Message-State: AOJu0YxYjm0eLOM1zK7Yii0NKDQ2BdPzOA4X9stUxWz1UOT3HWCTABqp XNdrMbN5lAnpsERiwA67mAlKPWDTpXcymJJIq9p5ZcuJrqCHR9JHWxOywErh+7A+9SuXC4S2I7N iTZlojESWsKGgeCdsqSLHwG92zw6imXLB X-Google-Smtp-Source: AGHT+IHosQppQBNow78rmNZXdbR3x9RNRocUstdpPp/5EKpY3DftzDGpA15PTe8GaK8pvIior1YZNIX5wkntU4dlieU= X-Received: by 2002:a05:6870:b6a9:b0:27b:4f51:d73a with SMTP id 586e51a60fabf-29051bfbe07mr9088537fac.21.1730166085949; Mon, 28 Oct 2024 18:41:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "David G. Johnston" Date: Mon, 28 Oct 2024 18:40:50 -0700 Message-ID: Subject: Re: EXPLAIN IndexOnlyScan shows disabled when enable_indexonlyscan=on To: David Rowley Cc: Melanie Plageman , Pg Hackers , Robert Haas Content-Type: multipart/alternative; boundary="000000000000f4a1bd062593aee1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000f4a1bd062593aee1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 28, 2024 at 3:54=E2=80=AFPM David Rowley = wrote: > > I've attached that in patch form. > > - Enables or disables the query planner's use of index-scan plan - types. The default is on. + Enables or disables the query planner's use of index-scan and + index-only-scan plan types. The default is on. + Also see . I think the original wording "index-scan plan types" is what is confusing me. The plural types is turning index-scan plan into a category of plans rather than the single plan type "index scan". Your proposed wording actually (accidentally?) fixes this because now the plural types actually refers to two individual plan nodes, "index scan" and "index-only scan". The hyphenation still reads a bit odd but ok. I am ok with this revision (and the patch as a whole) I suppose but I still feel like something is missing here. Though probably that something would fit better in an overview page rather than trying to get the settings to explain all this to the reader. David J. --000000000000f4a1bd062593aee1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Oct 28, 2024 at 3:54=E2=80=AFPM David Rowley <<= a href=3D"mailto:dgrowleyml@gmail.com">dgrowleyml@gmail.com> wrote:<= /span>

I've attached that in patch form.


=C2=A0- =C2=A0 =C2=A0 =C2=A0 =C2=A0Enables or disables the query planner= 's use of index-scan plan
- =C2=A0 =C2=A0 =C2=A0 =C2=A0types. The = default is <literal>on</literal>.
+ =C2=A0 =C2=A0 =C2=A0 =C2= =A0Enables or disables the query planner's use of index-scan and
+ = =C2=A0 =C2=A0 =C2=A0 =C2=A0index-only-scan plan types.=C2=A0 The default is= <literal>on</literal>.
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0Also se= e <xref linkend=3D"guc-enable-indexonlyscan"/>.

I think the or= iginal wording "index-scan plan types" is what is confusing me.= =C2=A0 The plural types is turning index-scan plan into a category of plans= rather than the single plan type "index scan".

Your proposed wording actually (accidentally?) fixes this because now= the plural types actually refers to two individual plan nodes, "index= scan" and "index-only scan".

The hyphenation still reads a bit odd but ok.

I am ok with this revision (and the patch as a whole) I suppose but = I still feel like something is missing here.=C2=A0 Though probably that som= ething would fit better in an overview page rather than trying to get the s= ettings to explain all this to the reader.

David J.
=C2=A0

--000000000000f4a1bd062593aee1--