Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vAoGp-006Ccw-Ft for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Oct 2025 11:41:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1vAoGn-00H1W7-N0 for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Oct 2025 11:41:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vAoGn-00H1Vy-DW for pgsql-hackers@lists.postgresql.org; Mon, 20 Oct 2025 11:41:44 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vAoGk-003Djr-1L for pgsql-hackers@lists.postgresql.org; Mon, 20 Oct 2025 11:41:44 +0000 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-441ebf53e0bso1090999b6e.2 for ; Mon, 20 Oct 2025 04:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760960500; x=1761565300; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yeai6OxMrXD8ehGBGxmqoFbspLsx5ix1dlUV8S26scg=; b=kwRIH3Awimi5/9vjECT2kzWZlhWzRFADT3sLNQK3bhz5KFXPAVLWUJB3BCb8u02h6g XzMwgGMrkT6BigcQz9WJHCvDEeSsrQv92QFT8sEL5b7mt9lMkfL9v6NuVmOPlAdt7va9 Vnyu0RyOKotm/c4uDE2Q/13jmuZ+Uj4ptW0pDr1NGepczvcyc4G1+Iwy5JB6W+lr3PFt vsF259EumrJquVmoV07ylVMXuUfGT0JuDYLy2Fm+eYSiARgUBp9TZ96ODcaTl9gGllxb gwHMrE/CL9ejjeEIv6o/tHc+zFnslQfZWTouyIEo9NuInYuN+kFRPZPyMZ0tC/JVpRDQ /qhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760960500; x=1761565300; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yeai6OxMrXD8ehGBGxmqoFbspLsx5ix1dlUV8S26scg=; b=wcgv7HL5xHsJjcENv7DRKXVu0kLLFhrVklO7kSmVQV06SJz747cRm/YaOcTikqQnkU h7OnmzfVRVtt7AYYYTKW5RK9nNfb4JfXpVVH4CQ9tTSLsZEuwGDQJHriMSgLCVSDPWy3 RlOWTnxRVsAqxbkOG60AfcvrGYSCXzjOub8adXxUsS+ADcCjBIFdgptk7KolvTuj4rWG 5ydjxJfk+T32T4GKQhFG2D0Ah5mkz46dhGgt0Gwr3OPN3w6Pf9aO9W0VPBJL2THc9okL DiTXdc2zhHR12Panj5FTrYibojuwZMbLdNcSRLWnnKRXWO/NKOWvoQkwK5bIAeh/UN5a Mn1A== X-Forwarded-Encrypted: i=1; AJvYcCXWf7Vag7u4LS0cd065pum9in7VePv2oYcmMZUSln1N0vtE0eFz+HNbg4xsJjnE/C/g6T6LlHS5TdYkfGlI@lists.postgresql.org X-Gm-Message-State: AOJu0YzSaRxvPT4ONwBIOShuuQJ/ZVrHirkhtPpiNldeUm46mE8BNa1M zKvSHhJDT/9pMcIXLRa+17yuwSh2kooBVKjPpC/LeDY+C7b61KlDwjzspLtiCswV4blNM60gseb mJjr3oGP5NM24cweC2XzWKD839nafXbQ= X-Gm-Gg: ASbGncv9FiswXHEh2whXl/YksVC8ScsQhct4MpT5x21t7MaHKmx2RnRfydIE58zjtki Si2sLE7mHBRYDoAbdl9PgB4KDU8a/HVQfZv2tgSBZ1NK8NuVJWCyZLH1fjlsKeaKjEe+u60OgnX 7D1CxX4WO/PY+9FVYBc+CDDXk/Si1xzWa4J9KrAYMdKXW3NaiMbqeILq8fw1EA1jUUUqg3cDYjx cH6ZGSftnXAIcrkVhcdQHDzGLQ1K8+F9my7ydBbdg/Pi7u6/MIcYg+zvEfkvA== X-Google-Smtp-Source: AGHT+IEa2s+zE/tzDZ5twbFps80dvwe5Mq3WsEMiNEW5CJVlmls5uT7MukQQrMC2A9qdAHEQf0vMFAaTCLzD39nynNE= X-Received: by 2002:a05:6808:3508:b0:441:ebf5:60df with SMTP id 5614622812f47-443a310f4e6mr4725949b6e.51.1760960499970; Mon, 20 Oct 2025 04:41:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:7444:0:b0:5f3:5bf6:6b0b with HTTP; Mon, 20 Oct 2025 04:41:39 -0700 (PDT) In-Reply-To: <3c9aabf667db65e757dddbdad1a13d623170e970.camel@cybertec.at> References: <3c9aabf667db65e757dddbdad1a13d623170e970.camel@cybertec.at> From: "David G. Johnston" Date: Mon, 20 Oct 2025 07:41:39 -0400 X-Gm-Features: AS18NWBcZugMuW6aj9ZcmlaEiQ1JM-y_jwFHAdRdAPrabhV4sbf-ovCL9cbQO2Y Message-ID: Subject: Re: doc: create table improvements To: Laurenz Albe Cc: Peter Eisentraut , PostgreSQL Hackers , jian he Content-Type: multipart/alternative; boundary="0000000000001077fa06419591b8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000001077fa06419591b8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Monday, October 20, 2025, Laurenz Albe wrote: > On Thu, 2025-10-16 at 15:19 +0200, Laurenz Albe wrote: > > Attached is version 3. > > David, do you as the original patch author want to comment? > The patch is "waiting for author". > Thanks, I question whether =E2=80=9Cparameter=E2=80=9D is even the correct class to= assign here and so would rather avoid the issue by not assigning a class. =E2=80=9CIf none is specified, the data will be persistent=E2=80=9D would b= e better written =E2=80=9CIf unspecified the data will be persistent=E2=80=9D (or, =E2=80=9C= if not specified=E2=80=A6=E2=80=9D) Everything else looks good. David J. --0000000000001077fa06419591b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Monday, October 20, 2025, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
On Thu, 2025-10-16 at 15:19 +0200, Laurenz Albe wrote:
> Attached is version 3.

David, do you as the original patch author want to comment?
The patch is "waiting for author".

Thanks,

I questio= n whether =E2=80=9Cparameter=E2=80=9D is even the correct class to assign h= ere and so would rather avoid the issue by not assigning a class.

=E2=80=9CIf none is specified, the data will be persistent= =E2=80=9D would be better written =E2=80=9CIf unspecified the data will be = persistent=E2=80=9D (or, =E2=80=9Cif not specified=E2=80=A6=E2=80=9D)

Everything else looks good.

David J.

--0000000000001077fa06419591b8--