MIME-Version: 1.0
In-Reply-To: 
 <CABV9wwP-A7XhKfJTJ=ryMV2mfQtzDRsQW73K6+ZvFP56s31j3A@mail.gmail.com>
References: 
 <CAKFQuwYe1vf7k+gx_f5ny1mpz_CrhMhaa_NgVb-87_=DHj3JEw@mail.gmail.com>
 <e7286453-7d8c-460d-b6fa-95df54c3ca13@proxel.se>
 <f828ab0a-0231-4673-a407-e550cdc549bd@proxel.se>
 <CABV9wwP-A7XhKfJTJ=ryMV2mfQtzDRsQW73K6+ZvFP56s31j3A@mail.gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Fri, 3 Apr 2026 20:03:35 -0700
Message-ID: 
 <CAKFQuwaK50p9TbNp2=AvwstzhvjXS+9kvq96v-A5OviUZCLRqw@mail.gmail.com>
Subject: Re: Docs: Distinguish table and index storage parameters in CREATE
 TABLE
To: Robert Treat <rob@xzilla.net>
Cc: Andreas Karlsson <andreas@proxel.se>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000ff5881064e99ad13"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKFQuwaK50p9TbNp2%3DAvwstzhvjXS%2B9kvq96v-A5OviUZCLRqw%40mail.gmail.com>
Precedence: bulk

--000000000000ff5881064e99ad13
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Friday, April 3, 2026, Robert Treat <rob@xzilla.net> wrote:

> On Fri, Apr 3, 2026 at 3:35=E2=80=AFPM Andreas Karlsson <andreas@proxel.s=
e> wrote:
> > On 4/3/26 9:27 PM, Andreas Karlsson wrote:
> > > On 4/3/26 8:18 PM, David G. Johnston wrote:
> > >> Per the discussion on -general [1] I propose that we stop using the
> > >> generic label storage_parameter on the create table reference page a=
nd
> > >> instead set up proper labels for table and index variants.
> > >
>
> It's sort of interesting that no one in the above discussion gave an
> example like:
> create table t (c int, constraint pk primary key (c) with (fillfactor
> =3D 90)) with (fillfactor =3D 100);
> and pointing out that where you put the parameter changes what it
> effects, so I'm a little skeptical that this patch would help the
> original discussion, but it certainly wouldn't hurt, so +1 from me.
>

Stretches my skills a bit but if the error message had been: (unrecognized
index storage parameter =E2=80=9Cautovacuum_enabled=E2=80=9D) the syntax pl=
acement issue
may have been recognized working under the assumption the author knows
their intent is to modify the table (and vice-versa).

As a quick footgun prevention attempt (not a huge fan though):

Note, specifying a primary key or unique constraint as the final component
of create table makes assigning storage parameters to the wrong object more
likely.
(Added to the with clause section)

David J.

--000000000000ff5881064e99ad13
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Friday, April 3, 2026, Robert Treat &lt;<a href=3D"mailto:rob@xzilla.net=
">rob@xzilla.net</a>&gt; wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, =
Apr 3, 2026 at 3:35=E2=80=AFPM Andreas Karlsson &lt;<a href=3D"mailto:andre=
as@proxel.se">andreas@proxel.se</a>&gt; wrote:<br>
&gt; On 4/3/26 9:27 PM, Andreas Karlsson wrote:<br>
&gt; &gt; On 4/3/26 8:18 PM, David G. Johnston wrote:<br>
&gt; &gt;&gt; Per the discussion on -general [1] I propose that we stop usi=
ng the<br>
&gt; &gt;&gt; generic label storage_parameter on the create table reference=
 page and<br>
&gt; &gt;&gt; instead set up proper labels for table and index variants.<br=
>
&gt; &gt;<br>
<br>
It&#39;s sort of interesting that no one in the above discussion gave an<br=
>
example like:<br>
create table t (c int, constraint pk primary key (c) with (fillfactor<br>
=3D 90)) with (fillfactor =3D 100);<br>
and pointing out that where you put the parameter changes what it<br>
effects, so I&#39;m a little skeptical that this patch would help the<br>
original discussion, but it certainly wouldn&#39;t hurt, so +1 from me.<br>
</blockquote><div><br></div><div>Stretches my skills a bit but if the error=
 message had been: (unrecognized index storage parameter =E2=80=9Cautovacuu=
m_enabled=E2=80=9D) the syntax placement issue may have been recognized wor=
king under the assumption the author knows their intent is to modify the ta=
ble (and vice-versa).</div><div><br></div><div>As a quick footgun preventio=
n attempt (not a huge fan though):</div><div><br></div><div>Note, specifyin=
g a primary key or unique constraint as the final component of create table=
 makes assigning storage parameters to the wrong object more likely.</div><=
div>(Added to the with clause section)</div><div><br></div><div>David J.</d=
iv><div><br></div>

--000000000000ff5881064e99ad13--