MIME-Version: 1.0
In-Reply-To: 
 <CA+3i_M8Rj0yEA5rRbWjobNbcZsB0MExfZbKV-mkWwFeyRvanCw@mail.gmail.com>
References: 
 <CA+3i_M8Rj0yEA5rRbWjobNbcZsB0MExfZbKV-mkWwFeyRvanCw@mail.gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Mon, 13 Apr 2026 05:27:06 -0700
Message-ID: 
 <CAKFQuwan3J1WdqtiXr4u9Lmj+5Z7r+hYOKfy_A1g23_8f90LWw@mail.gmail.com>
Subject: Re: Show VIRTUAL keyword for virtual generated columns in pg_dump and
 psql
To: Lakshmi N <lakshmin.jhs@gmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	"dean.a.rasheed@gmail.com" <dean.a.rasheed@gmail.com>,
 "peter@eisentraut.org" <peter@eisentraut.org>
Content-Type: multipart/alternative; boundary="000000000000d8e083064f56994b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKFQuwan3J1WdqtiXr4u9Lmj%2B5Z7r%2BhYOKfy_A1g23_8f90LWw%40mail.gmail.com>
Precedence: bulk

--000000000000d8e083064f56994b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Monday, April 13, 2026, Lakshmi N <lakshmin.jhs@gmail.com> wrote:
>
> pg_dump and psql's \d currently display stored and virtual generated
> columns asymmetrically:
>

>
>     s_total integer GENERATED ALWAYS AS ((a + b)) STORED
>     v_total integer GENERATED ALWAYS AS ((a + b))
>
> Since VIRTUAL is default most likely this was omitted but with this
>
puts the burden on the reader to identify whether it is STORED or
> VIRTUAL since both kinds coexist in v19.
>

The output follows existing conventions of not printing extraneous text.
Additionally, storage itself is non-standard so the absence of a modifier
is producing standard-compliant output.  I would -1 changing pg_dump on
this basis.  I=E2=80=99d be inclined to go with the symmetry/readability ar=
gument
for psql \d though.

David J.

--000000000000d8e083064f56994b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Monday, April 13, 2026, Lakshmi N &lt;<a href=3D"mailto:lakshmin.jhs@gma=
il.com">lakshmin.jhs@gmail.com</a>&gt; wrote:<blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
><div dir=3D"ltr"><div><div><div>pg_dump and psql&#39;s \d currently displa=
y stored and virtual generated<br>columns asymmetrically:</div></div></div>=
</div></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><di=
v><div><br><br>=C2=A0 =C2=A0 s_total integer GENERATED ALWAYS AS ((a + b)) =
STORED<br>=C2=A0 =C2=A0 v_total integer GENERATED ALWAYS AS ((a + b))<br><b=
r>Since VIRTUAL is default most likely this was omitted but with this</div>=
</div></div></div></blockquote><blockquote class=3D"gmail_quote" style=3D"m=
argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"l=
tr"><div><div><div>puts the burden on the reader to identify whether it is =
STORED or=C2=A0</div><div>VIRTUAL since both kinds coexist in v19.</div></d=
iv></div></div></blockquote><div><br></div><div>The output follows existing=
 conventions of not printing extraneous text.=C2=A0 Additionally, storage i=
tself is non-standard so the absence of a modifier is producing standard-co=
mpliant output.=C2=A0 I would -1 changing pg_dump on this basis.=C2=A0 I=E2=
=80=99d be inclined to go with the symmetry/readability argument for psql \=
d though.</div><div><br></div><div>David J.</div><div><br></div>

--000000000000d8e083064f56994b--