public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G. Johnston <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Subject: Re: Unable parse a comment in gram.y
Date: Sat, 22 Jun 2024 21:13:37 -0700
Message-ID: <CAKFQuwb45GhK16nfkWAb2o_6NsJ6LE9OCRG67aAemNsCZTqQbQ@mail.gmail.com> (raw)
In-Reply-To: <20240623.130154.1867056921698616251.t-ishii@sranhm.sra.co.jp.sranhm>
References: <20240623.130154.1867056921698616251.t-ishii@sranhm.sra.co.jp.sranhm>

On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <[email protected]> wrote:

> I was unable to parse a comment in src/backend/parser/gram.y around line
> 11364:
>
> /*
>  * As func_expr but does not accept WINDOW functions directly (they
>  * can still be contained in arguments for functions etc.)
>  * Use this when window expressions are not allowed, so to disambiguate
>  * the grammar. (e.g. in CREATE INDEX)
>  */
>
> Maybe "but" is unnecessary in the first sentence in the comment?
>
>
The "but" is required, add a comma before it.  It could also be written a
bit more verbosely:

func_expr_windowless is the same as func_expr aside from not accepting
window functions directly ...

David J.

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Unable parse a comment in gram.y
  In-Reply-To: <CAKFQuwb45GhK16nfkWAb2o_6NsJ6LE9OCRG67aAemNsCZTqQbQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox