MIME-Version: 1.0
In-Reply-To: <CACJufxHU9ZdA=-Q+fg_+v+6OJ-L05rez8_mNZBrKghYD_g04XA@mail.gmail.com>
References: <CACJufxHU9ZdA=-Q+fg_+v+6OJ-L05rez8_mNZBrKghYD_g04XA@mail.gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Sun, 7 Jan 2024 23:17:38 -0700
Message-ID: <CAKFQuwbs_1ask7XCFFzBu_bKodU=rRy9v5Nn_NBH73zcRNBFcQ@mail.gmail.com>
Subject: Re: alter table add x wrong error position
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000960353060e69276a"
Archived-At: <https://www.postgresql.org/message-id/CAKFQuwbs_1ask7XCFFzBu_bKodU%3DrRy9v5Nn_NBH73zcRNBFcQ%40mail.gmail.com>
Precedence: bulk

--000000000000960353060e69276a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sunday, January 7, 2024, jian he <jian.universality@gmail.com> wrote:

> hi.
> Maybe this is a small printout err_position bug.
>
> create table atacc2 ( test int, a int, b int) ;
> success tests:
> alter table atacc2 add CONSTRAINT x PRIMARY KEY (id, b );
> alter table atacc2 add CONSTRAINT x PRIMARY KEY (id, b a);
> alter table atacc2 add CONSTRAINT x PRIMARY KEYa (id, b);
>
> tests have problem:
> alter table atacc2 add constraints x unique (test, a, b);
> ERROR:  syntax error at or near "("
> LINE 1: alter table atacc2 add constraints x unique (test, a, b);
>
>           ^
> ADD either following with the optional keyword "COLUMN" or
> "CONSTRAINT"  as the doc.
> so I should expect the '^' point at "constraints"?
>

It=E2=80=99s finding =E2=80=9C=E2=80=A6 add column_name data_type column_co=
nstraint=E2=80=9D then dies at
the parenthesis.  So indeed the care t should be pointing where it probably
is, at the parenthesis that the error is referring to.

David J.

--000000000000960353060e69276a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sunday, January 7, 2024, jian he &lt;<a href=3D"mailto:jian.universality=
@gmail.com">jian.universality@gmail.com</a>&gt; wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">hi.<br>
Maybe this is a small printout err_position bug.<br>
<br>
create table atacc2 ( test int, a int, b int) ;<br>
success tests:<br>
alter table atacc2 add CONSTRAINT x PRIMARY KEY (id, b );<br>
alter table atacc2 add CONSTRAINT x PRIMARY KEY (id, b a);<br>
alter table atacc2 add CONSTRAINT x PRIMARY KEYa (id, b);<br>
<br>
tests have problem:<br>
alter table atacc2 add constraints x unique (test, a, b);<br>
ERROR:=C2=A0 syntax error at or near &quot;(&quot;<br>
LINE 1: alter table atacc2 add constraints x unique (test, a, b);<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br>
ADD either following with the optional keyword &quot;COLUMN&quot; or<br>
&quot;CONSTRAINT&quot;=C2=A0 as the doc.<br>
so I should expect the &#39;^&#39; point at &quot;constraints&quot;?<br>
</blockquote><div><br></div><div>It=E2=80=99s finding =E2=80=9C=E2=80=A6 ad=
d column_name data_type column_constraint=E2=80=9D then dies at the parenth=
esis.=C2=A0 So indeed the care t should be pointing where it probably is, a=
t the parenthesis that the error is referring to.</div><div><br></div><div>=
David J.</div><div><br></div>

--000000000000960353060e69276a--