MIME-Version: 1.0
References: 
 <CAKK5BkFOFGfKJNbTuYBvE0PfpHmW8iZEmdNogaCYqjAOhtNgDg@mail.gmail.com>
 <9FF1E1E8-D9EE-43C5-ADFA-7AE94BA57159@yandex-team.ru>
 <CAKK5BkFxWnddC2=mbHpojWnOLe=x3vLftaMUkO3ocJwqZN7Tug@mail.gmail.com>
In-Reply-To: 
 <CAKK5BkFxWnddC2=mbHpojWnOLe=x3vLftaMUkO3ocJwqZN7Tug@mail.gmail.com>
From: Andrew Jackson <andrewjackson947@gmail.com>
Date: Sun, 22 Mar 2026 18:38:41 -0500
Message-ID: 
 <CAKK5BkE_+rCKgZz7+VNNfH_Jm1H6=RcHxg8mmojyR8pu-LOh5w@mail.gmail.com>
Subject: Re: Add ldapservice connection parameter
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Roman Khapov <rkhapov@yandex-team.ru>, niushiji@gmail.com
Content-Type: multipart/mixed; boundary="0000000000003c8b55064da56dab"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKK5BkE_%2BrCKgZz7%2BVNNfH_Jm1H6%3DRcHxg8mmojyR8pu-LOh5w%40mail.gmail.com>
Precedence: bulk

--0000000000003c8b55064da56dab
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Noticed 1 variable that was unused during non-LDAP builds. Tested
locally and did not see the error/warning. Also some minor cleanup
(comments, definition placement, etc).

Thanks,
Andrew Jackson

On Mon, Jan 12, 2026 at 5:53=E2=80=AFPM Andrew Jackson
<andrewjackson947@gmail.com> wrote:
>
> Steven and Roman, Thank you for the review.
>
> Here is an updated patch that addresses both of these issues.
>
> On Mon, Jan 12, 2026 at 4:06=E2=80=AFAM Roman Khapov <rkhapov@yandex-team=
.ru> wrote:
> >
> > Hi!
> >
> > Thanks for your patch!
> >
> > Adding to the one Steven wrote, I noticed one typo in the patch:
> >
> > @@ -2337,7 +2337,7 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
> >        <term><literal>ldapservice</literal></term>
> >        <listitem>
> >         <para>
> > -        This option specifies an LDAP query that can be used to refere=
nce connection paremeters
> > +        This option specifies an LDAP query that can be used to refere=
nce connection parameters
> >          stored in an LDAP server. This functionality is described in m=
ore detail in <xref linkend=3D"libpq-ldap"/>.
> >          </para>
> >
> > paremeters -> parameters
> >
> > --
> > Best regards,
> > Roman Khapov

--0000000000003c8b55064da56dab
Content-Type: text/x-patch; charset="US-ASCII";
	name="0003-Add-ldapservice-connection-parameter.patch"
Content-Disposition: attachment;
	filename="0003-Add-ldapservice-connection-parameter.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn2ebjhd0>
X-Attachment-Id: f_mn2ebjhd0

RnJvbSBlNDI5YzdmNTM4NzQ2NmZkZGNkNzY1ZWI2NWYyM2RiMjFmMTllNzY5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDb21tYW5kZXJLZXluZXMgPGFuZHJld2phY2tzb245NDdAZ21h
aWwuY29tYT4KRGF0ZTogU3VuLCAyMyBNYXIgMjAyNSAxNzoyNzozMiAtMDUwMApTdWJqZWN0OiBb
UEFUQ0hdIEFkZCBsZGFwc2VydmljZSBjb25uZWN0aW9uIHBhcmFtZXRlcgoKQ3VycmVudGx5IHRo
ZXJlIGV4aXN0cywgb25seSBpbiBwZ19zZXJ2aWNlLmNvbmYsIHRoZSBhYmlsaXR5IHRvIGxvb2sK
dXAgY29ubmVjdGlvbiBwYXJhbWV0ZXJzIGZyb20gYSBjZW50cmFsaXplZCBMREFQIHNlcnZlci4g
VGhpcyBwYXRjaApleHBhbmRzIHRoZSB1c2FiaWxpdHkgb2YgdGhpcyBiZSBhbGxvd2luZyBpdCB0
byBiZSBzcGVjaWZpZWQgZGlyZWN0bHkgaW4KYSBjb25uZWN0aW9uIHN0cmluZyBpbnN0ZWFkIG9m
IG9ubHkgaW4gYSBwZ19zZXJ2aWNlLmNvbmYgZmlsZS4KLS0tCiBkb2Mvc3JjL3NnbWwvbGlicHEu
c2dtbCAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysKIHNyYy9pbnRl
cmZhY2VzL2xpYnBxL2ZlLWNvbm5lY3QuYyAgICAgICAgICAgICAgICAgIHwgMTQgKysrKysrKysr
KysrKysKIHNyYy9pbnRlcmZhY2VzL2xpYnBxL2xpYnBxLWludC5oICAgICAgICAgICAgICAgICAg
IHwgIDEgKwogLi4uL2xkYXAvdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFtX2xvb2t1cC5wbCAg
ICAgfCAxMiArKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKQoK
ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9saWJwcS5zZ21sIGIvZG9jL3NyYy9zZ21sL2xpYnBx
LnNnbWwKaW5kZXggN2QwNTkzOGZlZGEuLjIwYTQ4YTIyYzZiIDEwMDY0NAotLS0gYS9kb2Mvc3Jj
L3NnbWwvbGlicHEuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvbGlicHEuc2dtbApAQCAtMjMzMyw2
ICsyMzMzLDE2IEBAIHBvc3RncmVzcWw6Ly8lMkZ2YXIlMkZsaWIlMkZwb3N0Z3Jlc3FsL2RibmFt
ZQogICAgICAgPC9saXN0aXRlbT4KICAgICAgPC92YXJsaXN0ZW50cnk+CiAKKyAgICAgPHZhcmxp
c3RlbnRyeSBpZD0ibGlicHEtY29ubmVjdC1sZGFwc2VydmljZSIgeHJlZmxhYmVsPSJsZGFwc2Vy
dmljZSI+CisgICAgICA8dGVybT48bGl0ZXJhbD5sZGFwc2VydmljZTwvbGl0ZXJhbD48L3Rlcm0+
CisgICAgICA8bGlzdGl0ZW0+CisgICAgICAgPHBhcmE+CisgICAgICAgIFRoaXMgb3B0aW9uIHNw
ZWNpZmllcyBhbiBMREFQIHF1ZXJ5IHRoYXQgY2FuIGJlIHVzZWQgdG8gcmVmZXJlbmNlIGNvbm5l
Y3Rpb24gcGFyYW1ldGVycworICAgICAgICBzdG9yZWQgaW4gYW4gTERBUCBzZXJ2ZXIuIFRoaXMg
ZnVuY3Rpb25hbGl0eSBpcyBkZXNjcmliZWQgaW4gbW9yZSBkZXRhaWwgaW4gPHhyZWYgbGlua2Vu
ZD0ibGlicHEtbGRhcCIvPi4KKyAgICAgICAgPC9wYXJhPgorICAgICAgPC9saXN0aXRlbT4KKyAg
ICAgPC92YXJsaXN0ZW50cnk+CisKICAgICAgPHZhcmxpc3RlbnRyeSBpZD0ibGlicHEtY29ubmVj
dC10YXJnZXQtc2Vzc2lvbi1hdHRycyIgeHJlZmxhYmVsPSJ0YXJnZXRfc2Vzc2lvbl9hdHRycyI+
CiAgICAgICA8dGVybT48bGl0ZXJhbD50YXJnZXRfc2Vzc2lvbl9hdHRyczwvbGl0ZXJhbD48L3Rl
cm0+CiAgICAgICA8bGlzdGl0ZW0+CmRpZmYgLS1naXQgYS9zcmMvaW50ZXJmYWNlcy9saWJwcS9m
ZS1jb25uZWN0LmMgYi9zcmMvaW50ZXJmYWNlcy9saWJwcS9mZS1jb25uZWN0LmMKaW5kZXggYTBk
MmY3NDk4MTEuLjdhNmNhYWViZDg4IDEwMDY0NAotLS0gYS9zcmMvaW50ZXJmYWNlcy9saWJwcS9m
ZS1jb25uZWN0LmMKKysrIGIvc3JjL2ludGVyZmFjZXMvbGlicHEvZmUtY29ubmVjdC5jCkBAIC0y
MDYsNiArMjA2LDEwIEBAIHN0YXRpYyBjb25zdCBpbnRlcm5hbFBRY29ubmluZm9PcHRpb24gUFFj
b25uaW5mb09wdGlvbnNbXSA9IHsKIAkJIkRhdGFiYXNlLVNlcnZpY2UtRmlsZSIsICIiLCA2NCwK
IAlvZmZzZXRvZihzdHJ1Y3QgcGdfY29ubiwgcGdzZXJ2aWNlZmlsZSl9LAogCisJeyJsZGFwc2Vy
dmljZSIsICJQR0xEQVBTRVJWSUNFIiwgTlVMTCwgTlVMTCwKKwkJIkRhdGFiYXNlLUxEQVAtU2Vy
dmljZSIsICIiLCAyMCwKKwlvZmZzZXRvZihzdHJ1Y3QgcGdfY29ubiwgcGdsZGFwc2VydmljZSl9
LAorCiAJeyJ1c2VyIiwgIlBHVVNFUiIsIE5VTEwsIE5VTEwsCiAJCSJEYXRhYmFzZS1Vc2VyIiwg
IiIsIDIwLAogCW9mZnNldG9mKHN0cnVjdCBwZ19jb25uLCBwZ3VzZXIpfSwKQEAgLTU5NTUsMTIg
KzU5NTksMjIgQEAgcGFyc2VTZXJ2aWNlSW5mbyhQUWNvbm5pbmZvT3B0aW9uICpvcHRpb25zLCBQ
UUV4cEJ1ZmZlciBlcnJvck1lc3NhZ2UpCiB7CiAJY29uc3QgY2hhciAqc2VydmljZSA9IGNvbm5p
bmZvX2dldHZhbChvcHRpb25zLCAic2VydmljZSIpOwogCWNvbnN0IGNoYXIgKnNlcnZpY2VfZm5h
bWUgPSBjb25uaW5mb19nZXR2YWwob3B0aW9ucywgInNlcnZpY2VmaWxlIik7CisjaWZkZWYgVVNF
X0xEQVAKKwljb25zdCBjaGFyICpsZGFwc2VydmljZSA9IGNvbm5pbmZvX2dldHZhbChvcHRpb25z
LCAibGRhcHNlcnZpY2UiKTsKKyNlbmRpZgogCWNoYXIJCXNlcnZpY2VGaWxlW01BWFBHUEFUSF07
CiAJY2hhcgkgICAqZW52OwogCWJvb2wJCWdyb3VwX2ZvdW5kID0gZmFsc2U7CiAJaW50CQkJc3Rh
dHVzOwogCXN0cnVjdCBzdGF0IHN0YXRfYnVmOwogCisjaWZkZWYgVVNFX0xEQVAKKwlpZiAobGRh
cHNlcnZpY2UgIT0gTlVMTCkKKwkJaWYgKHN0cm5jbXAobGRhcHNlcnZpY2UsICJsZGFwIiwgNCkg
PT0gMCkKKwkJCWlmICghbGRhcFNlcnZpY2VMb29rdXAobGRhcHNlcnZpY2UsIG9wdGlvbnMsIGVy
cm9yTWVzc2FnZSkpCisJCQkJcmV0dXJuIDA7CisjZW5kaWYKKwogCS8qCiAJICogV2UgaGF2ZSB0
byBzcGVjaWFsLWNhc2UgdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIFBHU0VSVklDRSBoZXJlLCBz
aW5jZQogCSAqIHRoaXMgaXMgYW5kIHNob3VsZCBiZSBjYWxsZWQgYmVmb3JlIGluc2VydGluZyBl
bnZpcm9ubWVudCBkZWZhdWx0cyBmb3IKZGlmZiAtLWdpdCBhL3NyYy9pbnRlcmZhY2VzL2xpYnBx
L2xpYnBxLWludC5oIGIvc3JjL2ludGVyZmFjZXMvbGlicHEvbGlicHEtaW50LmgKaW5kZXggZmI2
YTdjYmYxNWQuLmI1NDBkM2FjMDU0IDEwMDY0NAotLS0gYS9zcmMvaW50ZXJmYWNlcy9saWJwcS9s
aWJwcS1pbnQuaAorKysgYi9zcmMvaW50ZXJmYWNlcy9saWJwcS9saWJwcS1pbnQuaApAQCAtMzky
LDYgKzM5Miw3IEBAIHN0cnVjdCBwZ19jb25uCiAJY2hhcgkgICAqcGdzZXJ2aWNlOwkJLyogUG9z
dGdyZXMgc2VydmljZSwgaWYgYW55ICovCiAJY2hhcgkgICAqcGdzZXJ2aWNlZmlsZTsJLyogcGF0
aCB0byBhIHNlcnZpY2UgZmlsZSBjb250YWluaW5nCiAJCQkJCQkJCSAqIHNlcnZpY2UocykgKi8K
KwljaGFyCSAgICpwZ2xkYXBzZXJ2aWNlOwkvKiBQb3N0Z3JlcyBMREFQIHNlcnZpY2UsIGlmIGFu
eSAqLwogCWNoYXIJICAgKnBndXNlcjsJCQkvKiBQb3N0Z3JlcyB1c2VybmFtZSBhbmQgcGFzc3dv
cmQsIGlmIGFueSAqLwogCWNoYXIJICAgKnBncGFzczsKIAljaGFyCSAgICpwZ3Bhc3NmaWxlOwkJ
LyogcGF0aCB0byBhIGZpbGUgY29udGFpbmluZyBwYXNzd29yZChzKSAqLwpkaWZmIC0tZ2l0IGEv
c3JjL3Rlc3QvbGRhcC90LzAwM19sZGFwX2Nvbm5lY3Rpb25fcGFyYW1fbG9va3VwLnBsIGIvc3Jj
L3Rlc3QvbGRhcC90LzAwM19sZGFwX2Nvbm5lY3Rpb25fcGFyYW1fbG9va3VwLnBsCmluZGV4IDM1
OWZjN2E5OThhLi42OTg1YmU2NTQwOCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbGRhcC90LzAwM19s
ZGFwX2Nvbm5lY3Rpb25fcGFyYW1fbG9va3VwLnBsCisrKyBiL3NyYy90ZXN0L2xkYXAvdC8wMDNf
bGRhcF9jb25uZWN0aW9uX3BhcmFtX2xvb2t1cC5wbApAQCAtMTk2LDYgKzE5NiwxOCBAQCBsb2Nh
bCAkRU5We1BHU0VSVklDRUZJTEV9ID0gIiRzcnZmaWxlX2VtcHR5IjsKIAkJZXhwZWN0ZWRfc3Rk
b3V0ID0+CiAJCSAgcXIvZGVmaW5pdGlvbiBvZiBzZXJ2aWNlICJ1bmRlZmluZWQtc2VydmljZSIg
bm90IGZvdW5kLyk7CiAKKwkkZHVtbXlfbm9kZS0+Y29ubmVjdF9vaygKKwkJImxkYXBzZXJ2aWNl
PWxkYXA6Ly9sb2NhbGhvc3Q6JGxkYXBfcG9ydC9kYz1leGFtcGxlLGRjPW5ldD9kZXNjcmlwdGlv
bj9vbmU/KGNuPW15ZGF0YWJhc2UpIiwKKwkJJ2Nvbm5lY3Rpb24gd2l0aCBjb3JyZWN0ICJsZGFw
c2VydmljZSIgc3RyaW5nJywKKwkJc3FsID0+ICJTRUxFQ1QgJ2Nvbm5lY3QyXzQnIiwKKwkJZXhw
ZWN0ZWRfc3Rkb3V0ID0+IHFyL2Nvbm5lY3QyXzQvKTsKKworCSRkdW1teV9ub2RlLT5jb25uZWN0
X29rKAorCQkicG9zdGdyZXM6Ly8/bGRhcHNlcnZpY2U9bGRhcCUzQSUyRiUyRmxvY2FsaG9zdCUz
QSRsZGFwX3BvcnQlMkZkYyUzRGV4YW1wbGUlMkNkYyUzRG5ldCUzRmRlc2NyaXB0aW9uJTNGb25l
JTNGJTI4Y24lM0RteWRhdGFiYXNlJTI5IiwKKwkJJ2Nvbm5lY3Rpb24gd2l0aCBjb3JyZWN0ICJs
ZGFwc2VydmljZSInLAorCQlzcWwgPT4gIlNFTEVDVCAnY29ubmVjdDJfNSciLAorCQlleHBlY3Rl
ZF9zdGRvdXQgPT4gcXIvY29ubmVjdDJfNS8pOworCiAJIyBSZW1vdmUgZGVmYXVsdCBwZ19zZXJ2
aWNlLmNvbmYuCiAJdW5saW5rKCRzcnZmaWxlX2RlZmF1bHQpOwogfQotLSAKMi41MS4yCgo=
--0000000000003c8b55064da56dab--