Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfRjP-001wuK-2f for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Jan 2026 23:53:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vfRjN-001p3f-3A for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Jan 2026 23:53:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfRjN-001p3W-23 for pgsql-hackers@lists.postgresql.org; Mon, 12 Jan 2026 23:53:53 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vfRjL-0006z0-2V for pgsql-hackers@postgresql.org; Mon, 12 Jan 2026 23:53:53 +0000 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-7cae2330765so4018146a34.0 for ; Mon, 12 Jan 2026 15:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768262030; x=1768866830; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=egm0fZDshgJkkabEk4hEjxkjEm/Ed331M2loUdrTX8o=; b=KBPMULLZBBCbkm/Drg6rFj9aciU+WMTaDnbXMwubrVyzQo9c6gfJXc9tNU1L9IOanf xvZ7s53wmwl2kExCfRCBcamBXMZ2vHByFu7OjV0SjgF3r1kUrmtX0AL4wH/F9XhArAnL F1y3HTWLsLJ+j0JJ7NNDfEohqcibQ+I5MjpMbOQ8/awZXa/o5YUqUyAeL8ZVIVyxJMY8 beG+Gyc+4Wnw/lKK04/K9sobD707AUTRdKHas9aA1zKCtoBs73SLe4AVM042rpiXrtT6 ddy7PCwADzkEOGAsHk/gIFRuNpRjAo744KKqJKEmAEnBywQhTDEOspI6MVhTlBOL1/PX q2SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768262030; x=1768866830; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=egm0fZDshgJkkabEk4hEjxkjEm/Ed331M2loUdrTX8o=; b=CAHrRUwF9kRy5+NyI0pdmKNeYjTatc7rYMtkNKqbUl+h7vvUZZPXA/07U7I40/hJ1Z wUu7c4pgwoO3w/t0ku/THs/ft07q/V95UUG3QQvR5ZclmYkkVEPHYLK2v4W2UyYpmfbt 4++kIImZKre8+l89hilud+P6+LXGCxRavK4rklUaCBGKpWtbrdIy2Ff3A5XeyOMnrXZ8 K4KmWfQMgWj5RrxlTQO+BdKOg6gZVPOX2p0pN+MBGV5TTZjNK+Ne4S6gYtY56cCHkvUr NTeIP1CB20uiR2PUyuM3wM+pofFi3c1BeSE4dMlwe8W+Oarvvhe/CPN/MOH4sy5SwGy2 7uig== X-Gm-Message-State: AOJu0YwlYDzLbKf/UB5musesl8R/qzJWKdJpp+zyefJr8JjHuje4qf6T RicRcEeGzP4/ffTGf4bH9RnY7HaZLjIfB/QJe9X8aVkzfzi9AhrnMrdrXauuqhyYTpLwpjQ7vxN /EMn+bs1quZPO8It8B+vkHWM5qbTREwykhrGa X-Gm-Gg: AY/fxX6Vmbic7i+gwmlhESe9RBr1SKrTwnOhM6KVrx6ooepPxrQZnnWaJ5vE6rbzR3C hhAdJ50JYt0n2E70ufL+hOP81WgxVKMcKnjVG3J6qp6bikYQM3HlBh2KtIR+GHEwfTpm2LChpCP PcTBm7HQWubQCzd2snfvTchTFVWt0kzNkcEl5a1mtOrYvW4/Fp8Ne/uFtCysYb6kwmBMbNiO91f QFO/SP0LVrpZOUcVqpbofmuQ+jL1veBIarYAT+chHJ5v9NLSJ6LjASHsnB5x+pp2cFhIt0Ffrjz DHWXZw== X-Received: by 2002:a05:6820:2bc4:b0:65f:552e:2ceb with SMTP id 006d021491bc7-660f29f93b0mr396217eaf.25.1768262029959; Mon, 12 Jan 2026 15:53:49 -0800 (PST) MIME-Version: 1.0 References: <9FF1E1E8-D9EE-43C5-ADFA-7AE94BA57159@yandex-team.ru> In-Reply-To: <9FF1E1E8-D9EE-43C5-ADFA-7AE94BA57159@yandex-team.ru> From: Andrew Jackson Date: Mon, 12 Jan 2026 17:53:14 -0600 X-Gm-Features: AZwV_Qg39dRsps1ipm84Jjt_TuLGMB_gY7yjdMsKaRnur5AJUu1SrAP7260QFfA Message-ID: Subject: Re: Add ldapservice connection parameter To: Roman Khapov Cc: pgsql-hackers Content-Type: multipart/mixed; boundary="0000000000002a821d06483996fc" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000002a821d06483996fc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Steven and Roman, Thank you for the review. Here is an updated patch that addresses both of these issues. On Mon, Jan 12, 2026 at 4:06=E2=80=AFAM Roman Khapov wrote: > > Hi! > > Thanks for your patch! > > Adding to the one Steven wrote, I noticed one typo in the patch: > > @@ -2337,7 +2337,7 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname > ldapservice > > > - This option specifies an LDAP query that can be used to referenc= e connection paremeters > + This option specifies an LDAP query that can be used to referenc= e connection parameters > stored in an LDAP server. This functionality is described in mor= e detail in . > > > paremeters -> parameters > > -- > Best regards, > Roman Khapov --0000000000002a821d06483996fc Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-ldapservice-connection-parameter.patch" Content-Disposition: attachment; filename="0001-Add-ldapservice-connection-parameter.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mkbtj25n0 RnJvbSBhMzY1YTNhM2NiMWI5YWM5MzdhOTAwOWQxYmQ3MWJmMDZlOWY0ZWVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDb21tYW5kZXJLZXluZXMgPGFuZHJld2phY2tzb245NDdAZ21h aWwuY29tYT4KRGF0ZTogU3VuLCAyMyBNYXIgMjAyNSAxNzoyNzozMiAtMDUwMApTdWJqZWN0OiBb UEFUQ0hdIEFkZCBsZGFwc2VydmljZSBjb25uZWN0aW9uIHBhcmFtZXRlcgoKQ3VycmVudGx5IHRo ZXJlIGV4aXN0cywgb25seSBpbiBwZ19zZXJ2aWNlLmNvbmYsIHRoZSBhYmlsaXR5IHRvIGxvb2sK dXAgY29ubmVjdGlvbiBwYXJhbWV0ZXJzIGZyb20gYSBjZW50cmFsaXplZCBMREFQIHNlcnZlci4g VGhpcyBwYXRjaApleHBhbmRzIHRoZSB1c2FiaWxpdHkgb2YgdGhpcyBiZSBhbGxvd2luZyBpdCB0 byBiZSBzcGVjaWZpZWQgZGlyZWN0bHkgaW4KYSBjb25uZWN0aW9uIHN0cmluZyBpbnN0ZWFkIG9m IG9ubHkgaW4gYSBwZ19zZXJ2aWNlLmNvbmYgZmlsZS4KLS0tCiBkb2Mvc3JjL3NnbWwvbGlicHEu c2dtbCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMCArKysrKysrKysrCiBzcmMvaW50 ZXJmYWNlcy9saWJwcS9mZS1jb25uZWN0LmMgICAgICAgICAgICAgICAgICAgfCAxMiArKysrKysr KysrKysKIHNyYy9pbnRlcmZhY2VzL2xpYnBxL2xpYnBxLWludC5oICAgICAgICAgICAgICAgICAg ICB8ICAxICsKIHNyYy90ZXN0L2xkYXAvdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFtX2xvb2t1 cC5wbCB8IDEyICsrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCsp CgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL2xpYnBxLnNnbWwgYi9kb2Mvc3JjL3NnbWwvbGli cHEuc2dtbAppbmRleCA3ZDA1OTM4ZmVkYS4uMjBhNDhhMjJjNmIgMTAwNjQ0Ci0tLSBhL2RvYy9z cmMvc2dtbC9saWJwcS5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9saWJwcS5zZ21sCkBAIC0yMzMz LDYgKzIzMzMsMTYgQEAgcG9zdGdyZXNxbDovLyUyRnZhciUyRmxpYiUyRnBvc3RncmVzcWwvZGJu YW1lCiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8L3Zhcmxpc3RlbnRyeT4KIAorICAgICA8dmFy bGlzdGVudHJ5IGlkPSJsaWJwcS1jb25uZWN0LWxkYXBzZXJ2aWNlIiB4cmVmbGFiZWw9ImxkYXBz ZXJ2aWNlIj4KKyAgICAgIDx0ZXJtPjxsaXRlcmFsPmxkYXBzZXJ2aWNlPC9saXRlcmFsPjwvdGVy bT4KKyAgICAgIDxsaXN0aXRlbT4KKyAgICAgICA8cGFyYT4KKyAgICAgICAgVGhpcyBvcHRpb24g c3BlY2lmaWVzIGFuIExEQVAgcXVlcnkgdGhhdCBjYW4gYmUgdXNlZCB0byByZWZlcmVuY2UgY29u bmVjdGlvbiBwYXJhbWV0ZXJzCisgICAgICAgIHN0b3JlZCBpbiBhbiBMREFQIHNlcnZlci4gVGhp cyBmdW5jdGlvbmFsaXR5IGlzIGRlc2NyaWJlZCBpbiBtb3JlIGRldGFpbCBpbiA8eHJlZiBsaW5r ZW5kPSJsaWJwcS1sZGFwIi8+LgorICAgICAgICA8L3BhcmE+CisgICAgICA8L2xpc3RpdGVtPgor ICAgICA8L3Zhcmxpc3RlbnRyeT4KKwogICAgICA8dmFybGlzdGVudHJ5IGlkPSJsaWJwcS1jb25u ZWN0LXRhcmdldC1zZXNzaW9uLWF0dHJzIiB4cmVmbGFiZWw9InRhcmdldF9zZXNzaW9uX2F0dHJz Ij4KICAgICAgIDx0ZXJtPjxsaXRlcmFsPnRhcmdldF9zZXNzaW9uX2F0dHJzPC9saXRlcmFsPjwv dGVybT4KICAgICAgIDxsaXN0aXRlbT4KZGlmZiAtLWdpdCBhL3NyYy9pbnRlcmZhY2VzL2xpYnBx L2ZlLWNvbm5lY3QuYyBiL3NyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNvbm5lY3QuYwppbmRleCBh MGQyZjc0OTgxMS4uNmJlMmI3OTJiZTUgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2xpYnBx L2ZlLWNvbm5lY3QuYworKysgYi9zcmMvaW50ZXJmYWNlcy9saWJwcS9mZS1jb25uZWN0LmMKQEAg LTIwNiw2ICsyMDYsMTAgQEAgc3RhdGljIGNvbnN0IGludGVybmFsUFFjb25uaW5mb09wdGlvbiBQ UWNvbm5pbmZvT3B0aW9uc1tdID0gewogCQkiRGF0YWJhc2UtU2VydmljZS1GaWxlIiwgIiIsIDY0 LAogCW9mZnNldG9mKHN0cnVjdCBwZ19jb25uLCBwZ3NlcnZpY2VmaWxlKX0sCiAKKwl7ImxkYXBz ZXJ2aWNlIiwgIlBHTERBUFNFUlZJQ0UiLCBOVUxMLCBOVUxMLAorCQkiRGF0YWJhc2UtTERBUC1T ZXJ2aWNlIiwgIiIsIDIwLAorCW9mZnNldG9mKHN0cnVjdCBwZ19jb25uLCBwZ2xkYXBzZXJ2aWNl KX0sCisKIAl7InVzZXIiLCAiUEdVU0VSIiwgTlVMTCwgTlVMTCwKIAkJIkRhdGFiYXNlLVVzZXIi LCAiIiwgMjAsCiAJb2Zmc2V0b2Yoc3RydWN0IHBnX2Nvbm4sIHBndXNlcil9LApAQCAtNTk1NSwx MiArNTk1OSwyMCBAQCBwYXJzZVNlcnZpY2VJbmZvKFBRY29ubmluZm9PcHRpb24gKm9wdGlvbnMs IFBRRXhwQnVmZmVyIGVycm9yTWVzc2FnZSkKIHsKIAljb25zdCBjaGFyICpzZXJ2aWNlID0gY29u bmluZm9fZ2V0dmFsKG9wdGlvbnMsICJzZXJ2aWNlIik7CiAJY29uc3QgY2hhciAqc2VydmljZV9m bmFtZSA9IGNvbm5pbmZvX2dldHZhbChvcHRpb25zLCAic2VydmljZWZpbGUiKTsKKwljb25zdCBj aGFyICpsZGFwc2VydmljZSA9IGNvbm5pbmZvX2dldHZhbChvcHRpb25zLCAibGRhcHNlcnZpY2Ui KTsKIAljaGFyCQlzZXJ2aWNlRmlsZVtNQVhQR1BBVEhdOwogCWNoYXIJICAgKmVudjsKIAlib29s CQlncm91cF9mb3VuZCA9IGZhbHNlOwogCWludAkJCXN0YXR1czsKIAlzdHJ1Y3Qgc3RhdCBzdGF0 X2J1ZjsKIAorI2lmZGVmIFVTRV9MREFQCisJaWYgKGxkYXBzZXJ2aWNlICE9IE5VTEwpCisJCWlm IChzdHJuY21wKGxkYXBzZXJ2aWNlLCAibGRhcCIsIDQpID09IDApCisJCQlpZiAoIWxkYXBTZXJ2 aWNlTG9va3VwKGxkYXBzZXJ2aWNlLCBvcHRpb25zLCBlcnJvck1lc3NhZ2UpKQorCQkJCXJldHVy biAwOworI2VuZGlmCisKIAkvKgogCSAqIFdlIGhhdmUgdG8gc3BlY2lhbC1jYXNlIHRoZSBlbnZp cm9ubWVudCB2YXJpYWJsZSBQR1NFUlZJQ0UgaGVyZSwgc2luY2UKIAkgKiB0aGlzIGlzIGFuZCBz aG91bGQgYmUgY2FsbGVkIGJlZm9yZSBpbnNlcnRpbmcgZW52aXJvbm1lbnQgZGVmYXVsdHMgZm9y CmRpZmYgLS1naXQgYS9zcmMvaW50ZXJmYWNlcy9saWJwcS9saWJwcS1pbnQuaCBiL3NyYy9pbnRl cmZhY2VzL2xpYnBxL2xpYnBxLWludC5oCmluZGV4IGZiNmE3Y2JmMTVkLi5iNTQwZDNhYzA1NCAx MDA2NDQKLS0tIGEvc3JjL2ludGVyZmFjZXMvbGlicHEvbGlicHEtaW50LmgKKysrIGIvc3JjL2lu dGVyZmFjZXMvbGlicHEvbGlicHEtaW50LmgKQEAgLTM5Miw2ICszOTIsNyBAQCBzdHJ1Y3QgcGdf Y29ubgogCWNoYXIJICAgKnBnc2VydmljZTsJCS8qIFBvc3RncmVzIHNlcnZpY2UsIGlmIGFueSAq LwogCWNoYXIJICAgKnBnc2VydmljZWZpbGU7CS8qIHBhdGggdG8gYSBzZXJ2aWNlIGZpbGUgY29u dGFpbmluZwogCQkJCQkJCQkgKiBzZXJ2aWNlKHMpICovCisJY2hhcgkgICAqcGdsZGFwc2Vydmlj ZTsJLyogUG9zdGdyZXMgTERBUCBzZXJ2aWNlLCBpZiBhbnkgKi8KIAljaGFyCSAgICpwZ3VzZXI7 CQkJLyogUG9zdGdyZXMgdXNlcm5hbWUgYW5kIHBhc3N3b3JkLCBpZiBhbnkgKi8KIAljaGFyCSAg ICpwZ3Bhc3M7CiAJY2hhcgkgICAqcGdwYXNzZmlsZTsJCS8qIHBhdGggdG8gYSBmaWxlIGNvbnRh aW5pbmcgcGFzc3dvcmQocykgKi8KZGlmZiAtLWdpdCBhL3NyYy90ZXN0L2xkYXAvdC8wMDNfbGRh cF9jb25uZWN0aW9uX3BhcmFtX2xvb2t1cC5wbCBiL3NyYy90ZXN0L2xkYXAvdC8wMDNfbGRhcF9j b25uZWN0aW9uX3BhcmFtX2xvb2t1cC5wbAppbmRleCAzNTlmYzdhOTk4YS4uNjk4NWJlNjU0MDgg MTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L2xkYXAvdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFtX2xv b2t1cC5wbAorKysgYi9zcmMvdGVzdC9sZGFwL3QvMDAzX2xkYXBfY29ubmVjdGlvbl9wYXJhbV9s b29rdXAucGwKQEAgLTE5Niw2ICsxOTYsMTggQEAgbG9jYWwgJEVOVntQR1NFUlZJQ0VGSUxFfSA9 ICIkc3J2ZmlsZV9lbXB0eSI7CiAJCWV4cGVjdGVkX3N0ZG91dCA9PgogCQkgIHFyL2RlZmluaXRp b24gb2Ygc2VydmljZSAidW5kZWZpbmVkLXNlcnZpY2UiIG5vdCBmb3VuZC8pOwogCisJJGR1bW15 X25vZGUtPmNvbm5lY3Rfb2soCisJCSJsZGFwc2VydmljZT1sZGFwOi8vbG9jYWxob3N0OiRsZGFw X3BvcnQvZGM9ZXhhbXBsZSxkYz1uZXQ/ZGVzY3JpcHRpb24/b25lPyhjbj1teWRhdGFiYXNlKSIs CisJCSdjb25uZWN0aW9uIHdpdGggY29ycmVjdCAibGRhcHNlcnZpY2UiIHN0cmluZycsCisJCXNx bCA9PiAiU0VMRUNUICdjb25uZWN0Ml80JyIsCisJCWV4cGVjdGVkX3N0ZG91dCA9PiBxci9jb25u ZWN0Ml80Lyk7CisKKwkkZHVtbXlfbm9kZS0+Y29ubmVjdF9vaygKKwkJInBvc3RncmVzOi8vP2xk YXBzZXJ2aWNlPWxkYXAlM0ElMkYlMkZsb2NhbGhvc3QlM0EkbGRhcF9wb3J0JTJGZGMlM0RleGFt cGxlJTJDZGMlM0RuZXQlM0ZkZXNjcmlwdGlvbiUzRm9uZSUzRiUyOGNuJTNEbXlkYXRhYmFzZSUy OSIsCisJCSdjb25uZWN0aW9uIHdpdGggY29ycmVjdCAibGRhcHNlcnZpY2UiJywKKwkJc3FsID0+ ICJTRUxFQ1QgJ2Nvbm5lY3QyXzUnIiwKKwkJZXhwZWN0ZWRfc3Rkb3V0ID0+IHFyL2Nvbm5lY3Qy XzUvKTsKKwogCSMgUmVtb3ZlIGRlZmF1bHQgcGdfc2VydmljZS5jb25mLgogCXVubGluaygkc3J2 ZmlsZV9kZWZhdWx0KTsKIH0KLS0gCjIuNDkuMAoK --0000000000002a821d06483996fc--