MIME-Version: 1.0
References: 
 <CAKK5BkFOFGfKJNbTuYBvE0PfpHmW8iZEmdNogaCYqjAOhtNgDg@mail.gmail.com>
 <9FF1E1E8-D9EE-43C5-ADFA-7AE94BA57159@yandex-team.ru>
 <CAKK5BkFxWnddC2=mbHpojWnOLe=x3vLftaMUkO3ocJwqZN7Tug@mail.gmail.com>
 <CAKK5BkE_+rCKgZz7+VNNfH_Jm1H6=RcHxg8mmojyR8pu-LOh5w@mail.gmail.com>
 <ba65c0452e7f8218b23f958e4099f98cbabe8bf8.camel@cybertec.at>
 <CAKK5BkH9tp59VP4n0xS0idcrj+HdLJAKzkkiMTsrynyKvYyXFw@mail.gmail.com>
 <67B39BDD-233A-4413-B267-19E7B8BB643A@yandex-team.ru>
In-Reply-To: <67B39BDD-233A-4413-B267-19E7B8BB643A@yandex-team.ru>
From: Andrew Jackson <andrewjackson947@gmail.com>
Date: Mon, 30 Mar 2026 12:32:20 -0500
Message-ID: 
 <CAKK5BkHADztFq3xUv31bQjgJ6-6y4950c=r_0x7t9KFSrD6hvg@mail.gmail.com>
Subject: Re: Add ldapservice connection parameter
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
	Roman Khapov <rkhapov@yandex-team.ru>, niushiji@gmail.com
Content-Type: multipart/mixed; boundary="000000000000d71cd8064e413d1d"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKK5BkHADztFq3xUv31bQjgJ6-6y4950c%3Dr_0x7t9KFSrD6hvg%40mail.gmail.com>
Precedence: bulk

--000000000000d71cd8064e413d1d
Content-Type: text/plain; charset="UTF-8"

Andrey,

Thank you for the review.

>I like "ldapservice" approach more. I don't like breaking changes, even for very small number of users.

After thinking about it more it would be pretty easy to make this non
breaking for users. The attached patch
`pgservice-0002-Allow-LDAP-lookup-from-pgservice-connection-paramete.patch`
implements this. Basically if the ldap connection parameter happens to
already exist in pg_service, no LDAP lookup is performed, the values
are instead taken from the pg_service.conf file. I'm fine with either
implementation direction that is the most simple though.

Also attaching the patch
`ldapserviceurl-0005-Add-ldapservice-connection-parameter.patch` which
addresses some issues you found with the previous patch.
- renames parameter from ldapservice to ldapserviceurl
- Adds a comment above the ldapserviceurl call explaining the reason
for ignoring any error info besides zero/non-zero
- Changes dispsize to 64. In reality it maybe should be higher but I
was not comfortable changing it to something like 1024 because it was
an order of magnitude larger than anything else. Just set it to the
current max of 64.
- Also moved the parameter definition and added comments about how it
is defined even on non LDAP builds. This coincides with similar
comments for SSL/GSS specific parameters, though there are no such
comments left for oauth.

Let me know if there is anything else you see missing.

Thanks again,
Andrew Jackson

--000000000000d71cd8064e413d1d
Content-Type: text/x-patch; charset="US-ASCII";
	name="pgservice-0002-Allow-LDAP-lookup-from-pgservice-connection-paramete.patch"
Content-Disposition: attachment;
	filename="pgservice-0002-Allow-LDAP-lookup-from-pgservice-connection-paramete.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mndgrsld0>
X-Attachment-Id: f_mndgrsld0

RnJvbSAwMDIwZDIwMjdiNTgxZTZiZGZjNWI3ODc4NWE5YjkxNzFiN2Y3ZWYyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgSmFja3NvbiA8YWphY2tzb25AZHJ3aG9sZGluZ3Mu
Y29tPgpEYXRlOiBTYXQsIDI4IE1hciAyMDI2IDIzOjI5OjQ4IC0wNTAwClN1YmplY3Q6IFtQQVRD
SF0gQWxsb3cgTERBUCBsb29rdXAgZnJvbSBwZ3NlcnZpY2UgY29ubmVjdGlvbiBwYXJhbWV0ZXIK
CkN1cnJlbnRseSB0aGVyZSBleGlzdHMsIG9ubHkgaW4gcGdfc2VydmljZS5jb25mLCB0aGUgYWJp
bGl0eSB0byBsb29rCnVwIGNvbm5lY3Rpb24gcGFyYW1ldGVycyBmcm9tIGEgY2VudHJhbGl6ZWQg
TERBUCBzZXJ2ZXIuIFRoaXMgcGF0Y2gKZXhwYW5kcyB0aGUgdXNhYmlsaXR5IG9mIHRoaXMgYmUg
YWxsb3dpbmcgaXQgdG8gYmUgc3BlY2lmaWVkIGRpcmVjdGx5IGluCmEgY29ubmVjdGlvbiBzdHJp
bmcgaW5zdGVhZCBvZiBvbmx5IGluIGEgcGdfc2VydmljZS5jb25mIGZpbGUuCgpUaGlzIHBhdGNo
IGFkZHMgYSBjaGVjayBpbiBwYXJzZVNlcnZpY2VJbmZvIHRoYXQgY2hlY2tzIGlmIHBnc2Vydmlj
ZSBpcwphbiBMREFQIHNjaGVtZSBhZGRyZXNzIGFuZCBpZiBzbyBhdHRlbXB0cyB0byBjb25uZWN0
IHRvIHRoYXQgTERBUCBzZXJ2ZXIKYW5kIGdyYWIgY29ubmVjdGlvbiBwYXJhbWV0ZXJzIGZyb20g
dGhlcmUuIFRoaXMgaXMgYSBicmVha2luZyBjaGFuZ2UgaW4KdGhhdCBpdCBpcyBwb3NzaWJsZSB0
aGF0IHBlb3BsZSBwcmV2aW91c2x5IG5hbWVkIHRoZWlyIHBnc2VydmljZSBhZnRlcgphbiBMREFQ
IGFkZHJlc3MuCgp2MDAwMiBwYXRjaAoKVGhpcyBwYXRjaCBSZW1vdmVzIGFsbCBiYWNrd2FyZHMg
Y29tcGF0aWJpbGl0eSBpc3N1ZXMuIE5vdyBpZiB0aGUgTERBUApVUkwgd2FzIHNwZWNpZmllZCBp
biBwZ19zZXJ2aWNlLmNvbmYgdGhlbiB0aGUgdmFsdWVzIGZyb20KcGdfc2VydmljZS5jb25mIHdp
bGwgYmUgdXNlZCBhbmQgdGhlIExEQVAgbG9va3VwIHdpbGwgbm90IGJlIHBlcmZvcm1lZC4KCkNv
b2wKLS0tCiBkb2Mvc3JjL3NnbWwvbGlicHEuc2dtbCAgICAgICAgICAgICAgICAgICAgICAgfCAg
NiArKysKIHNyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNvbm5lY3QuYyAgICAgICAgICAgICB8ICA1
ICsrCiAuLi4vdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFtX2xvb2t1cC5wbCAgICAgfCA0OCAr
KysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKykKCmRp
ZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvbGlicHEuc2dtbCBiL2RvYy9zcmMvc2dtbC9saWJwcS5z
Z21sCmluZGV4IDZkYjgyMzgwOGZjLi44OGE1ZGIyMzg4ZCAxMDA2NDQKLS0tIGEvZG9jL3NyYy9z
Z21sL2xpYnBxLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2xpYnBxLnNnbWwKQEAgLTIzMzMsNiAr
MjMzMywxMiBAQCBwb3N0Z3Jlc3FsOi8vJTJGdmFyJTJGbGliJTJGcG9zdGdyZXNxbC9kYm5hbWUK
ICAgICAgICAgbmFtZSBpbiA8ZmlsZW5hbWU+cGdfc2VydmljZS5jb25mPC9maWxlbmFtZT4gdGhh
dCBob2xkcyBhZGRpdGlvbmFsIGNvbm5lY3Rpb24gcGFyYW1ldGVycy4KICAgICAgICAgVGhpcyBh
bGxvd3MgYXBwbGljYXRpb25zIHRvIHNwZWNpZnkgb25seSBhIHNlcnZpY2UgbmFtZSBzbyBjb25u
ZWN0aW9uIHBhcmFtZXRlcnMKICAgICAgICAgY2FuIGJlIGNlbnRyYWxseSBtYWludGFpbmVkLiBT
ZWUgPHhyZWYgbGlua2VuZD0ibGlicHEtcGdzZXJ2aWNlIi8+LgorCisgICAgICAgIFlvdSBjYW4g
YWxzbyBzcGVjaWZ5IGFuIExEQVAgVVJMIGhlcmUgd2hpY2ggd2lsbCBsb29rIHVwIGNvbm5lY3Rp
b24gcGFyYW1ldGVycyBmcm9tIGFuCisgICAgICAgIExEQVAgc2VydmVyLiBTZWUgPHhyZWYgbGlu
a2VuZD0ibGlicHEtbGRhcCIvPi4gUGxlYXNlIG5vdGUgdGhhdCBpZiB0aGUgTERBUCBVUkwKKyAg
ICAgICAgc3BlY2lmaWVkIGhlcmUgZXhpc3RzIGFzIGEgc2VydmljZSBuYW1lIGluIDxmaWxlbmFt
ZT5wZ19zZXJ2aWNlLmNvbmY8L2ZpbGVuYW1lPiwgdGhlbgorICAgICAgICB0aGUgPGZpbGVuYW1l
PnBnX3NlcnZpY2UuY29uZjwvZmlsZW5hbWU+IHZhbHVlcyB3aWxsIGJlIHVzZWQgaW5zdGVhZCBh
bmQgbm8gTERBUCBsb29rdXAKKyAgICAgICAgd2lsbCBiZSBwZXJmb3JtZWQuCiAgICAgICAgPC9w
YXJhPgogICAgICAgPC9saXN0aXRlbT4KICAgICAgPC92YXJsaXN0ZW50cnk+CmRpZmYgLS1naXQg
YS9zcmMvaW50ZXJmYWNlcy9saWJwcS9mZS1jb25uZWN0LmMgYi9zcmMvaW50ZXJmYWNlcy9saWJw
cS9mZS1jb25uZWN0LmMKaW5kZXggZGI5YjRjOGVkYmYuLmIxMmI5YmNlYjEyIDEwMDY0NAotLS0g
YS9zcmMvaW50ZXJmYWNlcy9saWJwcS9mZS1jb25uZWN0LmMKKysrIGIvc3JjL2ludGVyZmFjZXMv
bGlicHEvZmUtY29ubmVjdC5jCkBAIC02MDQ4LDYgKzYwNDgsMTEgQEAgbmV4dF9maWxlOgogbGFz
dF9maWxlOgogCWlmICghZ3JvdXBfZm91bmQpCiAJeworI2lmZGVmIFVTRV9MREFQCisJCWlmIChz
dHJuY21wKHNlcnZpY2UsICJsZGFwIiwgNCkgPT0gMCkKKwkJCS8qIGlmIGVycm9yIGlnbm9yZSBs
ZGFwU2VydmljZUxvb2t1cCByZXR1cm4gdmFsdWUsIGp1c3QgcmV0dXJuIDMgKi8KKwkJCXJldHVy
biBsZGFwU2VydmljZUxvb2t1cChzZXJ2aWNlLCBvcHRpb25zLCBlcnJvck1lc3NhZ2UpID8gMyA6
IDA7CisjZW5kaWYKIAkJbGlicHFfYXBwZW5kX2Vycm9yKGVycm9yTWVzc2FnZSwgImRlZmluaXRp
b24gb2Ygc2VydmljZSBcIiVzXCIgbm90IGZvdW5kIiwgc2VydmljZSk7CiAJCXJldHVybiAzOwog
CX0KZGlmZiAtLWdpdCBhL3NyYy90ZXN0L2xkYXAvdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFt
X2xvb2t1cC5wbCBiL3NyYy90ZXN0L2xkYXAvdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFtX2xv
b2t1cC5wbAppbmRleCAzNTlmYzdhOTk4YS4uOTc2YzE5NmRmOGMgMTAwNjQ0Ci0tLSBhL3NyYy90
ZXN0L2xkYXAvdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFtX2xvb2t1cC5wbAorKysgYi9zcmMv
dGVzdC9sZGFwL3QvMDAzX2xkYXBfY29ubmVjdGlvbl9wYXJhbV9sb29rdXAucGwKQEAgLTYyLDYg
KzYyLDIwIEBAIGRlc2NyaXB0aW9uOnBvcnQ9fSAuICRub2RlLT5wb3J0IC4gcXF7CiAKICRsZGFw
LT5sZGFwYWRkX2ZpbGUoJGxkaWZfdmFsaWQpOwogCitteSAkbGRpZl92YWxpZF9pbnZhbGlkID0g
IiR0ZC9jb25uZWN0aW9uX3BhcmFtc19sZGlmX3ZhbGlkX2ludmFsaWQubGRpZiI7CithcHBlbmRf
dG9fZmlsZSgKKwkkbGRpZl92YWxpZF9pbnZhbGlkICwgcXF7Cit2ZXJzaW9uOjEKK2RuOmNuPW15
ZGF0YWJhc2Vmb3VuZGlucGdzZXJ2aWNlLGRjPWV4YW1wbGUsZGM9bmV0CitjaGFuZ2V0eXBlOmFk
ZAorb2JqZWN0Y2xhc3M6dG9wCitvYmplY3RjbGFzczpkZXZpY2UKK2NuOm15ZGF0YWJhc2Vmb3Vu
ZGlucGdzZXJ2aWNlCitkZXNjcmlwdGlvbjpob3N0PX0gLiAkbm9kZS0+aG9zdCAuIHFxeworZGVz
Y3JpcHRpb246cG9ydD19IC4gJG5vZGUtPnBvcnQgLiBxcXsKK30pOworJGxkYXAtPmxkYXBhZGRf
ZmlsZSgkbGRpZl92YWxpZF9pbnZhbGlkKTsKKwogbXkgKCRsZGFwX3NlcnZlciwgJGxkYXBfcG9y
dCwgJGxkYXBzX3BvcnQsICRsZGFwX3VybCwKIAkkbGRhcHNfdXJsLCAkbGRhcF9iYXNlZG4sICRs
ZGFwX3Jvb3RkbgogKSA9ICRsZGFwLT5wcm9wKHF3KHNlcnZlciBwb3J0IHNfcG9ydCB1cmwgc191
cmwgYmFzZWRuIHJvb3RkbikpOwpAQCAtODAsNiArOTQsOSBAQCBhcHBlbmRfdG9fZmlsZSgKIAkk
c3J2ZmlsZV92YWxpZCwgcXF7CiBbbXlfc3J2XQogbGRhcDovL2xvY2FsaG9zdDokbGRhcF9wb3J0
L2RjPWV4YW1wbGUsZGM9bmV0P2Rlc2NyaXB0aW9uP29uZT8oY249bXlkYXRhYmFzZSkKKworW2xk
YXA6Ly9sb2NhbGhvc3Q6JGxkYXBfcG9ydC9kYz1leGFtcGxlLGRjPW5ldD9kZXNjcmlwdGlvbj9v
bmU/KGNuPW15ZGF0YWJhc2Vmb3VuZGlucGdzZXJ2aWNlKV0KK3BvcnQ9MTIzNAogfSk7CiAKICMg
RmlsZSBkZWZpbmVkIHdpdGggbm8gY29udGVudHMsIHVzZWQgYXMgZGVmYXVsdCB2YWx1ZSBmb3IK
QEAgLTE5Niw2ICsyMTMsMzcgQEAgbG9jYWwgJEVOVntQR1NFUlZJQ0VGSUxFfSA9ICIkc3J2Zmls
ZV9lbXB0eSI7CiAJCWV4cGVjdGVkX3N0ZG91dCA9PgogCQkgIHFyL2RlZmluaXRpb24gb2Ygc2Vy
dmljZSAidW5kZWZpbmVkLXNlcnZpY2UiIG5vdCBmb3VuZC8pOwogCisJZGVsZXRlICRFTlZ7UEdT
RVJWSUNFfTsKKworCSRkdW1teV9ub2RlLT5jb25uZWN0X29rKAorCQkic2VydmljZT1sZGFwOi8v
bG9jYWxob3N0OiRsZGFwX3BvcnQvZGM9ZXhhbXBsZSxkYz1uZXQ/ZGVzY3JpcHRpb24/b25lPyhj
bj1teWRhdGFiYXNlKSIsCisJCSdjb25uZWN0aW9uIHdpdGggY29ycmVjdCAic2VydmljZSIgc3Ry
aW5nIHBvcHVsYXRlZCB3aXRoIExEQVAgYWRkcmVzcycsCisJCXNxbCA9PiAiU0VMRUNUICdjb25u
ZWN0Ml80JyIsCisJCWV4cGVjdGVkX3N0ZG91dCA9PiBxci9jb25uZWN0Ml80Lyk7CisKKwkkZHVt
bXlfbm9kZS0+Y29ubmVjdF9vaygKKwkJInBvc3RncmVzOi8vP3NlcnZpY2U9bGRhcCUzQSUyRiUy
RmxvY2FsaG9zdCUzQSRsZGFwX3BvcnQlMkZkYyUzRGV4YW1wbGUlMkNkYyUzRG5ldCUzRmRlc2Ny
aXB0aW9uJTNGb25lJTNGJTI4Y24lM0RteWRhdGFiYXNlJTI5IiwKKwkJJ2Nvbm5lY3Rpb24gd2l0
aCBjb3JyZWN0ICJsZGFwc2VydmljZSIgc3RyaW5nIHBvcHVsYXRlZCB3aXRoIExEQVAgYWRkcmVz
cycsCisJCXNxbCA9PiAiU0VMRUNUICdjb25uZWN0Ml81JyIsCisJCWV4cGVjdGVkX3N0ZG91dCA9
PiBxci9jb25uZWN0Ml81Lyk7CisKKwlsb2NhbCAkRU5We1BHU0VSVklDRX0gPSAibGRhcDovL2xv
Y2FsaG9zdDokbGRhcF9wb3J0L2RjPWV4YW1wbGUsZGM9bmV0P2Rlc2NyaXB0aW9uP29uZT8oY249
bXlkYXRhYmFzZSkiOworCSRkdW1teV9ub2RlLT5jb25uZWN0X29rKAorCQkiIiwKKwkJJ2Nvbm5l
Y3Rpb24gd2l0aCBjb3JyZWN0ICJzZXJ2aWNlIiBwcm92aWRlZCBieSBlbnYgdmFyIHBvcHVsYXRl
ZCB3aXRoIExEQVAgYWRkcmVzcycsCisJCXNxbCA9PiAiU0VMRUNUICdjb25uZWN0Ml82JyIsCisJ
CWV4cGVjdGVkX3N0ZG91dCA9PiBxci9jb25uZWN0Ml82Lyk7CisJZGVsZXRlICRFTlZ7UEdMREFQ
U0VSVklDRX07CisKKwkjIEJlbG93IHRlc3Qgc2hvdWxkIGZhaWwgYmVjYXVzZSB0aGUgc2Vydmlj
ZSB2YWx1ZSBpcyBkZWZpbmVkIGFzIGEgbGl0ZXJhbCBzZXJ2aWNlIGluIHBnX3NlcnZpY2UuY29u
Zi4KKwkjIFRoZSBwZ19zZXJ2aWNlLmNvbmYgZW50cnkgc2hvdWxkIGhhdmUgYW4gaW5jb3JyZWN0
IHBvcnQgYW5kIExEQVAgc2hvdWxkIG5vdCBiZSBsb29rZWQgdXAgYWZ0ZXIgcmVhZGluZworCSMg
dGhlIGluY29ycmVjdCBwb3J0CisJJGR1bW15X25vZGUtPmNvbm5lY3RfZmFpbHMoCisJCSdzZXJ2
aWNlPWxkYXA6Ly9sb2NhbGhvc3Q6JGxkYXBfcG9ydC9kYz1leGFtcGxlLGRjPW5ldD9kZXNjcmlw
dGlvbj9vbmU/KGNuPW15ZGF0YWJhc2Vmb3VuZGlucGdzZXJ2aWNlKSInLAorCQknY29ubmVjdGlv
biB1c2luZyBjbj1teWRhdGFiYXNlZm91bmRpbnBnc2VydmljZScsCisJCWV4cGVjdGVkX3N0ZG91
dCA9PgorCQkgIHFyL2RlZmluaXRpb24gb2Ygc2VydmljZSAidW5kZWZpbmVkLXNlcnZpY2UiIG5v
dCBmb3VuZC8pOworCiAJIyBSZW1vdmUgZGVmYXVsdCBwZ19zZXJ2aWNlLmNvbmYuCiAJdW5saW5r
KCRzcnZmaWxlX2RlZmF1bHQpOwogfQotLSAKMi41MS4yCgo=
--000000000000d71cd8064e413d1d
Content-Type: text/x-patch; charset="US-ASCII";
	name="ldapserviceurl-0005-Add-ldapservice-connection-parameter.patch"
Content-Disposition: attachment;
	filename="ldapserviceurl-0005-Add-ldapservice-connection-parameter.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mndgsu6w1>
X-Attachment-Id: f_mndgsu6w1

RnJvbSBiNTY5Njg1OTkwMzdmNDAyYjBiNGMwNDA0ODNiZDY3ZTYxYmYyNDI5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgSmFja3NvbiA8YWphY2tzb25AZHJ3aG9sZGluZ3Mu
Y29tPgpEYXRlOiBTYXQsIDI4IE1hciAyMDI2IDIzOjI5OjQ4IC0wNTAwClN1YmplY3Q6IFtQQVRD
SF0gQWRkIGxkYXBzZXJ2aWNlIGNvbm5lY3Rpb24gcGFyYW1ldGVyCgpDdXJyZW50bHkgdGhlcmUg
ZXhpc3RzLCBvbmx5IGluIHBnX3NlcnZpY2UuY29uZiwgdGhlIGFiaWxpdHkgdG8gbG9vawp1cCBj
b25uZWN0aW9uIHBhcmFtZXRlcnMgZnJvbSBhIGNlbnRyYWxpemVkIExEQVAgc2VydmVyLiBUaGlz
IHBhdGNoCmV4cGFuZHMgdGhlIHVzYWJpbGl0eSBvZiB0aGlzIGJlIGFsbG93aW5nIGl0IHRvIGJl
IHNwZWNpZmllZCBkaXJlY3RseSBpbgphIGNvbm5lY3Rpb24gc3RyaW5nIGluc3RlYWQgb2Ygb25s
eSBpbiBhIHBnX3NlcnZpY2UuY29uZiBmaWxlLgoKVGhpcyBhZGRzIHRoZSBQR0xEQVBTRVJWSUNF
IGVudiB2YXIgdGhhdCBwcm92aWRlcyBhbiBlbnZ2YXIgaW50ZXJmYWNlCnRvIHRoaXMgZnVuY3Rp
b25hbGl0eS4gQWxzbyB0aGUgZnVuY3Rpb25hbGl0eSBoYXMgYmVlbiBtb3ZlZCB0bwpjb25uaW5m
b19hZGRfZGVmYXVsdHMgYWZ0ZXIgcmV2aWV3LiBBbHNvIDIgdGVzdHMgaGF2ZSBiZWVuIGFkZGVk
LiBPbmUgdG8KdmFsaWRhdGUgdGhlIGVudiB2YXIgZnVuY3Rpb25hbGl0eSBhbmQgb25lIHRvIHZh
bGlkYXRlIHRoYXQgdGhpcwpwYXJhbWV0ZXIgaXMgaWdub3JlZCB3aGVuIHVzZWQgaW4gcGdfc2Vy
dmljZS5jb25mIGZpbGVzLgoKLS0gMDAwNSBwYXRjaCBjaGFuZ2VzClRoaXMgcGF0Y2ggY2hhbmdl
cyB0aGUgcmVsZXZhbnQgbmFtaW5nIGZyb20gbGRhcHNlcnZpY2UgdG8KbGRhcHNlcnZpY2V1cmwu
IEkgYWxzbyBhZGQgYSBjb21tZW50IGFib3ZlIHRoZSBuZXcgbGRhcHNlcnZpY2Vsb29rdXAKY2Fs
bCB0aGF0IGV4cGxhaW5zIHRoZSByZWFzb25pbmcgZm9yIGlnbm9yaW5nIGFsbCBub24gemVybyBy
ZXR1cm4gY29kZXMuCkFsc28gSSBpbmNyZWFzZSB0aGUgdmFsdWUgb2YgZGlzcHNpemUgZm9yIGxk
YXBzZXJ2aWNldXJsIGZyb20gMjAgdG8gNjQuCkl0IGNvdWxkIGJlIHJlYXNvbmFibGUgdG8gaW5j
cmVhc2UgaXQgcGFzdCA2NCwgd2FzIG9yaWdpbmFsbHkgdGhpbmtpbmcKYWJvdXQgYnVtcGluZyBp
dCB0byAxMDI0IGJ1dCBJIGFtIG5vdCBzdXJlIHdoYXQgdGhlc2UgdmFsdWVzIGFyZSB1c2VkCmZv
ciBpbiB0aGUgY29kZWJhc2UgYW5kIHRob3VnaHQgaXQgd2FzIHNhZmVyIHRvIGp1c3QgYnVtcCBp
dCB0byB0aGUKY3VycmVudGx5IGV4aXN0aW5nIG1heCBmb3IgYW55IHBhcmFtZXRlci4gTW92ZXMg
dGhlIHBsYWNlbWVudCBvZgpsZGFwc2VydmljZXVybCB0byBiZWxvdyB0aGUgR1NTIG9wdGlvbnMg
YW5kIGFkZHMgYSBjb21tZW50IGV4cGxhaW5pbmcKdGhhdCB0aGUgcGFyYW1ldGVyIGlzIGV4cG9z
ZWQgZXZlbiBpbiBub24gTERBUCBidWlsZHMuIFRoaXMgd2FzIGRvbmUgdG8KcmVmbGVjdCBzaW1p
bGFyIGNvbW1lbnRzIGluIEdTUy9TU0wsIHRob3VnaCB0aGlzIGNvbW1lbnQgZG9lcyBub3QgZXhp
c3QKZm9yIHRoZSBuZXcgT0FVVEggcGFyYW1ldGVycyBzbyB0aGlzIG1heSBub3QgaGF2ZSBiZWVu
IGEgZ29vZCBjaG9pY2UuCkFsc28gQWRkIGZpbGVuYW1lIHRhZ3MgdG8gZmlsZW5hbWUgcmVmZXJl
bmNlIGluIGRvY3MKLS0tCiBkb2Mvc3JjL3NnbWwvbGlicHEuc2dtbCAgICAgICAgICAgICAgICAg
ICAgICAgfCAyMyArKysrKysrKysrKysrKysKIHNyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNvbm5l
Y3QuYyAgICAgICAgICAgICB8IDI0ICsrKysrKysrKysrKysrKwogc3JjL2ludGVyZmFjZXMvbGli
cHEvbGlicHEtaW50LmggICAgICAgICAgICAgIHwgIDEgKwogLi4uL3QvMDAzX2xkYXBfY29ubmVj
dGlvbl9wYXJhbV9sb29rdXAucGwgICAgIHwgMjkgKysrKysrKysrKysrKysrKysrKwogNCBmaWxl
cyBjaGFuZ2VkLCA3NyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL2xp
YnBxLnNnbWwgYi9kb2Mvc3JjL3NnbWwvbGlicHEuc2dtbAppbmRleCA2ZGI4MjM4MDhmYy4uMGU0
YjdmODE1NTEgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9saWJwcS5zZ21sCisrKyBiL2RvYy9z
cmMvc2dtbC9saWJwcS5zZ21sCkBAIC0yMzUwLDYgKzIzNTAsMTkgQEAgcG9zdGdyZXNxbDovLyUy
RnZhciUyRmxpYiUyRnBvc3RncmVzcWwvZGJuYW1lCiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8
L3Zhcmxpc3RlbnRyeT4KIAorICAgICA8dmFybGlzdGVudHJ5IGlkPSJsaWJwcS1jb25uZWN0LWxk
YXBzZXJ2aWNldXJsIiB4cmVmbGFiZWw9ImxkYXBzZXJ2aWNldXJsIj4KKyAgICAgIDx0ZXJtPjxs
aXRlcmFsPmxkYXBzZXJ2aWNldXJsPC9saXRlcmFsPjwvdGVybT4KKyAgICAgIDxsaXN0aXRlbT4K
KyAgICAgICA8cGFyYT4KKyAgICAgICAgVGhpcyBvcHRpb24gc3BlY2lmaWVzIGFuIExEQVAgcXVl
cnkgdGhhdCBjYW4gYmUgdXNlZCB0byByZWZlcmVuY2UgY29ubmVjdGlvbiBwYXJhbWV0ZXJzCisg
ICAgICAgIHN0b3JlZCBvbiBhbiBMREFQIHNlcnZlci4gQW55IGNvbm5lY3Rpb24gcGFyYW1ldGVy
IHRoYXQgaXMgbG9va2VkIHVwIGluIHRoaXMgd2F5IGlzCisgICAgICAgIG92ZXJyaWRkZW4gYnkg
ZXhwbGljaXRseSBuYW1lZCBjb25uZWN0aW9uIHBhcmFtZXRlcnMuIFRoaXMgcGFyYW1ldGVyIGlz
IGlnbm9yZWQgd2hlbiB1c2VkCisgICAgICAgIGluIGEgPGZpbGVuYW1lPnBnX3NlcnZpY2UuY29u
ZjwvZmlsZW5hbWU+IGZpbGUuIFRoaXMgZnVuY3Rpb25hbGl0eSBpcyBkZXNjcmliZWQgaW4gbW9y
ZQorICAgICAgICBkZXRhaWwgaW4gPHhyZWYgbGlua2VuZD0ibGlicHEtbGRhcCIvPi4KKyAgICAg
ICAgPC9wYXJhPgorICAgICAgPC9saXN0aXRlbT4KKyAgICAgPC92YXJsaXN0ZW50cnk+CisKICAg
ICAgPHZhcmxpc3RlbnRyeSBpZD0ibGlicHEtY29ubmVjdC10YXJnZXQtc2Vzc2lvbi1hdHRycyIg
eHJlZmxhYmVsPSJ0YXJnZXRfc2Vzc2lvbl9hdHRycyI+CiAgICAgICA8dGVybT48bGl0ZXJhbD50
YXJnZXRfc2Vzc2lvbl9hdHRyczwvbGl0ZXJhbD48L3Rlcm0+CiAgICAgICA8bGlzdGl0ZW0+CkBA
IC05MTcwLDYgKzkxODMsMTYgQEAgbXlFdmVudFByb2MoUEdFdmVudElkIGV2dElkLCB2b2lkICpl
dnRJbmZvLCB2b2lkICpwYXNzVGhyb3VnaCkKICAgICAgPC9wYXJhPgogICAgIDwvbGlzdGl0ZW0+
CiAKKyAgICA8bGlzdGl0ZW0+CisgICAgIDxwYXJhPgorICAgICAgPGluZGV4dGVybT4KKyAgICAg
ICA8cHJpbWFyeT48ZW52YXI+UEdMREFQU0VSVklDRVVSTDwvZW52YXI+PC9wcmltYXJ5PgorICAg
ICAgPC9pbmRleHRlcm0+CisgICAgICA8ZW52YXI+UEdMREFQU0VSVklDRVVSTDwvZW52YXI+IGJl
aGF2ZXMgdGhlIHNhbWUgYXMgdGhlCisgICAgICA8eHJlZiBsaW5rZW5kPSJsaWJwcS1jb25uZWN0
LWxkYXBzZXJ2aWNldXJsIi8+IGNvbm5lY3Rpb24gcGFyYW1ldGVyLgorICAgICA8L3BhcmE+Cisg
ICAgPC9saXN0aXRlbT4KKwogICAgIDxsaXN0aXRlbT4KICAgICAgPHBhcmE+CiAgICAgICA8aW5k
ZXh0ZXJtPgpkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvbGlicHEvZmUtY29ubmVjdC5jIGIv
c3JjL2ludGVyZmFjZXMvbGlicHEvZmUtY29ubmVjdC5jCmluZGV4IGRiOWI0YzhlZGJmLi5kMDc2
YmZlNzcwMSAxMDA2NDQKLS0tIGEvc3JjL2ludGVyZmFjZXMvbGlicHEvZmUtY29ubmVjdC5jCisr
KyBiL3NyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNvbm5lY3QuYwpAQCAtMzc2LDYgKzM3NiwxNSBA
QCBzdGF0aWMgY29uc3QgaW50ZXJuYWxQUWNvbm5pbmZvT3B0aW9uIFBRY29ubmluZm9PcHRpb25z
W10gPSB7CiAJCSJHU1MtZGVsZWdhdGlvbiIsICIiLCAxLAogCW9mZnNldG9mKHN0cnVjdCBwZ19j
b25uLCBnc3NkZWxlZ2F0aW9uKX0sCiAKKwkvKgorCSAqIEFzIHdpdGggU1NMIGFuZCBHU1Mgb3B0
aW9ucywgbGRhcHNlcnZpY2V1cmwgaXMgZXhwb3NlZCBldmVuIGluIGJ1aWxkcworCSAqIHRoYXQg
ZG8gbm90IGhhdmUgc3VwcG9ydAorCSAqLworCXsibGRhcHNlcnZpY2V1cmwiLCAiUEdMREFQU0VS
VklDRVVSTCIsIE5VTEwsIE5VTEwsCisJCSJEYXRhYmFzZS1MREFQLVNlcnZpY2UiLCAiIiwgNjQs
CisJb2Zmc2V0b2Yoc3RydWN0IHBnX2Nvbm4sIHBnbGRhcHNlcnZpY2V1cmwpfSwKKworCiAJeyJy
ZXBsaWNhdGlvbiIsIE5VTEwsIE5VTEwsIE5VTEwsCiAJCSJSZXBsaWNhdGlvbiIsICJEIiwgNSwK
IAlvZmZzZXRvZihzdHJ1Y3QgcGdfY29ubiwgcmVwbGljYXRpb24pfSwKQEAgLTY3MjYsNiArNjcz
NSwyMSBAQCBjb25uaW5mb19hZGRfZGVmYXVsdHMoUFFjb25uaW5mb09wdGlvbiAqb3B0aW9ucywg
UFFFeHBCdWZmZXIgZXJyb3JNZXNzYWdlKQogCVBRY29ubmluZm9PcHRpb24gKnNzbG1vZGVfZGVm
YXVsdCA9IE5VTEwsCiAJCQkgICAqc3Nscm9vdGNlcnQgPSBOVUxMOwogCWNoYXIJICAgKnRtcDsK
KyNpZmRlZiBVU0VfTERBUAorCWNvbnN0IGNoYXIgKmxkYXBzZXJ2aWNldXJsID0gY29ubmluZm9f
Z2V0dmFsKG9wdGlvbnMsICJsZGFwc2VydmljZXVybCIpOworCisJaWYgKGxkYXBzZXJ2aWNldXJs
ID09IE5VTEwpCisJCWxkYXBzZXJ2aWNldXJsID0gZ2V0ZW52KCJQR0xEQVBTRVJWSUNFVVJMIik7
CisKKwlpZiAobGRhcHNlcnZpY2V1cmwgIT0gTlVMTCkKKworCQkvKgorCQkgKiBsZGFwU2Vydmlj
ZUxvb2t1cCBoYXMgNCBwb3RlbnRpYWwgcmV0dXJuIHZhbHVlcy4gV2Ugb25seSBjYXJlIGhlcmUK
KwkJICogaWYgaXQgc3VjY2VlZGVkLCBpZiBpdCBmYWlsZWQgd2UgZG9udCBjYXJlIHdoeSwgcmV0
dXJuIGZhaWx1cmUuCisJCSAqLworCQlpZiAobGRhcFNlcnZpY2VMb29rdXAobGRhcHNlcnZpY2V1
cmwsIG9wdGlvbnMsIGVycm9yTWVzc2FnZSkgIT0gMCkKKwkJCXJldHVybiBmYWxzZTsKKyNlbmRp
ZgogCiAJLyoKIAkgKiBJZiB0aGVyZSdzIGEgc2VydmljZSBzcGVjLCB1c2UgaXQgdG8gb2J0YWlu
IGFueSBub3QtZXhwbGljaXRseS1naXZlbgpkaWZmIC0tZ2l0IGEvc3JjL2ludGVyZmFjZXMvbGli
cHEvbGlicHEtaW50LmggYi9zcmMvaW50ZXJmYWNlcy9saWJwcS9saWJwcS1pbnQuaAppbmRleCBi
ZDdlYjU5ZjVmOC4uZjhiMTA2MzVkNDEgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRlcmZhY2VzL2xpYnBx
L2xpYnBxLWludC5oCisrKyBiL3NyYy9pbnRlcmZhY2VzL2xpYnBxL2xpYnBxLWludC5oCkBAIC0z
OTIsNiArMzkyLDcgQEAgc3RydWN0IHBnX2Nvbm4KIAljaGFyCSAgICpwZ3NlcnZpY2U7CQkvKiBQ
b3N0Z3JlcyBzZXJ2aWNlLCBpZiBhbnkgKi8KIAljaGFyCSAgICpwZ3NlcnZpY2VmaWxlOwkvKiBw
YXRoIHRvIGEgc2VydmljZSBmaWxlIGNvbnRhaW5pbmcKIAkJCQkJCQkJICogc2VydmljZShzKSAq
LworCWNoYXIJICAgKnBnbGRhcHNlcnZpY2V1cmw7CS8qIFBvc3RncmVzIExEQVAgc2VydmljZSBV
UkwsIGlmIGFueSAqLwogCWNoYXIJICAgKnBndXNlcjsJCQkvKiBQb3N0Z3JlcyB1c2VybmFtZSBh
bmQgcGFzc3dvcmQsIGlmIGFueSAqLwogCWNoYXIJICAgKnBncGFzczsKIAljaGFyCSAgICpwZ3Bh
c3NmaWxlOwkJLyogcGF0aCB0byBhIGZpbGUgY29udGFpbmluZyBwYXNzd29yZChzKSAqLwpkaWZm
IC0tZ2l0IGEvc3JjL3Rlc3QvbGRhcC90LzAwM19sZGFwX2Nvbm5lY3Rpb25fcGFyYW1fbG9va3Vw
LnBsIGIvc3JjL3Rlc3QvbGRhcC90LzAwM19sZGFwX2Nvbm5lY3Rpb25fcGFyYW1fbG9va3VwLnBs
CmluZGV4IDM1OWZjN2E5OThhLi5mMWM1Y2M4NWViNiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbGRh
cC90LzAwM19sZGFwX2Nvbm5lY3Rpb25fcGFyYW1fbG9va3VwLnBsCisrKyBiL3NyYy90ZXN0L2xk
YXAvdC8wMDNfbGRhcF9jb25uZWN0aW9uX3BhcmFtX2xvb2t1cC5wbApAQCAtODAsNiArODAsOSBA
QCBhcHBlbmRfdG9fZmlsZSgKIAkkc3J2ZmlsZV92YWxpZCwgcXF7CiBbbXlfc3J2XQogbGRhcDov
L2xvY2FsaG9zdDokbGRhcF9wb3J0L2RjPWV4YW1wbGUsZGM9bmV0P2Rlc2NyaXB0aW9uP29uZT8o
Y249bXlkYXRhYmFzZSkKKworW215X3Nydl8yXQorbGRhcHNlcnZpY2V1cmw9bGRhcDovL2xvY2Fs
aG9zdDokbGRhcF9wb3J0L2RjPWV4YW1wbGUsZGM9bmV0P2Rlc2NyaXB0aW9uP29uZT8oY249bXlk
YXRhYmFzZSkKIH0pOwogCiAjIEZpbGUgZGVmaW5lZCB3aXRoIG5vIGNvbnRlbnRzLCB1c2VkIGFz
IGRlZmF1bHQgdmFsdWUgZm9yCkBAIC0xOTYsNiArMTk5LDMyIEBAIGxvY2FsICRFTlZ7UEdTRVJW
SUNFRklMRX0gPSAiJHNydmZpbGVfZW1wdHkiOwogCQlleHBlY3RlZF9zdGRvdXQgPT4KIAkJICBx
ci9kZWZpbml0aW9uIG9mIHNlcnZpY2UgInVuZGVmaW5lZC1zZXJ2aWNlIiBub3QgZm91bmQvKTsK
IAorCWRlbGV0ZSAkRU5We1BHU0VSVklDRX07CisKKwkkZHVtbXlfbm9kZS0+Y29ubmVjdF9vaygK
KwkJImxkYXBzZXJ2aWNldXJsPWxkYXA6Ly9sb2NhbGhvc3Q6JGxkYXBfcG9ydC9kYz1leGFtcGxl
LGRjPW5ldD9kZXNjcmlwdGlvbj9vbmU/KGNuPW15ZGF0YWJhc2UpIiwKKwkJJ2Nvbm5lY3Rpb24g
d2l0aCBjb3JyZWN0ICJsZGFwc2VydmljZSIgc3RyaW5nJywKKwkJc3FsID0+ICJTRUxFQ1QgJ2Nv
bm5lY3QyXzQnIiwKKwkJZXhwZWN0ZWRfc3Rkb3V0ID0+IHFyL2Nvbm5lY3QyXzQvKTsKKworCSRk
dW1teV9ub2RlLT5jb25uZWN0X29rKAorCQkicG9zdGdyZXM6Ly8/bGRhcHNlcnZpY2V1cmw9bGRh
cCUzQSUyRiUyRmxvY2FsaG9zdCUzQSRsZGFwX3BvcnQlMkZkYyUzRGV4YW1wbGUlMkNkYyUzRG5l
dCUzRmRlc2NyaXB0aW9uJTNGb25lJTNGJTI4Y24lM0RteWRhdGFiYXNlJTI5IiwKKwkJJ2Nvbm5l
Y3Rpb24gd2l0aCBjb3JyZWN0ICJsZGFwc2VydmljZXVybCInLAorCQlzcWwgPT4gIlNFTEVDVCAn
Y29ubmVjdDJfNSciLAorCQlleHBlY3RlZF9zdGRvdXQgPT4gcXIvY29ubmVjdDJfNS8pOworCisJ
bG9jYWwgJEVOVntQR0xEQVBTRVJWSUNFVVJMfSA9ICJsZGFwOi8vbG9jYWxob3N0OiRsZGFwX3Bv
cnQvZGM9ZXhhbXBsZSxkYz1uZXQ/ZGVzY3JpcHRpb24/b25lPyhjbj1teWRhdGFiYXNlKSI7CisJ
JGR1bW15X25vZGUtPmNvbm5lY3Rfb2soCisJCSIiLAorCQknY29ubmVjdGlvbiB3aXRoIGNvcnJl
Y3QgImxkYXBzZXJ2aWNldXJsIiBwcm92aWRlZCBieSBlbnYgdmFyJywKKwkJc3FsID0+ICJTRUxF
Q1QgJ2Nvbm5lY3QyXzYnIiwKKwkJZXhwZWN0ZWRfc3Rkb3V0ID0+IHFyL2Nvbm5lY3QyXzYvKTsK
KwlkZWxldGUgJEVOVntQR0xEQVBTRVJWSUNFVVJMfTsKKworCSRkdW1teV9ub2RlLT5jb25uZWN0
X2ZhaWxzKAorCQknJywKKwkJJ2Nvbm5lY3Rpb24gZmFpbHMgd2l0aCBsZGFwc2VydmljZXVybCBz
cGVjaWZpZWQgaW4gcGdfc2VydmljZS5jb25mIGZpbGUnKTsKKwogCSMgUmVtb3ZlIGRlZmF1bHQg
cGdfc2VydmljZS5jb25mLgogCXVubGluaygkc3J2ZmlsZV9kZWZhdWx0KTsKIH0KLS0gCjIuNTEu
MgoK
--000000000000d71cd8064e413d1d--