MIME-Version: 1.0
From: Yamaguchi Atsuo <acrobatcoder@gmail.com>
Date: Sun, 22 Mar 2026 13:30:30 -0700
Message-ID: 
 <CAKSyusJWdWcUKVd3qJXcEaQxJewGymQWV_r3-mc=Knrqo0AZ_g@mail.gmail.com>
Subject: Add tab completion for SERVER and CONNECTION keywords in psql
To: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000e20dc9064da2cad1"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKSyusJWdWcUKVd3qJXcEaQxJewGymQWV_r3-mc%3DKnrqo0AZ_g%40mail.gmail.com>
Precedence: bulk

--000000000000e20dc9064da2cad1
Content-Type: multipart/alternative; boundary="000000000000e20dc8064da2cacf"

--000000000000e20dc8064da2cacf
Content-Type: text/plain; charset="UTF-8"

Hi,

This patch adds missing tab completion support in psql for:

- SERVER keyword after ALTER/CREATE SUBSCRIPTION <name>
- CONNECTION keyword after ALTER/CREATE FOREIGN DATA WRAPPER <name>

Currently, typing "ALTER SUBSCRIPTION sub1 SERVER" and pressing Tab
does not complete server names, even though the SERVER keyword itself
is already suggested. Similarly, CONNECTION is not suggested as a
completion candidate for FOREIGN DATA WRAPPER commands, despite being
a valid option.

The patch is generated against the current master branch.

Regards,
Atsuo Yamaguchi

--000000000000e20dc8064da2cacf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><br>This patch adds missing tab completion support =
in psql for:<br><br>- SERVER keyword after ALTER/CREATE SUBSCRIPTION &lt;na=
me&gt;<br>- CONNECTION keyword after ALTER/CREATE FOREIGN DATA WRAPPER &lt;=
name&gt;<br><br>Currently, typing &quot;ALTER SUBSCRIPTION sub1 SERVER&quot=
; and pressing Tab<br>does not complete server names, even though the SERVE=
R keyword itself<br>is already suggested. Similarly, CONNECTION is not sugg=
ested as a<br>completion candidate for FOREIGN DATA WRAPPER commands, despi=
te being<br>a valid option.<br><br>The patch is generated against the curre=
nt master branch.<br><br>Regards,<br>Atsuo Yamaguchi</div>

--000000000000e20dc8064da2cacf--

--000000000000e20dc9064da2cad1
Content-Type: application/octet-stream;
	name="0001-Add-tab-completion-for-SERVER-and-CONNECTION-keyword.patch"
Content-Disposition: attachment;
	filename="0001-Add-tab-completion-for-SERVER-and-CONNECTION-keyword.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn27n4dc0>
X-Attachment-Id: f_mn27n4dc0

RnJvbSA1NDQ3NjdkZDRhZmRkZWJjZjA1MzMzMjM3M2IxZjBjZDE1YTNhY2RmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiQXRzdW8gKEpvcmdlKSBZYW1hZ3VjaGkiIDxhY3JvYmF0Y29k
ZXJAZ21haWwuY29tPgpEYXRlOiBTdW4sIDIyIE1hciAyMDI2IDIwOjE0OjU1ICswMDAwClN1Ympl
Y3Q6IFtQQVRDSF0gQWRkIHRhYiBjb21wbGV0aW9uIGZvciBTRVJWRVIgYW5kIENPTk5FQ1RJT04g
a2V5d29yZHMgaW4gcHNxbAoKVGhlIFNFUlZFUiBrZXl3b3JkIGluIEFMVEVSL0NSRUFURSBTVUJT
Q1JJUFRJT04gYW5kIHRoZSBDT05ORUNUSU9OCmtleXdvcmQgaW4gQUxURVIvQ1JFQVRFIEZPUkVJ
R04gREFUQSBXUkFQUEVSIHdlcmUgbWlzc2luZyBmcm9tCnBzcWwncyB0YWIgY29tcGxldGlvbiBz
dXBwb3J0LiBUaGlzIHBhdGNoIGFkZHMgdGhlbS4KLS0tCiBzcmMvYmluL3BzcWwvdGFiLWNvbXBs
ZXRlLmluLmMgfCAxMCArKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCsp
LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUu
aW4uYyBiL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4uYwppbmRleCA1YmRiZjE1MzBhMi4u
NzRkYzFjOTg3Y2YgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4uYwor
KysgYi9zcmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmluLmMKQEAgLTIzNDIsNiArMjM0Miw4IEBA
IG1hdGNoX3ByZXZpb3VzX3dvcmRzKGludCBwYXR0ZXJuX2lkLAogCQlDT01QTEVURV9XSVRIKCJD
T05ORUNUSU9OIiwgIkVOQUJMRSIsICJESVNBQkxFIiwgIk9XTkVSIFRPIiwKIAkJCQkJICAiUkVO
QU1FIFRPIiwgIlJFRlJFU0ggUFVCTElDQVRJT04iLCAiUkVGUkVTSCBTRVFVRU5DRVMiLAogCQkJ
CQkgICJTRVJWRVIiLCAiU0VUIiwgIlNLSVAgKCIsICJBREQgUFVCTElDQVRJT04iLCAiRFJPUCBQ
VUJMSUNBVElPTiIpOworCWVsc2UgaWYgKE1hdGNoZXMoIkFMVEVSIiwgIlNVQlNDUklQVElPTiIs
IE1hdGNoQW55LCAiU0VSVkVSIikpCisJCUNPTVBMRVRFX1dJVEhfUVVFUlkoUXVlcnlfZm9yX2xp
c3Rfb2Zfc2VydmVycyk7CiAJLyogQUxURVIgU1VCU0NSSVBUSU9OIDxuYW1lPiBSRUZSRVNIICov
CiAJZWxzZSBpZiAoTWF0Y2hlcygiQUxURVIiLCAiU1VCU0NSSVBUSU9OIiwgTWF0Y2hBbnksIE1h
dGNoQW55TiwgIlJFRlJFU0giKSkKIAkJQ09NUExFVEVfV0lUSCgiUFVCTElDQVRJT04iLCAiU0VR
VUVOQ0VTIik7CkBAIC0yNDU5LDkgKzI0NjEsOSBAQCBtYXRjaF9wcmV2aW91c193b3JkcyhpbnQg
cGF0dGVybl9pZCwKIAkvKiBBTFRFUiBGT1JFSUdOIERBVEEgV1JBUFBFUiA8bmFtZT4gKi8KIAll
bHNlIGlmIChNYXRjaGVzKCJBTFRFUiIsICJGT1JFSUdOIiwgIkRBVEEiLCAiV1JBUFBFUiIsIE1h
dGNoQW55KSkKIAkJQ09NUExFVEVfV0lUSCgiSEFORExFUiIsICJWQUxJREFUT1IiLCAiTk8iLAot
CQkJCQkgICJPUFRJT05TIiwgIk9XTkVSIFRPIiwgIlJFTkFNRSBUTyIpOworCQkJCQkgICJPUFRJ
T05TIiwgIk9XTkVSIFRPIiwgIlJFTkFNRSBUTyIsICJDT05ORUNUSU9OIik7CiAJZWxzZSBpZiAo
TWF0Y2hlcygiQUxURVIiLCAiRk9SRUlHTiIsICJEQVRBIiwgIldSQVBQRVIiLCBNYXRjaEFueSwg
Ik5PIikpCi0JCUNPTVBMRVRFX1dJVEgoIkhBTkRMRVIiLCAiVkFMSURBVE9SIik7CisJCUNPTVBM
RVRFX1dJVEgoIkhBTkRMRVIiLCAiVkFMSURBVE9SIiwgIkNPTk5FQ1RJT04iKTsKIAogCS8qIEFM
VEVSIEZPUkVJR04gVEFCTEUgPG5hbWU+ICovCiAJZWxzZSBpZiAoTWF0Y2hlcygiQUxURVIiLCAi
Rk9SRUlHTiIsICJUQUJMRSIsIE1hdGNoQW55KSkKQEAgLTM1NDgsNyArMzU1MCw3IEBAIG1hdGNo
X3ByZXZpb3VzX3dvcmRzKGludCBwYXR0ZXJuX2lkLAogCiAJLyogQ1JFQVRFIEZPUkVJR04gREFU
QSBXUkFQUEVSICovCiAJZWxzZSBpZiAoTWF0Y2hlcygiQ1JFQVRFIiwgIkZPUkVJR04iLCAiREFU
QSIsICJXUkFQUEVSIiwgTWF0Y2hBbnkpKQotCQlDT01QTEVURV9XSVRIKCJIQU5ETEVSIiwgIlZB
TElEQVRPUiIsICJPUFRJT05TIik7CisJCUNPTVBMRVRFX1dJVEgoIkhBTkRMRVIiLCAiVkFMSURB
VE9SIiwgIk9QVElPTlMiLCAiQ09OTkVDVElPTiIpOwogCiAJLyogQ1JFQVRFIEZPUkVJR04gVEFC
TEUgKi8KIAllbHNlIGlmIChNYXRjaGVzKCJDUkVBVEUiLCAiRk9SRUlHTiIsICJUQUJMRSIsIE1h
dGNoQW55KSkKQEAgLTM5MTUsNiArMzkxNyw4IEBAIG1hdGNoX3ByZXZpb3VzX3dvcmRzKGludCBw
YXR0ZXJuX2lkLAogLyogQ1JFQVRFIFNVQlNDUklQVElPTiAqLwogCWVsc2UgaWYgKE1hdGNoZXMo
IkNSRUFURSIsICJTVUJTQ1JJUFRJT04iLCBNYXRjaEFueSkpCiAJCUNPTVBMRVRFX1dJVEgoIlNF
UlZFUiIsICJDT05ORUNUSU9OIik7CisJZWxzZSBpZiAoTWF0Y2hlcygiQ1JFQVRFIiwgIlNVQlND
UklQVElPTiIsIE1hdGNoQW55LCAiU0VSVkVSIikpCisJCUNPTVBMRVRFX1dJVEhfUVVFUlkoUXVl
cnlfZm9yX2xpc3Rfb2Zfc2VydmVycyk7CiAJZWxzZSBpZiAoTWF0Y2hlcygiQ1JFQVRFIiwgIlNV
QlNDUklQVElPTiIsIE1hdGNoQW55LCAiU0VSVkVSIiwgTWF0Y2hBbnkpKQogCQlDT01QTEVURV9X
SVRIKCJQVUJMSUNBVElPTiIpOwogCWVsc2UgaWYgKE1hdGNoZXMoIkNSRUFURSIsICJTVUJTQ1JJ
UFRJT04iLCBNYXRjaEFueSwgIkNPTk5FQ1RJT04iLCBNYXRjaEFueSkpCi0tIAoyLjQ3LjMKCg==
--000000000000e20dc9064da2cad1--