MIME-Version: 1.0
References: <CAKU4AWoqAVya6PBhn+BCbFaBMt3z-2=i5fKO3bW=6HPhbid2Dw@mail.gmail.com>
 <CACJufxHASOEpngQ8V2tbXgs4VZC3ETrVbS=uk0KC_B_J1j7ejQ@mail.gmail.com>
 <CAKU4AWrap1zpYqunJwWTN=CdP7E8e0U4mYmwn7hvTW3ERuENVg@mail.gmail.com>
 <CAFj8pRD-R-GsGCjeYApbhZoiW8TV6zACaYStMBMM0=--+WgN_A@mail.gmail.com>
 <CAKU4AWpDdFXAD+dMC1HeErXSKBUUBRGWkf=dAcX3wZgBNsWM=g@mail.gmail.com>
 <CAFj8pRAO3oEiBaJJ9=HZp6CoP2ffbwSgrKkLKjPfYZwx9wOOuQ@mail.gmail.com>
 <CAKU4AWoCHpKAVuQeOrk44cVPy_dVxn1aHrMUvHy5Ag-daFCSsQ@mail.gmail.com>
 <CAFj8pRD4cdUmK0RG4oN5B2KRSeDhwfMYaL=XpfEu4iaLeZ_Kow@mail.gmail.com>
 <CAKU4AWp8ab61e96v57OaB-Gm1bMfBNVLVy+s17U6_Ne3veB84g@mail.gmail.com>
 <3507485.1691090027@sss.pgh.pa.us> <CAKU4AWp+KLes8g=BWLqZfDmW9+=ZY0UC4G0i3qVcYEviK_dDTA@mail.gmail.com>
 <900892914fdc3f477b101d699efb40e0@anastigmatix.net> <903341.1692022214@sss.pgh.pa.us>
 <CAKU4AWrBY9GHj9oZbvhiOG1BgiWyZC8FGPAET-CfRKDhYyv1HQ@mail.gmail.com>
 <CAKU4AWrGM5bK7wi4Y8bTYhKgh=A1fW=X00eC_jfk6_JXyaEURQ@mail.gmail.com>
 <CAFj8pRC+4pvSuibB2xcNKJ=6PSF=TAcOtRNpdLPBXZjijFg7ag@mail.gmail.com>
 <CAKU4AWrxHFVZM-gGPpOrVPreZMePAOoY580Tq-+CvxDWHmP_uA@mail.gmail.com>
 <CAKU4AWp3410VpYFdCxpFdaHc8he6zj_=Fvww53TnU+g-bvvvsQ@mail.gmail.com>
 <CACJufxH7ftu9HD+h_gDWPDvq1ZO8vGm81JomSKjvQacCLMLcxg@mail.gmail.com>
 <CAKU4AWqbd_oDwXyK7=yMKbhAR=CQtVOWszcgft+cTG6JCTKmzQ@mail.gmail.com>
 <4b97f1a1dd9b6e45443d24870d3be698@anastigmatix.net> <CAKU4AWr1bsGaWWzQHJwB=WXboJrCM242=x6XbHO06vuhWsY4Ww@mail.gmail.com>
 <b2b630ff9804f9eae8205ad721fd0682@anastigmatix.net> <CAKU4AWoLgC5ejOF8jxskd5oq52D-eR_1Q-HM5+e8OBVLak=qTg@mail.gmail.com>
 <111272f2dc112c7becdd35ad89f6b935@anastigmatix.net> <a872cdd08b79a7f507c392542bdd4cd4@anastigmatix.net>
 <CAKU4AWpnFXYXtfOQp_QdQ7RwCD-d+qzyZKdNygc+9DY8bveVYQ@mail.gmail.com>
 <5138c6b5fd239e7ce4e1a4e63826ac27@anastigmatix.net> <CAKU4AWrysndLra+SZLsODZF-bet1JnPMLU9HsiFH75ZnSPK2zw@mail.gmail.com>
 <CAKU4AWrs4Pzajm2_tgtUTf=CWfDJEx=3h45Lhqg7tNOVZw5YxA@mail.gmail.com>
 <CAKU4AWryj3pFG87mfQGS-K6XGOiyeYsMLOgajZ337NRV1F6Wfw@mail.gmail.com>
 <369543439e988ae43f0a6307500b27c4@anastigmatix.net> <5955e93347a7e3b1612cf7e129ae6d04@anastigmatix.net>
 <CAKU4AWrxBXomhGcubsLqBj4FRbOf1AEXqpwBsm-mGJEJ0G_ypA@mail.gmail.com>
 <f6185e3b75c85794e312e46fe6a74837@anastigmatix.net> <CAKU4AWpM=C5NxumoHQB1=id0OBc63kUgMUWyRNO2=OrHj6ROyQ@mail.gmail.com>
 <CAKU4AWrYOYSXMmotwhqiErci7aMz--8LxfpLiSg+0+7XNJBcuA@mail.gmail.com>
 <CACJufxHdDkdR13nkhxybOUDKSB9kgsDhZU8xiGg1t_rVP-==nA@mail.gmail.com>
 <CAKU4AWqQjMREZpOOECC6duV-VbEYYAdP6EL+VaK=-X7q-JQjFw@mail.gmail.com>
 <CAKU4AWoXjErs4FXTqCcvr_gobx4sjPmWyyTDiN3qUDNjrYO8Xg@mail.gmail.com>
 <43a988594ac91a63dc4bb49a94303a42@anastigmatix.net> <CAKU4AWqQ8QQ=QABALQMAUaAkT3BaReujJgPm3QOqDHxk_=abnA@mail.gmail.com>
 <CAKU4AWrGci1GyJ-WhwwT05+6hEWYuH_jFc8Vc=oNp0OzKCEDDg@mail.gmail.com>
In-Reply-To: <CAKU4AWrGci1GyJ-WhwwT05+6hEWYuH_jFc8Vc=oNp0OzKCEDDg@mail.gmail.com>
From: Andy Fan <zhihui.fan1213@gmail.com>
Date: Thu, 5 Oct 2023 14:53:05 +0800
Message-ID: <CAKU4AWo4es1awVNbjLZkEpYCkgjxhkszbHiMF0UTsjx62K5RQg@mail.gmail.com>
Subject: Re: Extract numeric filed in JSONB more effectively
To: Chapman Flack <chap@anastigmatix.net>
Cc: jian he <jian.universality@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, 
	Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000015b3440606f29454"
Archived-At: <https://www.postgresql.org/message-id/CAKU4AWo4es1awVNbjLZkEpYCkgjxhkszbHiMF0UTsjx62K5RQg%40mail.gmail.com>
Precedence: bulk

--00000000000015b3440606f29454
Content-Type: text/plain; charset="UTF-8"

Hi,

I am feeling this topic has been well discussed and the only pending
issues are below,  it would be great that any committer can have a
look at these,  so I mark this entry as "Ready for Committer".

Things are not addressed yet:
> 1.  the error message handling.
>

You can check [1] for more background of this,  I think blocking this
feature at an error message level is not pretty reasonable.


> 2.  if we have chances to optimize _tz functions, I guess no.
>

patch 002 is dedicated  for this,  I think it should not be committed,
the reason is described in the commit message.

3.  function naming issue. I think I can get it modified once after
> all the other issues are addressed.
>
>
[1]
https://www.postgresql.org/message-id/d70280648894e56f9f0d12c75090c3d8%40anastigmatix.net


-- 
Best Regards
Andy Fan

--00000000000015b3440606f29454
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div>Hi,<br></div><div><br></di=
v><div>I am feeling this topic has been well discussed=C2=A0and the only pe=
nding=C2=A0</div><div>issues are below,=C2=A0 it would be great that any co=
mmitter can have a=C2=A0</div><div>look at these,=C2=A0 so I mark this entr=
y as &quot;Ready for Committer&quot;.=C2=A0</div><div><br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px so=
lid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div></div><div>Thi=
ngs are not addressed yet:</div><div>1.=C2=A0 the error message handling.=
=C2=A0</div></div></blockquote><div><br></div><div>You can check [1] for mo=
re background of this,=C2=A0 I think blocking this</div><div>feature at an =
error message level is not pretty reasonable.=C2=A0</div><div>=C2=A0</div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>2.=
=C2=A0 if we have chances to optimize _tz functions, I guess no.</div></div=
></blockquote><div>=C2=A0</div><div>patch 002 is dedicated=C2=A0 for this,=
=C2=A0 I think it should not be committed,</div><div>the reason is describe=
d in the commit message.</div><div><br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex"><div dir=3D"ltr"><div>3.=C2=A0 function naming issue. I=
 think I can get it modified once after</div><div>all the other issues are =
addressed.=C2=A0</div><div><div><br></div></div></div></blockquote><div><br=
></div><div>[1]=C2=A0<a href=3D"https://www.postgresql.org/message-id/d7028=
0648894e56f9f0d12c75090c3d8%40anastigmatix.net">https://www.postgresql.org/=
message-id/d70280648894e56f9f0d12c75090c3d8%40anastigmatix.net</a>=C2=A0</d=
iv><div>=C2=A0</div></div><span class=3D"gmail_signature_prefix">-- </span>=
<br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Best Regard=
s<div>Andy Fan</div></div></div></div>

--00000000000015b3440606f29454--