MIME-Version: 1.0
References: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
 <202501110844.5ztsym4vbflm@alvherre.pgsql>
In-Reply-To: <202501110844.5ztsym4vbflm@alvherre.pgsql>
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Sat, 11 Jan 2025 20:08:12 +0530
Message-ID: <CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Guillaume Lelarge <guillaume@lelarge.info>, Nathan Bossart <nathandbossart@gmail.com>, 
	Magnus Hagander <magnus@hagander.net>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Andrew Dunstan <andrew@dunslane.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>, 
	Dilip Kumar <dilipbalaut@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000d3af4b062b6f29b8"
Archived-At: <https://www.postgresql.org/message-id/CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg%40mail.gmail.com>
Precedence: bulk

--000000000000d3af4b062b6f29b8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks Alvaro for quick feedback.

On Sat, 11 Jan 2025 at 2:14=E2=80=AFPM, Alvaro Herrera <alvherre@alvh.no-ip=
.org>
wrote:

> Hmm, this patch adds a function connectDatabase() to pg_restore, but a
> function that's almost identical already exists in pg_dumpall.


Yes, you are right. Both functions are same as I copied this function from
pg_dumpall.c.


> suggest they should be unified.  Maybe create a new file for connection
> management routines? (since this clearly doesn't fit common.c nor
> dumputils.c).


Sure. I will create a new file and I will move these common functions into
that.

Thanks and regards
Mahendra Singh Thalor
https://www.EnterpriseDB.com/


>
>
> --
> =C3=81lvaro Herrera               48=C2=B001'N 7=C2=B057'E  =E2=80=94
> https://www.EnterpriseDB.com/
> "In Europe they call me Niklaus Wirth; in the US they call me Nickel's
> worth.
>  That's because in Europe they call me by name, and in the US by value!"
>

--000000000000d3af4b062b6f29b8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Thanks Alvaro for quick feedback.</div><div dir=3D"auto">=
<br></div><div><div class=3D"gmail_quote gmail_quote_container"><div dir=3D=
"ltr" class=3D"gmail_attr">On Sat, 11 Jan 2025 at 2:14=E2=80=AFPM, Alvaro H=
errera &lt;<a href=3D"mailto:alvherre@alvh.no-ip.org">alvherre@alvh.no-ip.o=
rg</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" dir=3D"auto">Hmm,=
 this patch adds a function connectDatabase() to pg_restore, but a<br>
function that&#39;s almost identical already exists in pg_dumpall. =C2=A0</=
blockquote><div dir=3D"auto"><br></div><div dir=3D"auto">Yes, you are right=
. Both functions are same as I copied this function from pg_dumpall.c.</div=
><div dir=3D"auto"><br></div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" dir=3D"auto"><b=
r>
suggest they should be unified.=C2=A0 Maybe create a new file for connectio=
n<br>
management routines? (since this clearly doesn&#39;t fit common.c nor<br>
dumputils.c).</blockquote><div dir=3D"auto"><br></div><div dir=3D"auto">Sur=
e. I will create a new file and I will move these common functions into tha=
t.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Thanks and=C2=A0regar=
ds</div><div dir=3D"auto">Mahendra Singh Thalor</div><div dir=3D"auto"><div=
><a href=3D"https://www.EnterpriseDB.com/">https://www.EnterpriseDB.com/</a=
></div><br></div><div dir=3D"auto">=C2=A0</div><blockquote class=3D"gmail_q=
uote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1e=
x" dir=3D"auto"><br>
<br>
-- <br>
=C3=81lvaro Herrera=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A04=
8=C2=B001&#39;N 7=C2=B057&#39;E=C2=A0 =E2=80=94=C2=A0 <a href=3D"https://ww=
w.EnterpriseDB.com/" rel=3D"noreferrer" target=3D"_blank">https://www.Enter=
priseDB.com/</a><br>
&quot;In Europe they call me Niklaus Wirth; in the US they call me Nickel&#=
39;s worth.<br>
=C2=A0That&#39;s because in Europe they call me by name, and in the US by v=
alue!&quot;<br>
</blockquote></div></div>

--000000000000d3af4b062b6f29b8--