MIME-Version: 1.0
References: 
 <CAKYtNAqN49Hqd4v0wWH3uW6d6QsH+8e8bR_MVf4CboTZSzd+Aw@mail.gmail.com>
 <599d493e-01f7-4f74-bcc7-242b1dd1e025@dunslane.net>
In-Reply-To: <599d493e-01f7-4f74-bcc7-242b1dd1e025@dunslane.net>
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Sun, 15 Mar 2026 23:03:34 +0530
Message-ID: 
 <CAKYtNAoVD2FYpnGYMLiQ3+Br4XZwCyStxxQgx8FWW4OSWBeZDg@mail.gmail.com>
Subject: Re: pg_restore: remove unnecessary code from restore_all_databases
 function
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKYtNAoVD2FYpnGYMLiQ3%2BBr4XZwCyStxxQgx8FWW4OSWBeZDg%40mail.gmail.com>
Precedence: bulk

On Sun, 15 Mar 2026 at 21:46, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2026-03-14 Sa 11:48 PM, Mahendra Singh Thalor wrote:
> > Hi hackers,
> >
> > +++ b/src/bin/pg_dump/pg_restore.c
> > @@ -1268,16 +1268,6 @@ restore_all_databases(const char *inputFileSpec,
> >                  */
> >                 memcpy(tmpopts, original_opts, sizeof(RestoreOptions));
> >
> > -               /*
> > -                * We need to reset override_dbname so that objects
> > can be restored
> > -                * into an already created database. (used with
> > -d/--dbname option)
> > -                */
> > -               if (tmpopts->cparams.override_dbname)
> > -               {
> > - pfree(tmpopts->cparams.override_dbname);
> > -                       tmpopts->cparams.override_dbname = NULL;
> > -               }
> > -
> >
> > In commit 77152d26efefde2eed4, we added some functions and we missed
> > to remove some unnecessary lines. Those lines are not needed as we are
> > using memcpy to get the original copy before these lines.
> >
> > Here, I am attaching a patch to fix this. Please review it.
>
>
> Thanks. Pushed.
>
>
> cheers
>
>
> andrew
>
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>

Thanks Andrew for committing this.

-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com