Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tWj4b-001B6t-65 for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Jan 2025 21:31:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tWj4Z-00CguT-Tz for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Jan 2025 21:31:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tWj4Z-00CguL-FI for pgsql-hackers@lists.postgresql.org; Sat, 11 Jan 2025 21:31:11 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tWj4T-00188t-2a for pgsql-hackers@postgresql.org; Sat, 11 Jan 2025 21:31:10 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-436637e8c8dso33618955e9.1 for ; Sat, 11 Jan 2025 13:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736631065; x=1737235865; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RqvaO4gdg5C6n3AHdxp/xt2OvQjV+wmQTBLfOTZRb0o=; b=K0t0991FdAX63xXTqbeRUyqrMtMWG2zDJkD5WUTcypL5H7Fb4EGqe/sX0V4PTvqnqT i9RJajLuevPtTI/1cdCx0lwmLfmxwsUvwXUjyujlUytR4YmdO/I9C18qS6w5pVouSqxW 68y7wmfomxUlbhemqC4H9H5nFqDHvEkCArrOJF0JHRuqnhs48V19ye9iU1MHKRAozaRd ia8aONH/vDZb4Dv6ZPL/SdO1Cgglb92gP4ltv+FbLWS+Y2/lF/N5Yk9hSLQSp7ebyOMq mpduzG1k28ZRgCfyXsY5f7YaCTnwIVKEtinhhZpHUQ9WKcb4X32PIKVumwXvhQVc0B1U HPsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736631065; x=1737235865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RqvaO4gdg5C6n3AHdxp/xt2OvQjV+wmQTBLfOTZRb0o=; b=pXVR7Aa953ax3j0POgvnvTQ05IKPgmX85NmV4SnZ2RDyqur3vV76lFzi9JfQdFNvJT GISOd6pUof0aLV6PfvNQPq4TZVmvuJllO6R3an4WkrboCJxopRaUIvLKiFwysO2VFxQW XFaVa5/dKcmxLxeg7hkotiabcSNV+1KGQMj2mX4GAvpZwYJgaYTKL0wUS1aOp2TKZY5o PImWZ3geoj1M6n9jC3hatXVEKuVVzECk5VtKlMZi3m6XG1RibCfYxPkViM9fJuGeb27X jtFNeUYPTMdEm+6ECZYQFSgm/3+d1F+4gr5r6PhnRiFQVuck2rXmtDxe4n0aNxj53Dr/ vpXA== X-Forwarded-Encrypted: i=1; AJvYcCUGrn9QTa3aGU721WaRaTn0dC7u2W+BKU0ZPwOwYZhM4KyDFo94Da33wWhj5SwMz8cDEJHcxUK674X/L264@postgresql.org X-Gm-Message-State: AOJu0Yw1QLuCw2k+/Kygvd5+CBo075kRCQardELyx7Ch3XsMoLJZEtS6 OGuM9SaJZaiZGQC2rxNYQWPCER+uLx37ku6cCoemsnGsuq9Lpmte/H+KrDVMopBoAKTwX7DlQ0E /cVSNPmIkMdq4esQtBbPRpSQtxBk= X-Gm-Gg: ASbGncv2NDn/4fbwDTf0Ds90vROAfRRs5xiq73bNdqZIHhwi/Co88Ij3myQXsX0GwOM QOQXq4CdSBtiwjOwe8hv2GlgOWzRwL+rO72Ra99G4 X-Google-Smtp-Source: AGHT+IHCnZJZn7PEIlVbKpt7/GZ6TuX7ifkpOhI2nLN/GuBP7hg1e6W/+IaEShIrrp5INIL6KWljzjDkcIz4abxriJc= X-Received: by 2002:a05:600c:4586:b0:434:edcf:7461 with SMTP id 5b1f17b1804b1-436e26f135bmr155444045e9.30.1736631064685; Sat, 11 Jan 2025 13:31:04 -0800 (PST) MIME-Version: 1.0 References: <202501110844.5ztsym4vbflm@alvherre.pgsql> In-Reply-To: From: Mahendra Singh Thalor Date: Sun, 12 Jan 2025 03:00:52 +0530 X-Gm-Features: AbW1kvYW3Ww0C0V_qp2sQma-130AcrPihEATgBU1wA-5X6SFWXfrIyRaQMW9mAg Message-ID: Subject: Re: Non-text mode for pg_dumpall To: jian he Cc: Alvaro Herrera , Guillaume Lelarge , Nathan Bossart , Magnus Hagander , Tom Lane , Andrew Dunstan , PostgreSQL-development , Dilip Kumar Content-Type: multipart/mixed; boundary="000000000000b78f27062b74ed95" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000b78f27062b74ed95 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Alvaro and Jian for the review. > > otherwise if the cluster is not setting up. > ``pg_dumpall --format=3Dd`` > error would be about connection error, not > "pg_dumpall: error: no output directory specified" > > we want ``pg_dumpall --format`` invalid options > to error out even if the cluster is not setting up. Fixed. Apart from this, added handling to support empty directory also with --file option. > > you also need change > > > > > > Send output to the specified file. If this is omitted, the > standard output is used. > > > > ? > > since if --format=3Dd, >