Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tpdJ3-009Ks9-VZ for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Mar 2025 01:12:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tpdJ2-00Dn14-GJ for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Mar 2025 01:12:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tpdJ2-00Dn0v-6A for pgsql-hackers@lists.postgresql.org; Wed, 05 Mar 2025 01:12:16 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tpdJ0-0010kO-0J for pgsql-hackers@lists.postgresql.org; Wed, 05 Mar 2025 01:12:15 +0000 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-46fcbb96ba9so77624561cf.0 for ; Tue, 04 Mar 2025 17:12:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741137133; x=1741741933; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Vl1z5euOfJK4yUQAp9hYj0FRv1TvVdCSvrX4O5Hp2w0=; b=EHavVoh1/FsFoGyyI6Onbtx6PGFTyCE6m24pNp+1zWWOYMKjfR126x0QfhTVK/yCi8 iBlBk3y0OSQwqrM6gjD03ssxIBgTeREdpk8kVUDQIzBhXH+UVjZ2OLjit3eU3CgDS+mp 3gDP7SvJg8+/5vml0OQSH2EwfpUQujQO/KK7DmS1ta5RB0jl9potl9eqmRH7j0cmil3y 34ttG9uFwZ+fY6E2AnrFfFdgWVXjZKB80NL8MAXlZsILmM4Iw1I9baKl2KGWTw4DlwbP ZDAVRWeJq1K07AF6sPR797vmNn6fGsV6uswIlmUkstnemHpWY4dPqXpDxS+9Tb1wWAcZ CcgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741137133; x=1741741933; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vl1z5euOfJK4yUQAp9hYj0FRv1TvVdCSvrX4O5Hp2w0=; b=ZBVvaRbCUX3cb+KdCRUhwPIqW6IoJPu+v+SONot91h8uFaQ7D3eXDgA7MpmDoP5po6 z5ND2lCHXfH2aD9DC7t4/LG8cRMutEGSlDPK+YEM5no5iH9/avw0W1He2r6G4DESTePQ 6qp4VP7vopR/yu9EbsOHTRvavJxFHI/8xhXvE6X1GrYtl1ER3I5dooB3NYMNJsJPVtve WrCr0TFrqyiOITNmJSUx5NXbVQI8GmdctWD9YIEjM+CFd7lIwXvGzfTRoyZ7WGjbSOjV AxJU7mejB6PuQznuQsPXU3v0H72IJO7aqBwcarCnVV73iHN1+sMQsqWDWZszUDwMFxF7 qIMg== X-Forwarded-Encrypted: i=1; AJvYcCXquPe794PGGnxNOyNdQXGlZhZ4I4YQfVxTyOLLUFPs5JiyeZRvUGYeWtEFCbn1QGksIJ6FBEsTWiYVgJsp@lists.postgresql.org X-Gm-Message-State: AOJu0Ywou6HAYL2T+r3BWX/LntLvZkOaYCE/0UujgQ0IAEtlyfsf0RS8 hQtQc5JHs2s0k3xaZAhHk+GyEcRBekuM7JPmi1wc36rPMUKerpW4lyD1CUq8B1tOD9snpJWhIM7 8sTtE9LZ1xlfBoE2aAHjUEmzGyjc= X-Gm-Gg: ASbGncuk0YpduoJaBAP1y7FUViuvuaKY0EZ+NkfMQP2+L/R/bxinw40Pr7Zy4SVDngV 1hyphb3JDnmZMf9VBm5JJ6Axh1uWUh5R8TzXjxosaxFlNOPsUjuopRV/V6ehWDVY14vy2ZXzTk6 OTvc0XMWpJcLVsZwO4NU+lTEDhVxlR+Lv3x71j4GfltfRbYRcT0RI/wmqIhmo= X-Google-Smtp-Source: AGHT+IG2DCti5XWByJhWW9Cu1MQal0sLKmeuQfrnrxUDsv0tM5eOK45NCiPA4c+bYK1bEheM5iu6uo9VRMQ3eNiNPMQ= X-Received: by 2002:ac8:5ad5:0:b0:472:8fd:90ec with SMTP id d75a77b69052e-4750b4e7cf2mr15823641cf.44.1741137133179; Tue, 04 Mar 2025 17:12:13 -0800 (PST) MIME-Version: 1.0 References: <202503041932.2325wnk2zipe@alvherre.pgsql> In-Reply-To: <202503041932.2325wnk2zipe@alvherre.pgsql> From: Mahendra Singh Thalor Date: Wed, 5 Mar 2025 06:42:02 +0530 X-Gm-Features: AQ5f1JqX4LoNahLkKTuiDZstYOa9LTgO4p8akUsFbXoUFC7orYEWNePitR-bJfQ Message-ID: Subject: Re: Non-text mode for pg_dumpall To: =?UTF-8?Q?=C3=81lvaro_Herrera?= Cc: jian he , Srinath Reddy , pgsql-hackers@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000541ad8062f8e1484" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000541ad8062f8e1484 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 5 Mar 2025 at 01:02, =C3=81lvaro Herrera = wrote: > > A database name containing a newline breaks things for this patch: > > CREATE DATABASE "foo > bar"; > > > $ pg_dumpall -Fc --file test > shell command argument contains a newline or carriage return: " dbname=3D'foo > bar'" > > -- > =C3=81lvaro Herrera 48=C2=B001'N 7=C2=B057'E =E2=80=94 https://www.EnterpriseDB.com/ Hi Alvaro, I also reported this issue on 29-01-2025. This breaks even without this patch also. error with pg_dumpall when db name have new line in double quote --=20 Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com --000000000000541ad8062f8e1484 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, 5 Mar 2025 = at 01:02, =C3=81lvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> = A database name containing a newline breaks things for this patch:
><= br>> CREATE DATABASE "foo
> bar";
>
>
>= ; $ pg_dumpall -Fc --file test
> shell command argument contains a ne= wline or carriage return: " dbname=3D'foo
> bar'">
> --
> =C3=81lvaro Herrera =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 48=C2=B001'N 7=C2=B057'E =C2=A0=E2=80=94 =C2= =A0https://www.= EnterpriseDB.com/

Hi Alvaro,I also reported this issue on 29-01-2025. This breaks even without=C2=A0= this patch also.




--
Thanks and Regards
= Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
--000000000000541ad8062f8e1484--