MIME-Version: 1.0
References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <CAC6VRoZbP=-=a+a78RoWcs2L4=4VEDZqJMg+7SyUAcSHATyDAQ@mail.gmail.com>
 <CAC6VRoY-1WC_O5UDwKzNc18LXLwjuTFb+qMNY3gaF3cCov6M6g@mail.gmail.com>
 <CAKYtNArc3j8Akb+nB1QyJLKic7ej7vKZqKnv_mbB+iQAJRzLnA@mail.gmail.com>
 <CAC6VRoat6NPcS6vfGrPrwaQB3G1JHLSqDeAkf1AJ7npWrwhnUQ@mail.gmail.com>
 <CAKYtNAp=TFEZWQbTRZso3kNaD9BH=-JPNQ30mT60cJN_04hEog@mail.gmail.com>
 <4022765f-38ee-48a3-b246-615b3f8e1c23@dunslane.net>
 <CAKYtNAq73_UeL4-0wgu9rawctHdS2zhpzWtqVuOChCS3M+2Ymg@mail.gmail.com>
 <CACJufxFs9NXXTeb78i2MD+pnZootayAtiGcNHNeU35SmQgMjbA@mail.gmail.com>
 <59d3616f-6d6d-40d5-87e2-e019e350b52d@dunslane.net>
 <CACJufxEnmJ8otfmN7Kp110Wqi=M4YE0-zn-W6SK+eTpWuZw_fg@mail.gmail.com>
 <CAKYtNAqxjQMLVPfz6XESqszhxZKgigi7UEBzBhz_Wj_Bnasdag@mail.gmail.com>
 <7faf3a59-cfe1-45cb-a972-55e05560b414@dunslane.net>
 <CACJufxE-zJiBAaZABtJBJr8FZdj=xP5adf_excmu9S6Op=KpLA@mail.gmail.com>
 <2e7ada75-422c-4153-9437-ea0ce8d63521@dunslane.net>
 <016819c0-666e-42a8-bfc8-2b93fd8d0176@eisentraut.org>
In-Reply-To: <016819c0-666e-42a8-bfc8-2b93fd8d0176@eisentraut.org>
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Tue, 3 Mar 2026 16:47:52 +0530
Message-ID: 
 <CAKYtNAp+SBSVENOtvEqpAcZCeQZhNZFU005Jy5-eP+2kC-3ryA@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Andrew Dunstan <andrew@dunslane.net>,
 jian he <jian.universality@gmail.com>,
	tushar <tushar.ahuja@enterprisedb.com>,
	Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="00000000000072fd79064c1cdbc9"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKYtNAp%2BSBSVENOtvEqpAcZCeQZhNZFU005Jy5-eP%2B2kC-3ryA%40mail.gmail.com>
Precedence: bulk

--00000000000072fd79064c1cdbc9
Content-Type: text/plain; charset="UTF-8"

On Tue, 3 Mar 2026 at 14:55, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> I noticed this cast in the committed code:
>
> > + num_total_db = get_dbname_oid_list_from_mfile((char *) inputFileSpec,
> > &dbname_oid_list);
>
> The cast drops the const qualifier from inputFileSpec.
> get_dbname_oid_list_from_mfile() writes into the space pointed to by its
> argument, so it's really not "const".  (And inputFileSpec points into
> argv, so this ends up writing directly into argv.)
>
> Please see if you can clean this up.  It might be best if
> get_dbname_oid_list_from_mfile() made a copy of its argument that it can
> write into, and then the argument can be "const".
>

Thanks Peter.

Here, I am attaching a patch to fix this issue.

-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

--00000000000072fd79064c1cdbc9
Content-Type: text/x-patch; charset="US-ASCII";
	name="v01_pg_restore-don-t-edit-inputfile-name-instead-use-local.patch"
Content-Disposition: attachment;
	filename="v01_pg_restore-don-t-edit-inputfile-name-instead-use-local.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmaike0i0>
X-Attachment-Id: f_mmaike0i0

RnJvbSBjYjc0NGM0ODFmZjA0NWE5NWYxMWQyYTAyMTdhYmE5MjhlZGUyMmRiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYWhlbmRyYSBTaW5naCBUaGFsb3IgPG1haGk2cnVuQGdtYWls
LmNvbT4KRGF0ZTogVHVlLCAzIE1hciAyMDI2IDE2OjQzOjMzICswNTMwClN1YmplY3Q6IFtQQVRD
SF0gcGdfcmVzdG9yZTogZG9uJ3QgZWRpdCBpbnB1dGZpbGUgbmFtZSwgaW5zdGVhZCB1c2UgbG9j
YWwgY29weQoKSW4gZ2V0X2RibmFtZV9vaWRfbGlzdF9mcm9tX21maWxlLCB3ZSBhcmUgZWRpdGlu
ZyBmaWxlbmFtZSBieSBwYXNzaW5nIGlzCmNoYXIgKiwgaW5zdGVhZCBvZiBjb25zdCBjaGFyKi4g
Rml4ZWQgdGhpcyBieSBhZGRpbmcgbG9jYWwgY29weS4KLS0tCiBzcmMvYmluL3BnX2R1bXAvcGdf
cmVzdG9yZS5jIHwgMTAgKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygr
KSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9y
ZS5jIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYwppbmRleCAxNGQ4ODZmYzg2ZS4uNTRj
OGI5ZDQ4YjAgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMKKysrIGIv
c3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYwpAQCAtNjgsNyArNjgsNyBAQCBzdGF0aWMgaW50
CXJlc3RvcmVfYWxsX2RhdGFiYXNlcyhjb25zdCBjaGFyICppbnB1dEZpbGVTcGVjLAogc3RhdGlj
IGludAlnZXRfZGJuYW1lc19saXN0X3RvX3Jlc3RvcmUoUEdjb25uICpjb25uLAogCQkJCQkJCQkJ
CVNpbXBsZVB0ckxpc3QgKmRibmFtZV9vaWRfbGlzdCwKIAkJCQkJCQkJCQlTaW1wbGVTdHJpbmdM
aXN0IGRiX2V4Y2x1ZGVfcGF0dGVybnMpOwotc3RhdGljIGludAlnZXRfZGJuYW1lX29pZF9saXN0
X2Zyb21fbWZpbGUoY2hhciAqZHVtcGRpcnBhdGgsCitzdGF0aWMgaW50CWdldF9kYm5hbWVfb2lk
X2xpc3RfZnJvbV9tZmlsZShjb25zdCBjaGFyICpkdW1wZGlycGF0aGFyZywKIAkJCQkJCQkJCQkg
ICBTaW1wbGVQdHJMaXN0ICpkYm5hbWVfb2lkX2xpc3QpOwogCiAvKgpAQCAtMTA4MiwxNCArMTA4
MiwxOCBAQCBnZXRfZGJuYW1lc19saXN0X3RvX3Jlc3RvcmUoUEdjb25uICpjb25uLAogICogUmV0
dXJucywgdG90YWwgbnVtYmVyIG9mIGRhdGFiYXNlIG5hbWVzIGluIG1hcC5kYXQgZmlsZS4KICAq
Lwogc3RhdGljIGludAotZ2V0X2RibmFtZV9vaWRfbGlzdF9mcm9tX21maWxlKGNoYXIgKmR1bXBk
aXJwYXRoLCBTaW1wbGVQdHJMaXN0ICpkYm5hbWVfb2lkX2xpc3QpCitnZXRfZGJuYW1lX29pZF9s
aXN0X2Zyb21fbWZpbGUoY29uc3QgY2hhciAqZHVtcGRpcnBhdGhhcmcsIFNpbXBsZVB0ckxpc3Qg
KmRibmFtZV9vaWRfbGlzdCkKIHsKIAlTdHJpbmdJbmZvRGF0YSBsaW5lYnVmOwogCUZJTEUJICAg
KnBmaWxlOwogCWNoYXIJCW1hcF9maWxlX3BhdGhbTUFYUEdQQVRIXTsKIAlpbnQJCQljb3VudCA9
IDA7CiAJaW50CQkJbGVuOworCWNoYXIJCQkqZHVtcGRpcnBhdGg7CiAKKwlsZW4gPSBzdHJsZW4o
ZHVtcGRpcnBhdGhhcmcpOworCWR1bXBkaXJwYXRoID0gcGdfbWFsbG9jMChsZW4gKyAxKTsKKwlt
ZW1jcHkoZHVtcGRpcnBhdGgsIGR1bXBkaXJwYXRoYXJnLCBsZW4pOwogCiAJLyoKIAkgKiBJZiB0
aGVyZSBpcyBubyBtYXAuZGF0IGZpbGUgaW4gZHVtcCwgdGhlbiByZXR1cm4gZnJvbSBoZXJlIGFz
IHRoZXJlIGlzCkBAIC0xMjA2LDcgKzEyMTAsNyBAQCByZXN0b3JlX2FsbF9kYXRhYmFzZXMoY29u
c3QgY2hhciAqaW5wdXRGaWxlU3BlYywKIAlpZiAob3B0cy0+Y3BhcmFtcy5kYm5hbWUpCiAJCWNv
bm5lY3RlZF9kYiA9IG9wdHMtPmNwYXJhbXMuZGJuYW1lOwogCi0JbnVtX3RvdGFsX2RiID0gZ2V0
X2RibmFtZV9vaWRfbGlzdF9mcm9tX21maWxlKChjaGFyICopIGlucHV0RmlsZVNwZWMsICZkYm5h
bWVfb2lkX2xpc3QpOworCW51bV90b3RhbF9kYiA9IGdldF9kYm5hbWVfb2lkX2xpc3RfZnJvbV9t
ZmlsZShpbnB1dEZpbGVTcGVjLCAmZGJuYW1lX29pZF9saXN0KTsKIAogCXBnX2xvZ19pbmZvKG5n
ZXR0ZXh0KCJmb3VuZCAlZCBkYXRhYmFzZSBuYW1lIGluIFwiJXNcIiIsCiAJCQkJCQkgImZvdW5k
ICVkIGRhdGFiYXNlIG5hbWVzIGluIFwiJXNcIiIsCi0tIAoyLjUyLjAKCg==
--00000000000072fd79064c1cdbc9--