public inbox for [email protected]
help / color / mirror / Atom feedFrom: Mahendra Singh Thalor <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: bug: pg_dumpall with --data-only and --clean options is giving an error after some dump
Date: Sun, 15 Mar 2026 19:36:14 +0530
Message-ID: <CAKYtNAp2L2nnC-7vdkEkkccDLmv22BH0wJyAzd3Z-M2ugYSEKQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
Thanks Andrew, Álvaro and Srinath for the review and feedback.
> 1) maybe match the pg_dumpall comment with the pg_dump comment.
I took this comment from pg_restore so i am keeping this same as pg_restore.
> 2) please fix the indentation using pgindent
> --
> Thanks,
> Srinath Reddy Sadipiralla
> EDB: https://www.enterprisedb.com/
Fixed.
On Sun, 15 Mar 2026 at 17:41, Álvaro Herrera <[email protected]> wrote:
>
> Hi,
>
> On 2026-Mar-15, Andrew Dunstan wrote:
>
> > On 2026-03-14 Sa 3:18 PM, Mahendra Singh Thalor wrote:
> >
> > > I was doing some tests with pg_dump, pg_dumpall and pg_restore tools.
> > > With "pg_dumpall --data-only --clean", we are reporting an error after
> > > dumping some data.
> >
> > Hmm, this looks like behaviour that goes a long way back. Should we
> > backpatch this fix?
>
> IMO it would make sense to do so.
>
> --
> Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
As per suggestions, I made patches till PG14.
Here, I am attaching updated patches.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
Attachments:
[text/x-patch] v02-master-pg_dumpall-clean-and-data-only-are-incompatible.patch (1.8K, 2-v02-master-pg_dumpall-clean-and-data-only-are-incompatible.patch)
download | inline diff:
From 9c206b78915663fef9387ba623bfb15350f280c8 Mon Sep 17 00:00:00 2001
From: Mahendra Singh Thalor <[email protected]>
Date: Sun, 15 Mar 2026 18:40:02 +0530
Subject: [PATCH] pg_dumpall: -clean and --data-only are incompatible
Report error when -clean and --data-only are given with pg_dumpall.
As of now, we are dumping some data and later we are exiting with
error from pg_dump.
---
src/bin/pg_dump/pg_dumpall.c | 4 ++++
src/bin/pg_dump/t/001_basic.pl | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 3d2a1d27aef..20cdd2d92f0 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -455,6 +455,10 @@ main(int argc, char *argv[])
schema_only, "-s/--schema-only",
tablespaces_only, "-t/--tablespaces-only");
+ /* --clean and --data-only are incompatible */
+ check_mut_excl_opts(output_clean, "-c/--clean",
+ data_only, "-a/--data-only");
+
if (if_exists && !output_clean)
pg_fatal("option %s requires option %s",
"--if-exists", "-c/--clean");
diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 2f5eb48e7b8..8aab1187282 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -50,6 +50,11 @@ command_fails_like(
'pg_dump: options -a/--data-only and -s/--schema-only cannot be used together'
);
+command_fails_like(
+ [ 'pg_dumpall', '-c', '-a' ],
+ qr/\Qpg_dumpall: error: options -c\/--clean and -a\/--data-only cannot be used together\E/,
+ 'pg_dumpall: options -c/--clean and -a/--data-only cannot be used together');
+
command_fails_like(
[ 'pg_dump', '-s', '--statistics-only' ],
qr/\Qpg_dump: error: options -s\/--schema-only and --statistics-only cannot be used together\E/,
--
2.52.0
[application/octet-stream] v02-PG18-pg_dumpall-clean-and-data-only-are-incompatible.noci (1.9K, 3-v02-PG18-pg_dumpall-clean-and-data-only-are-incompatible.noci)
download
[application/octet-stream] v02-PG14-pg_dumpall-clean-and-data-only-are-incompatible.noci (1.9K, 4-v02-PG14-pg_dumpall-clean-and-data-only-are-incompatible.noci)
download
[application/octet-stream] v02-PG15-16-17-pg_dumpall-clean-and-data-only-are-incompatible.noci (1.9K, 5-v02-PG15-16-17-pg_dumpall-clean-and-data-only-are-incompatible.noci)
download
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: bug: pg_dumpall with --data-only and --clean options is giving an error after some dump
In-Reply-To: <CAKYtNAp2L2nnC-7vdkEkkccDLmv22BH0wJyAzd3Z-M2ugYSEKQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox