MIME-Version: 1.0
References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <CAC6VRoZbP=-=a+a78RoWcs2L4=4VEDZqJMg+7SyUAcSHATyDAQ@mail.gmail.com>
 <CAC6VRoY-1WC_O5UDwKzNc18LXLwjuTFb+qMNY3gaF3cCov6M6g@mail.gmail.com>
 <CAKYtNArc3j8Akb+nB1QyJLKic7ej7vKZqKnv_mbB+iQAJRzLnA@mail.gmail.com>
 <CAC6VRoat6NPcS6vfGrPrwaQB3G1JHLSqDeAkf1AJ7npWrwhnUQ@mail.gmail.com>
 <CAKYtNAp=TFEZWQbTRZso3kNaD9BH=-JPNQ30mT60cJN_04hEog@mail.gmail.com>
 <4022765f-38ee-48a3-b246-615b3f8e1c23@dunslane.net> <CAKYtNAq73_UeL4-0wgu9rawctHdS2zhpzWtqVuOChCS3M+2Ymg@mail.gmail.com>
 <CACJufxFs9NXXTeb78i2MD+pnZootayAtiGcNHNeU35SmQgMjbA@mail.gmail.com>
 <59d3616f-6d6d-40d5-87e2-e019e350b52d@dunslane.net> <CACJufxEnmJ8otfmN7Kp110Wqi=M4YE0-zn-W6SK+eTpWuZw_fg@mail.gmail.com>
 <CAKYtNAqxjQMLVPfz6XESqszhxZKgigi7UEBzBhz_Wj_Bnasdag@mail.gmail.com>
 <7faf3a59-cfe1-45cb-a972-55e05560b414@dunslane.net> <CACJufxE-zJiBAaZABtJBJr8FZdj=xP5adf_excmu9S6Op=KpLA@mail.gmail.com>
 <2e7ada75-422c-4153-9437-ea0ce8d63521@dunslane.net> <84764ef6-2bcb-43f7-9037-d7b589857da9@dunslane.net>
In-Reply-To: <84764ef6-2bcb-43f7-9037-d7b589857da9@dunslane.net>
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Fri, 27 Feb 2026 00:41:31 +0530
Message-ID: <CAKYtNApQt3Uhx3K=v2R7VKNsNUyL+_kC2Q_rS5_A+MLkZ6fkNA@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Andrew Dunstan <andrew@dunslane.net>
Cc: jian he <jian.universality@gmail.com>, tushar <tushar.ahuja@enterprisedb.com>, 
	Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAKYtNApQt3Uhx3K%3Dv2R7VKNsNUyL%2B_kC2Q_rS5_A%2BMLkZ6fkNA%40mail.gmail.com>
Precedence: bulk

On Thu, 26 Feb 2026 at 19:32, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2026-02-24 Tu 5:40 AM, Andrew Dunstan wrote:
> >
> > On 2026-02-24 Tu 2:21 AM, jian he wrote:
> >> Hi.
> >>
> >> For v19, the commit message
> >> """
> >> pg_restore is extended to handle these pg_dumpall archives, restoring
> >> globals and then each database. The --globals-only and --no-globals
> >> options control which parts are restored.
> >> """
> >> There is no --no-globals option.
> >>
> >> In file src/bin/pg_dump/pg_dumpall.c, no need
> >> ``
> >> static pg_compress_specification compression_spec = {0};
> >> ``
> >> Since compression_spec is only used in an IF branch, we can declare
> >> it locally.
> >>
> >>
> >> The options below are not supported for pg_restore non-text restore,
> >> we can document this.
> >>      <option>-a/--data-only</option>,
> >>      <option>-l/--list</option>,
> >>      <option>-L/--use-list</option>,
> >>      <option>--statistics-only</option>,
> >>      <option>--strict-names</option>,
> >>      <option>--no-schema</option>.
> >>
> >>
> >>
> >
> > Thanks, fixed these.
> >
> >
> >
>
>
> pushed with a slight tweak.
>
>
> cheers
>
>
> andrew
>
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>

Thanks Andrew for committing this patch.

-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com