MIME-Version: 1.0
References: 
 <CAKYtNApkh=Vy2DpNRCnEJmPpxNuksbAh_QBav=2fLmVjBhGwFw@mail.gmail.com>
In-Reply-To: 
 <CAKYtNApkh=Vy2DpNRCnEJmPpxNuksbAh_QBav=2fLmVjBhGwFw@mail.gmail.com>
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Sun, 15 Mar 2026 09:48:06 +0530
Message-ID: 
 <CAKYtNApxyeeQbjxjFCgHwuv0T2TJvFaU6QSQaMU_yr1nP4Y8Fg@mail.gmail.com>
Subject: Re: pg_restore --format= option(without any value) should report an
 error as pg_dump is reporting an error
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000591c01064d086472"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKYtNApxyeeQbjxjFCgHwuv0T2TJvFaU6QSQaMU_yr1nP4Y8Fg%40mail.gmail.com>
Precedence: bulk

--000000000000591c01064d086472
Content-Type: text/plain; charset="UTF-8"

On Sun, 13 Apr 2025 at 18:32, Mahendra Singh Thalor <mahi6run@gmail.com> wrote:
>
> Hi,
> With "pg_restore --format=", we are not giving any error because in code, we are checking length of arg but pg_dump is reporting an error for the same option.
>
> For the consistency purpose, pg_dump and pg_restore both should report an error for the test case below.
>
> Ex: (output after this patch)but before this patch, below command is passing.
> /pg_restore  x1 -d postgres -j 10 -C --verbose --format=
> pg_restore: error: unrecognized archive format ""; please specify "c", "d", or "t"
>
> Here, I am attaching a patch which is fixing the same. I added 2 TAP tests also for invalid options.
>
> Note: We have 2 more options in pg_restore code which validate the option if arg has non zero length. I will prepare patches for both(--host and --port). We need to add some validate function also for both these options.
>
> --
> Thanks and Regards
> Mahendra Singh Thalor
> EnterpriseDB: http://www.enterprisedb.com

Hi all,
Here I am attaching a re-based patch.

I think we should sync behaviour with pg_dump and pg_restore. Please
review this patch and let me know feedback.

-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

--000000000000591c01064d086472
Content-Type: text/x-patch; charset="US-ASCII";
	name="v02-pg_restore-format-option-should-validate-all-values.patch"
Content-Disposition: attachment;
	filename="v02-pg_restore-format-option-should-validate-all-values.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmr8ujxr0>
X-Attachment-Id: f_mmr8ujxr0

RnJvbSA4ZmE5ZjA1NmQ1NjdjZTM1MGU4ODUwM2M4NzJlMDI2NzU5MjEwMGEwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYWhlbmRyYSBTaW5naCBUaGFsb3IgPG1haGk2cnVuQGdtYWls
LmNvbT4KRGF0ZTogU3VuLCAxNSBNYXIgMjAyNiAwOTo0Mjo1MiArMDUzMApTdWJqZWN0OiBbUEFU
Q0hdIHBnX3Jlc3RvcmUgLS1mb3JtYXQgb3B0aW9uIHNob3VsZCB2YWxpZGF0ZSBhbGwgdmFsdWVz
CgpXaXRoICJwZ19yZXN0b3JlIC0tZm9ybWF0PSIsIHdlIGFyZSBub3QgZ2l2aW5nIGFueSBlcnJv
ciBiZWNhdXNlIGluIGNvZGUsIHdlIGFyZSBjaGVja2luZwpsZW5ndGggb2YgYXJnIGJ1dCBwZ19k
dW1wIGlzIHRyb3VnaGluZyBhbiBlcnJvciBmb3IgdGhlIHNhbWUgb3B0aW9uLgoKRXg6IGJlZm9y
ZSB0aGlzIHBhdGNoLCBiZWxvdyBjb21tYW5kIHdhcyBwYXNzaW5nLgovcGdfcmVzdG9yZSAgeDEg
LWQgcG9zdGdyZXMgLWogMTAgLUMgLS12ZXJib3NlIC0tZm9ybWF0PQoKYWZ0ZXIgcGF0Y2g6Ci9w
Z19yZXN0b3JlICB4MSAtZCBwb3N0Z3JlcyAtaiAxMCAtQyAtLXZlcmJvc2UgLS1mb3JtYXQ9CnBn
X3Jlc3RvcmU6IGVycm9yOiB1bnJlY29nbml6ZWQgYXJjaGl2ZSBmb3JtYXQgIiI7IHBsZWFzZSBz
cGVjaWZ5ICJjIiwgImQiLCBvciAidCIKCk5vdGU6IHBnX2R1bXAgaXMgYWxyZWFkeSByZXBvcnRp
bmcgYW4gZXJyb3IgaW4gYWJvdmUgY2FzZS4KLS0tCiBzcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9y
ZS5jICAgfCAgMyArLS0KIHNyYy9iaW4vcGdfZHVtcC90LzAwMV9iYXNpYy5wbCB8IDEwICsrKysr
KysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK
IG1vZGUgY2hhbmdlIDEwMDY0NCA9PiAxMDA3NTUgc3JjL2Jpbi9wZ19kdW1wL3QvMDAxX2Jhc2lj
LnBsCgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYyBiL3NyYy9iaW4v
cGdfZHVtcC9wZ19yZXN0b3JlLmMKaW5kZXggZmI0NGMwY2ZkZmUuLmQ3NTVkM2M3MmRjIDEwMDY0
NAotLS0gYS9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jCisrKyBiL3NyYy9iaW4vcGdfZHVt
cC9wZ19yZXN0b3JlLmMKQEAgLTIyNSw4ICsyMjUsNyBAQCBtYWluKGludCBhcmdjLCBjaGFyICoq
YXJndikKIAkJCQlvcHRzLT5maWxlbmFtZSA9IHBnX3N0cmR1cChvcHRhcmcpOwogCQkJCWJyZWFr
OwogCQkJY2FzZSAnRic6Ci0JCQkJaWYgKHN0cmxlbihvcHRhcmcpICE9IDApCi0JCQkJCW9wdHMt
PmZvcm1hdE5hbWUgPSBwZ19zdHJkdXAob3B0YXJnKTsKKwkJCQlvcHRzLT5mb3JtYXROYW1lID0g
cGdfc3RyZHVwKG9wdGFyZyk7CiAJCQkJYnJlYWs7CiAJCQljYXNlICdnJzoKIAkJCQkvKiByZXN0
b3JlIG9ubHkgZ2xvYmFsIHNxbCBjb21tYW5kcy4gKi8KZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdf
ZHVtcC90LzAwMV9iYXNpYy5wbCBiL3NyYy9iaW4vcGdfZHVtcC90LzAwMV9iYXNpYy5wbApvbGQg
bW9kZSAxMDA2NDQKbmV3IG1vZGUgMTAwNzU1CmluZGV4IDJmNWViNDhlN2I4Li5iZjY2MTkxMGM2
NgotLS0gYS9zcmMvYmluL3BnX2R1bXAvdC8wMDFfYmFzaWMucGwKKysrIGIvc3JjL2Jpbi9wZ19k
dW1wL3QvMDAxX2Jhc2ljLnBsCkBAIC0yMDEsNiArMjAxLDE2IEBAIGNvbW1hbmRfZmFpbHNfbGlr
ZSgKIAlxci9cUXBnX3Jlc3RvcmU6IGVycm9yOiB1bnJlY29nbml6ZWQgYXJjaGl2ZSBmb3JtYXQg
ImdhcmJhZ2UiO1xFLywKIAkncGdfZHVtcDogdW5yZWNvZ25pemVkIGFyY2hpdmUgZm9ybWF0Jyk7
CiAKK2NvbW1hbmRfZmFpbHNfbGlrZSgKKwlbICdwZ19yZXN0b3JlJywgJy1mIC0nLCAnLS1mb3Jt
YXQ9J10sCisJcXIvXFFwZ19yZXN0b3JlOiBlcnJvcjogdW5yZWNvZ25pemVkIGFyY2hpdmUgZm9y
bWF0ICIiO1xFLywKKwkncGdfZHVtcDogdW5yZWNvZ25pemVkIGFyY2hpdmUgZm9ybWF0IGVtcHR5
IHN0cmluZycpOworCitjb21tYW5kX2ZhaWxzX2xpa2UoCisJWyAncGdfcmVzdG9yZScsICctZiAt
JywgJy1GJywgJ3AnIF0sCisJcXIvXFFwZ19yZXN0b3JlOiBlcnJvcjogYXJjaGl2ZSBmb3JtYXQg
InAiIGlzIG5vdCBzdXBwb3J0ZWQ7IHBsZWFzZSB1c2UgcHNxbFxFLywKKwkncGdfZHVtcDogdW5y
ZWNvZ25pemVkIGFyY2hpdmUgZm9ybWF0IHB8cGxhaW4nKTsKKwogY29tbWFuZF9mYWlsc19saWtl
KAogCVsgJ3BnX2R1bXAnLCAnLS1vbi1jb25mbGljdC1kby1ub3RoaW5nJyBdLAogCXFyL3BnX2R1
bXA6IGVycm9yOiBvcHRpb24gLS1vbi1jb25mbGljdC1kby1ub3RoaW5nIHJlcXVpcmVzIG9wdGlv
biAtLWluc2VydHMsIC0tcm93cy1wZXItaW5zZXJ0LCBvciAtLWNvbHVtbi1pbnNlcnRzLywKLS0g
CjIuNTIuMAoK
--000000000000591c01064d086472--