MIME-Version: 1.0
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Sun, 15 Mar 2026 22:59:53 +0530
Message-ID: 
 <CAKYtNArGv45WX3mpOrQ9p6+gb7FvA8qF14FB5pZfcDJ9PQrWKA@mail.gmail.com>
Subject: pg_restore: TAP test case typo(wrong word) for an error hint in
 001_basic.pl
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000000199ec064d137407"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKYtNArGv45WX3mpOrQ9p6%2Bgb7FvA8qF14FB5pZfcDJ9PQrWKA%40mail.gmail.com>
Precedence: bulk

--0000000000000199ec064d137407
Content-Type: multipart/alternative; boundary="0000000000000199ea064d137405"

--0000000000000199ea064d137405
Content-Type: text/plain; charset="UTF-8"

Hi,

While doing some changes, I found a typo error(wrong word) in 001_basic.pl
file.

In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump,
pg_restore and pg_dumpall.
In one error case, we added  'pg_dump' name instead of 'pg_rsetore'.

diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 9f12ca6c51d..ff1d422292e 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -144,7 +144,7 @@ command_fails_like(
 command_fails_like(
        [ 'pg_restore', '-f -', '-F', 'garbage' ],
        qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/,
-       'pg_dump: unrecognized archive format');
+       'pg_restore: unrecognized archive format');

Here, I am attaching a patch to fix this.This patch can be applied till
PG14.

I think we should back-patch till PG14. Please review this.

-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

--0000000000000199ea064d137405
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi,</div><div><br></div><div>While d=
oing some changes, I found a typo error(wrong word) in <a href=3D"http://00=
1_basic.pl" target=3D"_blank">001_basic.pl</a> file.</div><div>=C2=A0 =C2=
=A0</div><div>In 31a8b77a9244a0883e1968adc, we added some test cases for pg=
_dump, pg_restore and pg_dumpall.</div><div>In one error case, we added=C2=
=A0 &#39;pg_dump&#39; name instead of &#39;pg_rsetore&#39;.</div><div><br><=
/div><div>diff --git a/src/bin/pg_dump/t/<a href=3D"http://001_basic.pl" ta=
rget=3D"_blank">001_basic.pl</a> b/src/bin/pg_dump/t/<a href=3D"http://001_=
basic.pl" target=3D"_blank">001_basic.pl</a><br>index 9f12ca6c51d..ff1d4222=
92e 100644<br>--- a/src/bin/pg_dump/t/<a href=3D"http://001_basic.pl" targe=
t=3D"_blank">001_basic.pl</a><br>+++ b/src/bin/pg_dump/t/<a href=3D"http://=
001_basic.pl" target=3D"_blank">001_basic.pl</a><br>@@ -144,7 +144,7 @@ com=
mand_fails_like(<br>=C2=A0command_fails_like(<br>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 [ &#39;pg_restore&#39;, &#39;-f -&#39;, &#39;-F&#39;, &#39;garbage&#39;=
 ],<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 qr/\Qpg_restore: error: unrecognized arc=
hive format &quot;garbage&quot;;\E/,<br>- =C2=A0 =C2=A0 =C2=A0 &#39;pg_dump=
: unrecognized archive format&#39;);<br>+ =C2=A0 =C2=A0 =C2=A0 &#39;pg_rest=
ore: unrecognized archive format&#39;);<br>=C2=A0<br>Here, I am attaching a=
 patch to fix this.This patch can be applied till PG14.</div><div><br></div=
><div>I think we should back-patch till PG14. Please review this.</div><div=
><br></div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D=
"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signature">Thanks a=
nd Regards<br>Mahendra Singh Thalor<br>EnterpriseDB: <a href=3D"http://www.=
enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a></div></=
div>
</div>

--0000000000000199ea064d137405--

--0000000000000199ec064d137407
Content-Type: text/x-patch; charset="US-ASCII";
	name="v01-pg_restore-TAP-test-wrong-word-in-hint.patch"
Content-Disposition: attachment;
	filename="v01-pg_restore-TAP-test-wrong-word-in-hint.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mms146au0>
X-Attachment-Id: f_mms146au0

RnJvbSBlMmFjN2UwOGRhOGJlMThkYmUxMzEyNDJhMGI4YzEzZTk5OWIwZDQzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYWhlbmRyYSBTaW5naCBUaGFsb3IgPG1haGk2cnVuQGdtYWls
LmNvbT4KRGF0ZTogU3VuLCAxNSBNYXIgMjAyNiAyMjo1NTo1OSArMDUzMApTdWJqZWN0OiBbUEFU
Q0hdIHBnX3Jlc3RvcmUgVEFQIHRlc3QgZml4IHdyb25nIHdvcmQKCldoaWxlIGRvaW5nIHNvbWUg
Y2hhbmdlcywgSSBmb3VuZCBhIHR5cG8gZXJyb3Iod3Jvbmcgd29yZCkKaW4gMDAxX2Jhc2ljLnBs
IGZpbGUuCgpJbiAzMWE4Yjc3YTkyNDRhMDg4M2UxOTY4YWRjLCB3ZSBhZGRlZCBzb21lIHRlc3Qg
Y2FzZXMgZm9yIHBnX2R1bXAsCnBnX3Jlc3RvcmUgYW5kIHBnX2R1bXBhbGwuIEluIG9uZSBlcnJv
ciBjYXNlLCB3ZSBhZGRlZCB0aGUgJ3BnX2R1bXAnCm5hbWUgaW5zdGVhZCBvZiAncGdfcnNldG9y
ZScuCgpiYWNrLXBhdGNoIHRpbGwgUEcxNAotLS0KIHNyYy9iaW4vcGdfZHVtcC90LzAwMV9iYXNp
Yy5wbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt
KQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC90LzAwMV9iYXNpYy5wbCBiL3NyYy9iaW4v
cGdfZHVtcC90LzAwMV9iYXNpYy5wbAppbmRleCAyZjVlYjQ4ZTdiOC4uOTMwNWM0NmY0YWYgMTAw
NjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC90LzAwMV9iYXNpYy5wbAorKysgYi9zcmMvYmluL3Bn
X2R1bXAvdC8wMDFfYmFzaWMucGwKQEAgLTE5OSw3ICsxOTksNyBAQCBjb21tYW5kX2ZhaWxzX2xp
a2UoCiBjb21tYW5kX2ZhaWxzX2xpa2UoCiAJWyAncGdfcmVzdG9yZScsICctZiAtJywgJy1GJywg
J2dhcmJhZ2UnIF0sCiAJcXIvXFFwZ19yZXN0b3JlOiBlcnJvcjogdW5yZWNvZ25pemVkIGFyY2hp
dmUgZm9ybWF0ICJnYXJiYWdlIjtcRS8sCi0JJ3BnX2R1bXA6IHVucmVjb2duaXplZCBhcmNoaXZl
IGZvcm1hdCcpOworCSdwZ19yZXN0b3JlOiB1bnJlY29nbml6ZWQgYXJjaGl2ZSBmb3JtYXQnKTsK
IAogY29tbWFuZF9mYWlsc19saWtlKAogCVsgJ3BnX2R1bXAnLCAnLS1vbi1jb25mbGljdC1kby1u
b3RoaW5nJyBdLAotLSAKMi41Mi4wCgo=
--0000000000000199ec064d137407--