MIME-Version: 1.0
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Sun, 15 Mar 2026 00:48:39 +0530
Message-ID: 
 <CAKYtNArrHiJ0LDB9BFZiUWs6tC78QkBN50wiwO07WhxewYDS3Q@mail.gmail.com>
Subject: bug: pg_dumpall with --data-only and --clean options is giving an
 error after some dump
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000150e73064d00db00"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKYtNArrHiJ0LDB9BFZiUWs6tC78QkBN50wiwO07WhxewYDS3Q%40mail.gmail.com>
Precedence: bulk

--000000000000150e73064d00db00
Content-Type: multipart/alternative; boundary="000000000000150e71064d00dbfe"

--000000000000150e71064d00dbfe
Content-Type: text/plain; charset="UTF-8"

Hi all,

I was doing some tests with pg_dump, pg_dumpall and pg_restore tools. With
"pg_dumpall --data-only --clean", we are reporting an error after dumping
some data.

Please see the example below.

./pg_dumpall --data-only --clean
> --
> -- PostgreSQL database cluster dump
> --
>
> \restrict ZQDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDccKbXG8q6PI4RB69Dd8KaqcWMY
>
> SET default_transaction_read_only = off;
>
> SET client_encoding = 'UTF8';
> SET standard_conforming_strings = on;
>
> \unrestrict ZQDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDccKbXG8q6PI4RB69Dd8KaqcWMY
>
> --
> -- Databases
> --
>
> --
> -- Database "template1" dump
> --
>
> pg_dump: error: options -c/--clean and -a/--data-only cannot be used
> together
> pg_dumpall: error: pg_dump failed on database "template1", exiting
>
>
Error is coming from pg_dump but it should come from pg_dumpall without
any dump.

Here, I am attaching a patch to fix this problem. Please review this.

-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com

--000000000000150e71064d00dbfe
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi all,</div><div><br></div><div>I was doing some tes=
ts with pg_dump, pg_dumpall and pg_restore tools. With &quot;pg_dumpall --d=
ata-only --clean&quot;, we are reporting an error after dumping some data.<=
/div><div><br></div><div>Please see the example below.</div><div><br></div>=
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex">./pg_dumpall --data-only =
--clean<br>--<br>-- PostgreSQL database cluster dump<br>--<br><br>\restrict=
 ZQDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDccKbXG8q6PI4RB69Dd8KaqcWMY<br><br>SET=
 default_transaction_read_only =3D off;<br><br>SET client_encoding =3D &#39=
;UTF8&#39;;<br>SET standard_conforming_strings =3D on;<br><br>\unrestrict Z=
QDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDccKbXG8q6PI4RB69Dd8KaqcWMY<br><br>--<br=
>-- Databases<br>--<br><br>--<br>-- Database &quot;template1&quot; dump<br>=
--<br><br>pg_dump: error: options -c/--clean and -a/--data-only cannot be u=
sed together<br>pg_dumpall: error: pg_dump failed on database &quot;templat=
e1&quot;, exiting<br><br></blockquote><div><br></div><div>Error is coming f=
rom pg_dump but it should come from pg_dumpall without any=C2=A0dump.</div>=
<div><br></div><div>Here, I am attaching a patch to fix this problem. Pleas=
e review this.</div><div><br></div>-- <br>Thanks and Regards<br>Mahendra Si=
ngh Thalor<br>EnterpriseDB: <a href=3D"http://www.enterprisedb.com">http://=
www.enterprisedb.com</a></div>

--000000000000150e71064d00dbfe--

--000000000000150e73064d00db00
Content-Type: text/x-patch; charset="US-ASCII";
	name="v01-pg_dumpall-clean-and-data-only-are-incompatible.patch"
Content-Disposition: attachment;
	filename="v01-pg_dumpall-clean-and-data-only-are-incompatible.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmqpg5ud0>
X-Attachment-Id: f_mmqpg5ud0

RnJvbSBiYmMwMTRhYjNlNmQ5NTZkZjUzYWE3OTY1ZDNhNmI2ZDVkODY5YmFmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYWhlbmRyYSBTaW5naCBUaGFsb3IgPG1haGk2cnVuQGdtYWls
LmNvbT4KRGF0ZTogU3VuLCAxNSBNYXIgMjAyNiAwMDozODoxNiArMDUzMApTdWJqZWN0OiBbUEFU
Q0hdIHBnX2R1bXBhbGw6IC1jbGVhbiBhbmQgLS1kYXRhLW9ubHkgYXJlIGluY29tcGF0aWJsZQoK
UmVwb3J0IGVycm9yIHdoZW4gLWNsZWFuIGFuZCAtLWRhdGEtb25seSBhcmUgZ2l2ZW4gd2l0aCBw
Z19kdW1wYWxsLgoKQXMgb2Ygbm93LCB3ZSBhcmUgZHVtcGluZyBzb21lIGRhdGEgYW5kIGxhdGVy
IHdlIGFyZSBleGl0aW5nIHdpdGgKZXJyb3IgZnJvbSBwZ19kdW1wLgotLS0KIHNyYy9iaW4vcGdf
ZHVtcC9wZ19kdW1wYWxsLmMgICB8IDQgKysrKwogc3JjL2Jpbi9wZ19kdW1wL3QvMDAxX2Jhc2lj
LnBsIHwgNSArKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKykKCmRpZmYgLS1n
aXQgYS9zcmMvYmluL3BnX2R1bXAvcGdfZHVtcGFsbC5jIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1
bXBhbGwuYwppbmRleCAzZDJhMWQyN2FlZi4uNDdhMDYyZDAxNjAgMTAwNjQ0Ci0tLSBhL3NyYy9i
aW4vcGdfZHVtcC9wZ19kdW1wYWxsLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXBhbGwu
YwpAQCAtNDU1LDYgKzQ1NSwxMCBAQCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAJCQkJ
CQlzY2hlbWFfb25seSwgIi1zLy0tc2NoZW1hLW9ubHkiLAogCQkJCQkJdGFibGVzcGFjZXNfb25s
eSwgIi10Ly0tdGFibGVzcGFjZXMtb25seSIpOwogCisJLyogLS1jbGVhbiBhbmQgLS1kYXRhLW9u
bHkgYXJlIGluY29tcGF0aWJsZSAqLworCWNoZWNrX211dF9leGNsX29wdHMob3V0cHV0X2NsZWFu
LCAiLWMvLS1jbGVhbiIsCisJCQlkYXRhX29ubHksICItYS8tLWRhdGEtb25seSIpOworCiAJaWYg
KGlmX2V4aXN0cyAmJiAhb3V0cHV0X2NsZWFuKQogCQlwZ19mYXRhbCgib3B0aW9uICVzIHJlcXVp
cmVzIG9wdGlvbiAlcyIsCiAJCQkJICItLWlmLWV4aXN0cyIsICItYy8tLWNsZWFuIik7CmRpZmYg
LS1naXQgYS9zcmMvYmluL3BnX2R1bXAvdC8wMDFfYmFzaWMucGwgYi9zcmMvYmluL3BnX2R1bXAv
dC8wMDFfYmFzaWMucGwKaW5kZXggMmY1ZWI0OGU3YjguLjhhYWIxMTg3MjgyIDEwMDY0NAotLS0g
YS9zcmMvYmluL3BnX2R1bXAvdC8wMDFfYmFzaWMucGwKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3Qv
MDAxX2Jhc2ljLnBsCkBAIC01MCw2ICs1MCwxMSBAQCBjb21tYW5kX2ZhaWxzX2xpa2UoCiAJJ3Bn
X2R1bXA6IG9wdGlvbnMgLWEvLS1kYXRhLW9ubHkgYW5kIC1zLy0tc2NoZW1hLW9ubHkgY2Fubm90
IGJlIHVzZWQgdG9nZXRoZXInCiApOwogCitjb21tYW5kX2ZhaWxzX2xpa2UoCisgICAgICAgIFsg
J3BnX2R1bXBhbGwnLCAnLWMnLCAnLWEnIF0sCisgICAgICAgIHFyL1xRcGdfZHVtcGFsbDogZXJy
b3I6IG9wdGlvbnMgLWNcLy0tY2xlYW4gYW5kIC1hXC8tLWRhdGEtb25seSBjYW5ub3QgYmUgdXNl
ZCB0b2dldGhlclxFLywKKyAgICAgICAgJ3BnX2R1bXBhbGw6IG9wdGlvbnMgLWMvLS1jbGVhbiBh
bmQgLWEvLS1kYXRhLW9ubHkgY2Fubm90IGJlIHVzZWQgdG9nZXRoZXInKTsKKwogY29tbWFuZF9m
YWlsc19saWtlKAogCVsgJ3BnX2R1bXAnLCAnLXMnLCAnLS1zdGF0aXN0aWNzLW9ubHknIF0sCiAJ
cXIvXFFwZ19kdW1wOiBlcnJvcjogb3B0aW9ucyAtc1wvLS1zY2hlbWEtb25seSBhbmQgLS1zdGF0
aXN0aWNzLW9ubHkgY2Fubm90IGJlIHVzZWQgdG9nZXRoZXJcRS8sCi0tIAoyLjUyLjAKCg==
--000000000000150e73064d00db00--