MIME-Version: 1.0
References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <2bed001a-462c-42da-9a6b-3c7884502932@dunslane.net>
 <fd25e8b7-9538-4e44-90e5-8a357ac03eff@dunslane.net>
 <20250824010811.4d.nmisch@google.com>
 <82eb35b8-7f07-493b-b689-0934919e1dc3@dunslane.net>
 <CAKYtNAr+OMjcGKwd+AgWA+s=8EWGtg5PkVV3O7X6d3eCv=MUeQ@mail.gmail.com>
 <CAKYtNApzLLeCqt5fHDzZOTnzCdCnBt3Y_fytFmJ0LMNHDPY-yA@mail.gmail.com>
 <CAKYtNArSYJdjez541C0qPZ9R3_yzPDpScAd=-RU4kPRCJh4viQ@mail.gmail.com>
 <CAKYtNArGUTzrfTBxpftL_yAgkKE+hcDgXVfQvjB2HFO9rGhE5g@mail.gmail.com>
 <CA+vB=AEQc3Xqz+KMh35Zsa-SsRP-n=HXGT4RwwNou4-__Prx+A@mail.gmail.com>
 <CAKYtNAqJqDmKcqCzpHg2SO=2MTxvE7rOWCACsoWsO7520tUWKw@mail.gmail.com>
 <CA+vB=AE9ypeQV-hhXscJ6T75BrAFfZh56GX_eM=eVG2n1o_Beg@mail.gmail.com>
 <CA+vB=AGsn4eUxsbLk_oy=iKzd8D_1Ne375XH-2u6Zncu72Q01Q@mail.gmail.com>
 <CAKYtNAqQ5LHWNWyaeVOJaS=2xDJovfv9GShTBzf8_5s=jH7wsg@mail.gmail.com>
 <CAKYtNAoSTBqR24cn3XDOnwk2DCL+nAUkjpB5Xkz1H74rDqa-aQ@mail.gmail.com>
 <17555e46-4fb2-4265-90e0-95cb8ed584a6@dunslane.net>
 <CAKYtNAoz9JZC+-Uo4QsA1O0PkEehxhTFy1y3HJjqzv6jwrXvCQ@mail.gmail.com>
 <CA+vB=AETksQZpjyBosrZv6N5A6DjaCtMQop3+MB8GDj0XnYoxQ@mail.gmail.com>
 <CAKYtNAoEUvYEG207zaGY0pEh6TB2sk6hpuz9LdG-fYEC=e2CgQ@mail.gmail.com>
 <CAKYtNAppx6y7M+9Fb5+TtTNhRS6onZo9kHeQS6yQF7PiK6qnEA@mail.gmail.com>
 <CAC6VRoZie9-iC9gWcJs3QGx=2_tA34fMBmj7Ck0VAP2JpDJGug@mail.gmail.com>
 <CAC6VRoZHZWzHZ0Oh++WW=9Q83co4AyG6u4+7HVi1gJiuv1CZ2g@mail.gmail.com>
 <CAC6VRoYWPQZeLDuKVNeMz5z-iiVnv0zWyBwWhxdm4UQO17-AUQ@mail.gmail.com>
 <CAKYtNAoNi8O1wbSZx0a1oSi-YzQtprxqpfZqryRq39hXn_p-OA@mail.gmail.com>
 <CAC6VRoYCqJq=0q3GF+vfDVbY4JUehqsuxYhcmVi7A=1hfNzSJg@mail.gmail.com>
 <CAKYtNApm8nA6hVMNkSjeNPiwTZBWYkhJKU7haQghUZdw74tYxA@mail.gmail.com>
 <CAC6VRoaG8-3etBR-j1vrqW875-Y2847GAsCmGqxKcMAbmyeyhA@mail.gmail.com>
In-Reply-To: 
 <CAC6VRoaG8-3etBR-j1vrqW875-Y2847GAsCmGqxKcMAbmyeyhA@mail.gmail.com>
From: Mahendra Singh Thalor <mahi6run@gmail.com>
Date: Thu, 11 Dec 2025 21:39:39 +0530
Message-ID: 
 <CAKYtNAryvnS15DKdE-4QdiYeR1XKwz0RrOnsaNL72G5ubmn_hw@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: tushar <tushar.ahuja@enterprisedb.com>
Cc: Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAKYtNAryvnS15DKdE-4QdiYeR1XKwz0RrOnsaNL72G5ubmn_hw%40mail.gmail.com>
Precedence: bulk

On Wed, 10 Dec 2025 at 19:08, tushar <tushar.ahuja@enterprisedb.com> wrote:
>
>
>
> On Tue, Dec 9, 2025 at 12:18=E2=80=AFAM Mahendra Singh Thalor <mahi6run@g=
mail.com> wrote:
>>
>> On Mon, 8 Dec 2025 at 22:39, tushar <tushar.ahuja@enterprisedb.com> wrot=
e:
>>
>> Here, I am attaching an updated patch for the review and testing. This
>> can be applied on commit d0d0ba6cf66c4043501f6f7.
>>
>
> Thanks, Mahendra, please refer to this scenario where  if "--transaction-=
size" switch  is used with pg_dumpall/pg_restore, then the table creation f=
ails (or the table is not created)
>
> Steps to reproduce:
> 1. Connect to the psql terminal, create a table/insert rows { create tabl=
e t(n int); insert into t values (generate_series(1,15)); }
> 2. Perform pg_dump operation  { ./pg_dumpall -Ft -f tar.dump }
> 3. new cluster:
> try to restore with  --transaction-size switch { ./pg_restore -Ft  tar.du=
mp  -C -d postgres   --transaction-size=3D10 } =3D  Table failed to create
>
> I have checked via pg_dump/pg_restore using --transaction-size, and it is=
 working fine, i.e, table is created successfully
>
> ./pg_dump -Ft -f tar.d postgres
> ./pg_restore  --transaction-size=3D10 -Ft -d new_database  tar.d
>
> regards,
>
>
 Thanks Tushar for the report.

If transaction-size is given as non-zero, then pg_restore behaves like
"-e/--exit-on-error". means if there is any error in restore, then
exit without restoring the full cluster.

Here, in our case, as the cluster already has a role with the current
user in restore, we are reporting error  "pg_restore: error: could not
execute query: ERROR:  role "role" already exists" and after this
error, restore is exiting.

If you restore using a different role, then you will not get any error
and the full cluster will be restored. I will add some handling to
ignore the "CREATE ROLE current_user" command in pg_restore.

--=20
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com