MIME-Version: 1.0
References: 
 <CAKZiRmz=YYQU5Gzq-bVjiwMfmVmxrewWaJVducSO3g4iWvBkFg@mail.gmail.com>
 <ym373n5ssebp64n7kwk4cwx2d5epwbabm76pdrk3gat63fxwbd@knjuyj6coe27>
In-Reply-To: <ym373n5ssebp64n7kwk4cwx2d5epwbabm76pdrk3gat63fxwbd@knjuyj6coe27>
From: Jakub Wartak <jakub.wartak@enterprisedb.com>
Date: Thu, 9 Apr 2026 10:35:48 +0200
Message-ID: 
 <CAKZiRmxUgcx6gY0kBSq8Y+RzACpknns6gkDt-OO1skr5H7ZAYQ@mail.gmail.com>
Subject: Re: Failing test_aio tests due to too low(illegal?) segsize_blocks
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAKZiRmxUgcx6gY0kBSq8Y%2BRzACpknns6gkDt-OO1skr5H7ZAYQ%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 8, 2026 at 8:57=E2=80=AFPM Andres Freund <andres@anarazel.de> w=
rote:
>
> Hi,
>
> On 2026-04-08 08:51:30 +0200, Jakub Wartak wrote:
> > For some reason I've ended up using -Dsegsize_blocks=3D4 and I've start=
ed
> > getting ninja test errors after getting back from vacation leave like
> > below (so this test was included only since then):
>
> It's IIRC not the only test that fails if you do that.
>
>
> > .cirrus file show usage of segsize_blocks=3D6, and also 8 works fine wi=
thout
> > errors, so it's just nuisance on my side, but it took some minutes for =
me
> > to realize this and I'll just ask maybe we should just block usage of
> > RELSEG_SIZE < 6 blocks in meson/configure? (patch attached)
>
> -1.  I find it quite useful for testing some edge cases to be able to
> configure with less.
>
> If you really care, I'd be ok with a patch that makes the relevant test_a=
io
> tests errors out with if it's set to a too low value...

Ah, true, with segsize_blocks=3D2 I've got failures in basebackup,
amcheck, test_aio.
I'm not going into that dragons' den. Ok, so maybe it would be useful to ju=
st
issue some sort of warning about that some test may fail when using value l=
ess
than 6?

-J.