public inbox for [email protected]
help / color / mirror / Atom feedFrom: Jakub Wartak <[email protected]>
To: Robert Haas <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: trying again to get incremental backup
Date: Fri, 8 Dec 2023 11:02:11 +0100
Message-ID: <CAKZiRmy73EKi3i5mdtcjn6r6WWQfKuri3HSQ+Pmdu_7g5Ef5kA@mail.gmail.com> (raw)
In-Reply-To: <CA+Tgmob4VFT6CuVaxwO0JjLrmCoHF+NNm_f1LsCeSi5i82MeSA@mail.gmail.com>
References: <CA+TgmoYiPn7GE_GFvGf+150XOt-Pkdm8h4rzy42jYCRrceUWhg@mail.gmail.com>
<[email protected]>
<CA+TgmoafkMay-O7KFyxwYxaT5pZ+ku+qM8hLM88ZzEyq2g-LtQ@mail.gmail.com>
<CAKZiRmys4AbHJOg2NAqGgjzmHC5CvA3JUHYAaQSG_turxccMFw@mail.gmail.com>
<CA+TgmoYuC27_ToGtTTNyHgpn_eJmdqrmhJ93bAbinkBtXsWHaA@mail.gmail.com>
<CA+Tgmob7CFCv99_bCRB=pWYat6r2rhgSqiEWQPJO67ywcb0Hpw@mail.gmail.com>
<CA+TgmoZpBW2DHeeC--y0H3y1RGsUHb14vinZU4yqBAHtWgv-vg@mail.gmail.com>
<CA+TgmoaiOhjd0pL630MSpZ_fyjFsARFC8RDBWxWL2FXPv65bJA@mail.gmail.com>
<CAKZiRmxGN4Eu90xOt8cJwgjV67jNSFsA6Lc_1bgCT5KR-5ywJA@mail.gmail.com>
<CA+Tgmob4VFT6CuVaxwO0JjLrmCoHF+NNm_f1LsCeSi5i82MeSA@mail.gmail.com>
On Thu, Dec 7, 2023 at 4:15 PM Robert Haas <[email protected]> wrote:
Hi Robert,
> On Thu, Dec 7, 2023 at 9:42 AM Jakub Wartak
> <[email protected]> wrote:
> > Comment: I was wondering if it wouldn't make some sense to teach
> > pg_resetwal to actually delete all WAL summaries after any any
> > WAL/controlfile alteration?
>
> I thought that this was a good idea so I decided to go implement it,
> only to discover that it was already part of the patch set ... did you
> find some case where it doesn't work as expected? The code looks like
> this:
Ah, my bad, with a fresh mind and coffee the error message makes it
clear and of course it did reset the summaries properly.
While we are at it, maybe around the below in PrepareForIncrementalBackup()
if (tlep[i] == NULL)
ereport(ERROR,
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
errmsg("timeline %u found in
manifest, but not in this server's history",
range->tli)));
we could add
errhint("You might need to start a new full backup instead of
incremental one")
?
> > test_pending_2pc.sh - getting GOOD on most recent runs, but several
> > times during early testing (probably due to my own mishaps), I've been
> > hit by Abort/TRAP. I'm still investigating and trying to reproduce
> > those ones. TRAP: failed Assert("summary_end_lsn >=
> > WalSummarizerCtl->pending_lsn"), File: "walsummarizer.c", Line: 940
>
> I have a fix for this locally, but I'm going to hold off on publishing
> a new version until either there's a few more things I can address all
> at once, or until Thomas commits the ubsan fix.
>
Great, I cannot get it to fail again today, it had to be some dirty
state of the testing env. BTW: Thomas has pushed that ubsan fix.
-J.
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: trying again to get incremental backup
In-Reply-To: <CAKZiRmy73EKi3i5mdtcjn6r6WWQfKuri3HSQ+Pmdu_7g5Ef5kA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox