MIME-Version: 1.0
From: Jakub Wartak <jakub.wartak@enterprisedb.com>
Date: Wed, 8 Apr 2026 08:51:30 +0200
Message-ID: 
 <CAKZiRmz=YYQU5Gzq-bVjiwMfmVmxrewWaJVducSO3g4iWvBkFg@mail.gmail.com>
Subject: Failing test_aio tests due to too low(illegal?) segsize_blocks
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Content-Type: multipart/mixed; boundary="0000000000001aeaa5064eed5598"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKZiRmz%3DYYQU5Gzq-bVjiwMfmVmxrewWaJVducSO3g4iWvBkFg%40mail.gmail.com>
Precedence: bulk

--0000000000001aeaa5064eed5598
Content-Type: text/plain; charset="UTF-8"

For some reason I've ended up using -Dsegsize_blocks=4 and I've started
getting ninja test errors after getting back from vacation leave like
below (so this test was included only since then):

stderr:
#   Failed test 'worker: normal: test reading of invalid block 2,3 in
larger read: expected stderr'
#   at /git/postgres/src/test/modules/test_aio/t/001_aio.pl line 989.
#                   'psql:<stdin>:55: ERROR:  read crossing segment boundary'
#     doesn't match '(?^:^psql:<stdin>:\d+: ERROR:  2 invalid pages
among blocks 1..4 of relation "base/.*/.*\nDETAIL:  Block 2 held the
first invalid page\.\nHINT:[^\n]+$)'
#   Failed test 'worker: normal: test zeroing of invalid block 2,3 in
larger read, ZERO_ON_ERROR: expected stderr'
#   at /git/postgres/src/test/modules/test_aio/t/001_aio.pl line 999.
#                   'psql:<stdin>:59: ERROR:  read crossing segment boundary'
#     doesn't match '(?^:^psql:<stdin>:\d+: WARNING:  zeroing out 2
invalid pages among blocks 1..4 of relation "base/.*/.*\nDETAIL:
Block 2 held the first zeroed page\.\nHINT:[^\n]+$)'
#   Failed test 'worker: normal: test zeroing of invalid block 2,3 in
larger read, zero_damaged_pages: expected stderr'
#   at /git/postgres/src/test/modules/test_aio/t/001_aio.pl line 1009.
#                   'psql:<stdin>:66: ERROR:  read crossing segment boundary'
[..]
#   at /git/postgres/src/test/modules/test_aio/t/001_aio.pl line 1353.
#                   'psql:<stdin>:62: ERROR:  read crossing segment boundary'
#     doesn't match '(?^:^psql:<stdin>:\d+: ERROR:  invalid page in
block 4 of relation "base/\d+/\d+"$)'
#   Failed test 'worker: test reading of valid block 1, checksum
failed 2, 3, invalid 3-5, zero=true: expected stderr'
#   at /git/postgres/src/test/modules/test_aio/t/001_aio.pl line 1375.
#                   'psql:<stdin>:77: ERROR:  read crossing segment boundary'
[..]

with segsize_blocks=5 I've got:

#   Failed test 'worker: temp rel: test reading of invalid block 4,
valid block 5: expected stderr'
#   at /git/postgres/src/test/modules/test_aio/t/001_aio.pl line 1158.
#                   'psql:<stdin>:66: ERROR:  read crossing segment boundary'
#     doesn't match '(?^:^psql:<stdin>:\d+: ERROR:  invalid page in
block 4 of relation "base/\d+/t\d+_\d+"$)'
#   Failed test 'worker: test reading of valid block 1, checksum
failed 2, 3, invalid 3-5, zero=true: expected stderr'
#   at /git/postgres/src/test/modules/test_aio/t/001_aio.pl line 1375.
#                   'psql:<stdin>:77: ERROR:  read crossing segment boundary'
#     doesn't match '(?^:^psql:<stdin>:\d+: WARNING:  zeroing 3
page\(s\) and ignoring 2 checksum failure\(s\) among blocks 1..5 of
relation ")'
# die: death by signal at
/git/postgres/src/test/perl/PostgreSQL/Test/Cluster.pm line 181.

.cirrus file show usage of segsize_blocks=6, and also 8 works fine without
errors, so it's just nuisance on my side, but it took some minutes for me
to realize this and I'll just ask maybe we should just block usage of
RELSEG_SIZE < 6 blocks in meson/configure? (patch attached)

-J.

--0000000000001aeaa5064eed5598
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-Limit-minimum-allowed-segsize-blocks-in-autoconf-.patch"
Content-Disposition: attachment;
	filename="v1-0001-Limit-minimum-allowed-segsize-blocks-in-autoconf-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnpotoo70>
X-Attachment-Id: f_mnpotoo70

RnJvbSA3MTU2ZTMxZDE0ZjFiMmIzN2VlM2I4MmE1Y2E0YThjNjliYmNmM2EzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXYXJ0YWsgPGpha3ViLndhcnRha0BlbnRlcnByaXNl
ZGIuY29tPgpEYXRlOiBXZWQsIDggQXByIDIwMjYgMDg6NDc6MjUgKzAyMDAKU3ViamVjdDogW1BB
VENIIHYxXSBMaW1pdCBtaW5pbXVtIGFsbG93ZWQgc2Vnc2l6ZS1ibG9ja3MgaW4gYXV0b2NvbmYv
bWVzb24gdG8KIGF2b2lkIGJsb3dpbmcgdXAgdGVzdHMKCi0tLQogY29uZmlndXJlICAgIHwgNCAr
KysrCiBjb25maWd1cmUuYWMgfCA0ICsrKysKIG1lc29uLmJ1aWxkICB8IDMgKysrCiAzIGZpbGVz
IGNoYW5nZWQsIDExIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9jb25maWd1cmUgYi9jb25m
aWd1cmUKaW5kZXggZjY2YzEwNTRhN2EuLmFmNDk4NTRlN2RmIDEwMDc1NQotLS0gYS9jb25maWd1
cmUKKysrIGIvY29uZmlndXJlCkBAIC0zNzk2LDYgKzM3OTYsMTAgQEAgaWYgdGVzdCAkc2Vnc2l6
ZV9ibG9ja3MgLW5lIDAgLWEgJHNlZ3NpemUgLW5lIDE7IHRoZW4KICRhc19lY2hvICIkYXNfbWU6
IFdBUk5JTkc6IGJvdGggLS13aXRoLXNlZ3NpemUgYW5kIC0td2l0aC1zZWdzaXplLWJsb2NrcyBz
cGVjaWZpZWQsIC0td2l0aC1zZWdzaXplLWJsb2NrcyB3aW5zIiA+JjI7fQogZmkKIAoraWYgdGVz
dCAkc2Vnc2l6ZV9ibG9ja3MgLW5lIDAgLWEgJHNlZ3NpemVfYmxvY2tzIC1sdCA2OyB0aGVuCisg
IGFzX2ZuX2Vycm9yICQ/ICJ0b28gc21hbGwgc2Vnc2l6ZS1ibG9ja3Mgc3BlY2lmaWVkIiAiJExJ
TkVOTyIgNQorZmkKKwogeyAkYXNfZWNobyAiJGFzX21lOiR7YXNfbGluZW5vLSRMSU5FTk99OiBj
aGVja2luZyBmb3Igc2VnbWVudCBzaXplIiA+JjUKICRhc19lY2hvX24gImNoZWNraW5nIGZvciBz
ZWdtZW50IHNpemUuLi4gIiA+JjY7IH0KIGlmIHRlc3QgJHNlZ3NpemVfYmxvY2tzIC1lcSAwOyB0
aGVuCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggOGQxNzZi
ZDM0NjguLmMwMWJmY2ViN2EwIDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmln
dXJlLmFjCkBAIC0yOTAsNiArMjkwLDEwIEBAIGlmIHRlc3QgJHNlZ3NpemVfYmxvY2tzIC1uZSAw
IC1hICRzZWdzaXplIC1uZSAxOyB0aGVuCiAgIEFDX01TR19XQVJOKFtib3RoIC0td2l0aC1zZWdz
aXplIGFuZCAtLXdpdGgtc2Vnc2l6ZS1ibG9ja3Mgc3BlY2lmaWVkLCAtLXdpdGgtc2Vnc2l6ZS1i
bG9ja3Mgd2luc10pCiBmaQogCitpZiB0ZXN0ICRzZWdzaXplX2Jsb2NrcyAtbmUgMCAtYSAkc2Vn
c2l6ZV9ibG9ja3MgLWx0IDY7IHRoZW4KKyAgQUNfTVNHX0VSUk9SKFt0b28gc21hbGwgc2Vnc2l6
ZS1ibG9ja3Mgc3BlY2lmaWVkXSkKK2ZpCisKIEFDX01TR19DSEVDS0lORyhbZm9yIHNlZ21lbnQg
c2l6ZV0pCiBpZiB0ZXN0ICRzZWdzaXplX2Jsb2NrcyAtZXEgMDsgdGhlbgogICAjIHRoaXMgZXhw
cmVzc2lvbiBpcyBzZXQgdXAgdG8gYXZvaWQgdW5uZWNlc3NhcnkgaW50ZWdlciBvdmVyZmxvdwpk
aWZmIC0tZ2l0IGEvbWVzb24uYnVpbGQgYi9tZXNvbi5idWlsZAppbmRleCBiZTk3ZTk4NmU1ZC4u
ZDc3MzQzZjVhNjQgMTAwNjQ0Ci0tLSBhL21lc29uLmJ1aWxkCisrKyBiL21lc29uLmJ1aWxkCkBA
IC01MTIsNiArNTEyLDkgQEAgaWYgZ2V0X29wdGlvbignc2Vnc2l6ZV9ibG9ja3MnKSAhPSAwCiAg
IGlmIGdldF9vcHRpb24oJ3NlZ3NpemUnKSAhPSAxCiAgICAgd2FybmluZygnYm90aCBzZWdzaXpl
IGFuZCBzZWdzaXplX2Jsb2NrcyBzcGVjaWZpZWQsIHNlZ3NpemVfYmxvY2tzIHdpbnMnKQogICBl
bmRpZgorICBpZiBnZXRfb3B0aW9uKCdzZWdzaXplX2Jsb2NrcycpIDwgNgorICAgIGVycm9yKCd0
b28gc21hbGwgc2Vnc2l6ZV9ibG9ja3Mgc3BlY2lmaWVkJykKKyAgZW5kaWYKIAogICBzZWdzaXpl
ID0gZ2V0X29wdGlvbignc2Vnc2l6ZV9ibG9ja3MnKQogZWxzZQotLSAKMi40My4wCgo=
--0000000000001aeaa5064eed5598--