MIME-Version: 1.0
References: <20231031090307.qkpmcgq53bzcoz7c@erthalion.local>
 <CALDaNm0Oov2Xbt8PLGOhFTLF7_uEWu6_pz2xHeEtQQiUx6nRiw@mail.gmail.com>
 <20240108161020.pltnhlbtc7x32tj4@erthalion.local> <20240113140538.ifmkd7y2kvfnsj3w@erthalion.local>
 <CAHut+PuXZsPPJyUnYY7RHSM0vspM0z42KfsTvOetJNkuuDGZSQ@mail.gmail.com>
 <20240122161123.tzau4pe6wp7h5vh2@erthalion.local> <3746172.1705941322@sss.pgh.pa.us>
 <20240122170727.6zcjobtvqz7z2cwp@ddolgov.remote.csb> <20240122210036.k55qagkrscfapwqb@erthalion.local>
 <CAKmOUTnXgqSS0Q7mFaQZBNbXUM+FYz5FZsHc4ifK+SgScSgXAQ@mail.gmail.com> <20240323182026.2jksclhldwvk2hmh@ddolgov.remote.csb>
In-Reply-To: <20240323182026.2jksclhldwvk2hmh@ddolgov.remote.csb>
From: Yasuo Honda <yasuo.honda@gmail.com>
Date: Sun, 24 Mar 2024 23:36:38 +0900
Message-ID: <CAKmOUTn74jTQAk0u2FUMsGjgrNugLOwkyic2MPkbOJtcQrufeA@mail.gmail.com>
Subject: Re: pg_stat_statements and "IN" conditions
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Smith <smithpb2250@gmail.com>, 
	vignesh C <vignesh21@gmail.com>, Michael Paquier <michael@paquier.xyz>, 
	Nathan Bossart <nathandbossart@gmail.com>, "Gregory Stark (as CFM)" <stark.cfm@gmail.com>, 
	David Geier <geidav.pg@gmail.com>, Sergei Kornilov <sk@zsrv.org>, 
	Alvaro Herrera <alvherre@alvh.no-ip.org>, Marcos Pegoraro <marcos@f10.com.br>, 
	Robert Haas <robertmhaas@gmail.com>, Zhihong Yu <zyu@yugabyte.com>, 
	David Steele <david@pgmasters.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>, 
	Pavel Trukhanov <pavel.trukhanov@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAKmOUTn74jTQAk0u2FUMsGjgrNugLOwkyic2MPkbOJtcQrufeA%40mail.gmail.com>
Precedence: bulk

Thanks for the information. I can apply these 4 patches from
0eb23285a2 . I tested this branch from Ruby on Rails and it gets some
unexpected behavior from my point of view.
Setting pg_stat_statements.query_id_const_merge_threshold =3D 5 does not
normalize sql queries whose number of in clauses exceeds 5.

Here are test steps.
https://gist.github.com/yahonda/825ffccc4dcb58aa60e12ce33d25cd45#expected-b=
ehavior

It would be appreciated if I can get my understanding correct.
--
Yasuo Honda

On Sun, Mar 24, 2024 at 3:20=E2=80=AFAM Dmitry Dolgov <9erthalion6@gmail.co=
m> wrote:

> Sure, I can rebase, give me a moment. If you don't want to wait, there
> is a base commit in the patch, against which it should be applied
> without issues, 0eb23285a2.