Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wB6VN-000jrv-36 for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 07:42:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wB6VM-00AQup-12 for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Apr 2026 07:42:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wB6VL-00AQtw-2s for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 07:42:16 +0000 Received: from mail-dy1-x1341.google.com ([2607:f8b0:4864:20::1341]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wB6VJ-00000000IMB-3R9B for pgsql-hackers@lists.postgresql.org; Fri, 10 Apr 2026 07:42:15 +0000 Received: by mail-dy1-x1341.google.com with SMTP id 5a478bee46e88-2d52c7f92b1so1079707eec.0 for ; Fri, 10 Apr 2026 00:42:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775806933; cv=none; d=google.com; s=arc-20240605; b=P6oS45PAM3xAFFxmUzqScyw0VvAkBsbEPhg7qSZAEbPLfUsFhMjFFLBvLUXdHx0GVr h20W1CKl03D15SscZjPtngg79RO+hXgZwTHFoq4uvS7l7cSk+w9aJmKORTseEjU0ZREj Sl9LdK+1UJ0ms1Q7n5meEnXtvZps0+rIAIhgmwSiUJSTUnaXVAU8KU9NXaXMbrMkSvuz Ayac16MJeFe4KKyMuPwEDL/vr1gfATFQ1JHAeak8IJ8p57bgLle2HH4QqEhViDAjS/ZX O/XWa2m5pAybEqF6gqKinRHFNVY1yHsHTOm4P88y0bq0Wgqb2bDBRVT/7Og11RCff5Vq vqjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=FQ8Mh8TzWOzWi0OGHbDh+pPIJxa0GHXBJV/gx55rqnw=; fh=SJLwFGdPtZLY7VbitLxurgfR/KErAEzsrNKdfS6uTcE=; b=ZGIwQlucfGq+9/KI2X2Ytkb9BOLRN1AYZhncdIjVBFsP+vY4u/qja5hdrQhdsr2tXL WOut52DoiDrGv163tYiUJZvicFu4Whjk+9ez5ilewTaMea1+MFZMLiL4LgItloOrHIbJ 5nsUf3H6jkrzB5KUXXfwFd53vdejqGBGnVbdWksrX1M8T9SezRV+0l932r2FXm/mipQ7 mcC4Za/Fx0t70yQyyGsaPKyGIQPAob1A8HovNaW5zf6Gld2IuYVNTuGU7S8m395seQb6 eFynfHb2q3gc6FmF0BI9L5Ze2QQInh1myfJ5cIzwNTQ7lJ+8TEGNpAXb4jr9tQt1D/oP aYlQ==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775806933; x=1776411733; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FQ8Mh8TzWOzWi0OGHbDh+pPIJxa0GHXBJV/gx55rqnw=; b=nlQ/e3viLXIzRh8AOyIDIyl1uVxhgtJJk3t3HCgRueYdeuFdbxeog+U3y7Oonl58WN b51LHiSZkJ1w0dpBznSpbj0GtAP1jlDZ8oZe0XLzIlgfk1d1cc+lvfIKOEz9Xaspms00 /9CLrydhfLXoMdepD4rnXkzODtzMJgo008S9nUBEMNV/jGj9s4GL0xpGEvCU+RjPx3aI AcawjNkYPe2TdXlkqr+/7WdYpfvBb/1ud2vBwIqCBNuGBzWXMG/cS0AHad2j2bWyFLBd pBwOzpBjshxXJugTm6Anf7Ms7d5UP56Jp9TVyBaugXlz4tCl7J+0EAL65opJoC15EPaj EwPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775806933; x=1776411733; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FQ8Mh8TzWOzWi0OGHbDh+pPIJxa0GHXBJV/gx55rqnw=; b=KrohcBCVGOBslEnvFKf4YWlkyqGSwwKB8ydWKx96swJB0y0GPYXYw20QbOx9KCqb2F 5gIyWcwgTCckqZpd5YiMk0JpWABXkSUdMs9XRz+K0K+JrWSYPcQqHSZntgQfVSYKDYKS rbljl7gGdSKuzEyxCF8VOIwOb+97YIO2LPXj9piHLJp2wP7vdrHDnQPj3YPo28Y7WDpK Bc1/P4K0ZWVlN1uJgPw2h36c/WdzmjQm9so1ThJM6c1cB6iDLLTIBPfb78w7gG4Olvt+ SyhKeBGGViq2kkU524dXDPqQf8XAWGP+r3GcPVHZwTsIZ4Ckjrg1z9y4lQ47dD+91/OK IUGg== X-Gm-Message-State: AOJu0Yx7srvcmJde8weiaxwUsG61E3jETYKn/aTYrjfcAAlbVPcJLk87 gczyNCNU842D5nMV67ncPrDZSxfVSX+hXaJXwqENxFnUCfCN63UgDgzsFxAhG7ba2GHkOKMasLf EkSOM4rG6FkPy8dr4L3rFmy+mL+9wCoM+vv6LtMs7glujiZw= X-Gm-Gg: AeBDieujiYZILP9gMTqnTJt76AAKFXpMJvC0hH46tXwedXuGTHsEdX3ZdkyxSpBz/m2 KTtlwboek22XivzEXL343eP3SAeBIrdpYnkrfiJhBnV7Ni/MroWegsYthJC2JC8p7Kyrikatzfg Jgvzh/DI5Eb9XyfXldHl4YLAFXNOs4s24GR0J/Wcqr6gz7RbNkkzHSWK8kaHcU/GqaqKBcDE2zC mew7OdsiynZeTqGD08EtojJqkGlM6uEBf8EeOE/FRYRDeRjmuJoQRBAO949Z6s6/AZg/iv3njz/ BgstnnQ= X-Received: by 2002:a05:7301:d16:b0:2c1:7fd3:4504 with SMTP id 5a478bee46e88-2d5870ad527mr1150588eec.3.1775806933234; Fri, 10 Apr 2026 00:42:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dapeng Wang Date: Fri, 10 Apr 2026 15:42:02 +0800 X-Gm-Features: AQROBzBa-Bx_P8hlmLuO64bOFrsvp8WcOw732R6gUfKtxQsOxH3uAln9Wdobd4o Message-ID: Subject: Re: Docs: Create table description for constraints markup fix and label tweaks To: "David G. Johnston" Cc: PostgreSQL Hackers Content-Type: multipart/alternative; boundary="00000000000071f707064f16452c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000071f707064f16452c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi David, I reviewed both patches on the latest HEAD. 0001: SGML nesting fix applied and verified - make html builds successfully with the corrected element nesting for UNIQUE and PRIMARY KEY. 0002: The six "variant" label changes look good and should help avoid the confusion reported on -general. Looks good to me. Regards, Dapeng Wang David G. Johnston =E4=BA=8E2026=E5=B9=B44=E6= =9C=8810=E6=97=A5=E5=91=A8=E4=BA=94 15:04=E5=86=99=E9=81=93=EF=BC=9A > On Fri, Apr 3, 2026 at 10:18=E2=80=AFAM David G. Johnston < > david.g.johnston@gmail.com> wrote: > >> Responding to a recent report on -general [1] I found a markup bug in th= e >> primary key description under create table. 0001 fixes this. >> >> The complaint itself was about using "column constraint" as a descriptiv= e >> label in a syntax area when "column constraint" is an actual defined syn= tax >> label. 0002 adds the word "variant" to the six places "(table/column >> constraint)" is used in this manner. >> >> [1] >> https://www.postgresql.org/message-id/CA+FnnTzeE30E4kfK4=3D+MLe4DBORu4Cd= YvPQgWUYakRxfwsbEtg@mail.gmail.com >> >> > The more you look (not having production dark mode in the core build is a > bit annoying)...v2 attached after re-reading the original thread and > looking around a bit more. > > Unique had the same sgml markup error as primary key. > > Also, the CF entry: https://commitfest.postgresql.org/patch/6648/ > > David J. > > P.S. Reviewing this we are inconsistent as to where we use "optional" > markup versus just literal [ ]. Even among these three locations there a= re > variances - and simply literals used for optional meaning brackets. > > --00000000000071f707064f16452c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi David,

I reviewed both patches on the latest HEA= D.

0001: SGML nesting fix applied and verified - make html
builds= successfully with the corrected element nesting
for UNIQUE and PRIMARY = KEY.

0002: The six "variant" label changes look good and s= hould
help avoid the confusion reported on -general.

Looks good t= o me.

Regards,
Dapeng Wang

David G. Johnston= <david.g.johnston@gmail.c= om> =E4=BA=8E2026=E5=B9=B44=E6=9C=8810=E6=97=A5=E5=91=A8=E4=BA=94 15= :04=E5=86=99=E9=81=93=EF=BC=9A
On Fri, Apr 3, 2026 at 10:18=E2=80=AFAM Dav= id G. Johnston <david.g.johnston@gmail.com> wrote:
Respondin= g to a recent report on -general [1] I found a markup bug in the primary ke= y description=C2=A0under create table.=C2=A0 0001 fixes this.

The complaint itself was about using &qu= ot;column constraint" as a descriptive label in a syntax area when &qu= ot;column constraint" is an actual defined syntax label.=C2=A0 0002 ad= ds the word "variant" to the six places "(table/column const= raint)" is used in this manner.



Th= e more you look (not having production dark mode in the core build is a bit= annoying)...v2 attached after re-reading the original thread and looking a= round a bit more.

Unique had the same sgml markup erro= r as primary key.

Also, the CF entry:=C2=A0https://co= mmitfest.postgresql.org/patch/6648/
=C2=A0
David J.

P.S. Reviewing this we are inconsistent as to where we us= e "optional" markup versus just literal [ ].=C2=A0 Even among the= se three locations there are variances - and simply literals used for optio= nal meaning brackets.

--00000000000071f707064f16452c--