MIME-Version: 1.0
References: 
 <CAKz==b+k7OwOib__LgfDadUzW9jFrbQ9FqdERpsufi8d7F=vkQ@mail.gmail.com>
 <CAHut+PuhDwEySMSMz_4hgmFNG75Wx=Wv4guuaUSGi6e3ixsUUw@mail.gmail.com>
 <CAKz==bLEjr+706MkmpHsd1wfz0EqYzEXJVb2cn2mxp2nnHf=kQ@mail.gmail.com>
 <CAFPTHDa-k7qV=H_UgojLs-denk8upJWG7s6xZwD4r4ZTP-=q5Q@mail.gmail.com>
In-Reply-To: 
 <CAFPTHDa-k7qV=H_UgojLs-denk8upJWG7s6xZwD4r4ZTP-=q5Q@mail.gmail.com>
From: Roberto Mello <roberto.mello@gmail.com>
Date: Fri, 27 Mar 2026 11:27:16 -0600
Message-ID: 
 <CAKz==bLYWG43n6J0Ze1Y5fgyrW32_73WQkNSPbWGmFwLE8Aa0A@mail.gmail.com>
Subject: Re: pg_publication_tables: return NULL attnames when no column list
 is specified
To: Ajin Cherian <itsajin@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000009080e8064e04d1c3"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKz%3D%3DbLYWG43n6J0Ze1Y5fgyrW32_73WQkNSPbWGmFwLE8Aa0A%40mail.gmail.com>
Precedence: bulk

--0000000000009080e8064e04d1c3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 26, 2026 at 10:07=E2=80=AFPM Ajin Cherian <itsajin@gmail.com> w=
rote:

>
> Tested the patch and the patch fixes the bug as described. My tests below=
:
>

Thank you for the review.

<snip>

One observation from reviewing the patch: the test suite covers the
> partial column list and dropped column cases well, but is missing a
> test for the two-publication conflict scenario (one pub with no list +
> one pub with an explicit list of all columns on the same table). That
> is the breaking change called out in the original report and probably
> deserves its own regression test with a comment explaining the
> expected behavior change for users in that configuration.
> Patch LGTM otherwise.
>

Good point. I know I worked on that, so I must have accidentally dropped it
from the patch.

Will prepare a revision and submit.

Thanks again.

Roberto Mello
Snowflake

P.S.: I forgot to acknowledge and thank Greg Mullane for the initial review
on the patch, so doing that now.

--0000000000009080e8064e04d1c3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Mar 26, 2026 at 10:07=E2=80=AFPM =
Ajin Cherian &lt;<a href=3D"mailto:itsajin@gmail.com">itsajin@gmail.com</a>=
&gt; wrote:</div><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><br>
Tested the patch and the patch fixes the bug as described. My tests below:<=
br></blockquote><div><br></div><div>Thank you for the review.=C2=A0</div><d=
iv><br></div><div>&lt;snip&gt;</div><div><br></div><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">
One observation from reviewing the patch: the test suite covers the<br>
partial column list and dropped column cases well, but is missing a<br>
test for the two-publication conflict scenario (one pub with no list +<br>
one pub with an explicit list of all columns on the same table). That<br>
is the breaking change called out in the original report and probably<br>
deserves its own regression test with a comment explaining the<br>
expected behavior change for users in that configuration.<br>
Patch LGTM otherwise.<br></blockquote><div><br></div><div>Good point. I kno=
w I worked on that, so I must have accidentally dropped it from the patch.<=
/div><div><br></div><div>Will prepare a revision and submit.</div><div><br>=
</div><div>Thanks again.</div><div><br></div><div>Roberto Mello</div><div>S=
nowflake</div><div><br></div><div>P.S.: I forgot to acknowledge and thank G=
reg Mullane for the initial review on the patch, so doing that now.</div></=
div></div>

--0000000000009080e8064e04d1c3--