Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDNSD-002u29-0H for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Apr 2026 14:12:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wDNSC-005mBA-0R for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Apr 2026 14:12:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wDNSB-005mB2-2n for pgsql-hackers@lists.postgresql.org; Thu, 16 Apr 2026 14:12:23 +0000 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wDNS9-00000001Pla-3H6p for pgsql-hackers@lists.postgresql.org; Thu, 16 Apr 2026 14:12:23 +0000 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-7b248750279so46054497b3.0 for ; Thu, 16 Apr 2026 07:12:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776348740; cv=none; d=google.com; s=arc-20240605; b=lmWpxPMUH0nLWxaa0ZmTMtlk1AsAX1xSUHfUD1YQV2egCVB0NEDL/aPEzg419sqPoo zqK+A+eyx9l0RVpodKSEh6LtmCjAmCXLKvHe3I9TJBy+1xmywvo2zyX/PsggMUPQX0CO cJcrWDK6Pqjw3HfpjhhWLWANBwP2SHF8JGHoshxJQuSHrMjzXmmF1+HvIJPlApAQHj/d 6Zh2u6Q8UUTlFiJabZpYkvQouusBO1wfxxmLO/tgdMZwBoOb6uSgL7B1nPKfigTIt1Kw abi6+TMTux+YPZkwK5POi+/bCGjAvkQWHFTORfUHcIZMpDE7JfETlJHyQbvYTCUvgiix 8C6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rtk29LU02to4VfHEldQp9zwr0EBLnl7PgLLtVlkK1Ss=; fh=/J4hFZCQkZ64L7JJjTjmPSQRcWyEDlZ024MBzSFptG0=; b=eBe4/DQT4fmD9DWHfZgtdciH3F1vavK79jOBzcmMpn4lRORVIFCSPgaJTeVb5c5Q7O N2xJZC5vt0CyJU0gl4cWnSDnfGUs4XKD7CVf3+0fY4WCIfv4r5+CYNrxAfRKBIviUiwK Gn+yb7JAN5LKJfskEEsjbKA+BD3RJROT5+D63Hjaw2m8d9JxQ/NjJyYGPr+mx/jcLskA hqH2jTcJ+W7yYLUbARaKHZqGHAioK1IFonlC9XyhguXVlBO4QOGkTYp2qt11EaRZ9jxW TNDgofweI2iH7+1MQTINaa5uNvfYMTFxji06Jn0u/G0wP8XDYsXpyb/bl4QYUYNb7T+8 X7nw==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776348740; x=1776953540; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rtk29LU02to4VfHEldQp9zwr0EBLnl7PgLLtVlkK1Ss=; b=Vj5xuSZqMMq0Wwb3qcI5KeYrsNAdqnRTmU+mkip2TjBRJdX3ELhh8dJYraGBLtbTq4 87yzs8FF01YUIeYC41YD7v+6eAzcyeUaSCSDKHYLE/L7yOo1sS40QBcgouieGeOHYAFS OOxD+MuemN4YuwedN9Pl38INBsX3krHIopA39HBLuf+eGYElMFIvNM2Bdl1vHcaRkSva F17yIaRJWZKoM/z0+c4wEW1EeRAtjQcPCh11QmmAQBeoF83OQJZxHnotN71Vk/d+2SIn 4P3sghFdUOtMbb1qGJ6igbfBoKUulCCjgysHjlbVUQbHroCzz5IMeEeCp3A2BA8UDwif yE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776348740; x=1776953540; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rtk29LU02to4VfHEldQp9zwr0EBLnl7PgLLtVlkK1Ss=; b=CJhEpOegR/e9wbq2wMnWmmyuKqukC3EFXkPJ9lN7DmHq5lTeuuDYPr7x4450Aonioo Y03Jxt/B/zeQBDW61PtV84JP7+UToYxzzTXvwXbEuzQI3nuBirJnbnkfcVKRYeR6mhPu A6KOy6W8yJzMbSa6NMtrp7fTxVByGb8fVZnE7NVJx7lwCbXe/9ZzbtdOzDoPH/FobkOC PYAGYxmzJN47z3/tOkNljzWfV0e8/wmIYY1U89TjOgpzpbttk4LeArnW34l6CbhVF91w W9sOwV+vv3s3YYmgrsQVJE/dz0KQ+DK3WaMhRrix91uUrciyr4Q+u5HI8wfDcASCSfyk QpaQ== X-Forwarded-Encrypted: i=1; AFNElJ9CnCek9BWv3ILpLcNgZjqRInMLmvifpJMzUCKBK9WArdDEmC4D+xiKbW/6vzyYnexqfblkEAoZIVxeXBb9@lists.postgresql.org X-Gm-Message-State: AOJu0YyLUGC9DGkO1us6IZJ1dzmdTnCke+3t4lacllN8tHhJsxvg0JJg AIJK+7wm2gAOZoSUPAbsJygojipcRueXO4/U8Yy3Fio9Myo+OjjYyhc+CRyhA24qhd3+hR2vAHl yTIoFVEsmsmxitXacwTTXF2E/nHfZXtQ= X-Gm-Gg: AeBDietx5yzi1Yr5op51tFm+jvfynSPKGzFSUZtEY5m1/EVak69bjl6ILhl5E/zyPMv KydW4+pAPz0J5JeLSIbQdUj2VtK5RM7HXnv8CWIpJxnHs4uewqInHjXGKdohUxIfy4s0+9W1Yjt JzPmGWf8LMifal4jYFk5A8vbtZO6nEvdS9JxDDKQllwrkIR0uGfszP5Twz79VHgP98w0Dw0RNEj L1ap2ZLFbj1nn27iFkKiqv8+zb6+/BBxAdMzgPAdZYI5Ys0wOaQwJ6uCz+VGFnUdIB0yNh/AgT5 u+8JX0b0vc0SaHqgkliIxpQJyAVH6135troD7bPU X-Received: by 2002:a05:690c:9:b0:7b2:7dc9:35f5 with SMTP id 00721157ae682-7b27dd88741mr198870537b3.41.1776348739321; Thu, 16 Apr 2026 07:12:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: vignesh C Date: Thu, 16 Apr 2026 19:42:07 +0530 X-Gm-Features: AQROBzDoO_2c-hiZ3Hb4oFbqkFI16Tio0VwRme8RsKC4qgbyVUyxROSxD8CdWW8 Message-ID: Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid To: Fujii Masao Cc: Amul Sul , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, 16 Apr 2026 at 19:36, Fujii Masao wrote: > > On Thu, Apr 16, 2026 at 9:31=E2=80=AFPM Amul Sul wrot= e: > > The outer parentheses do not seem to be needed, as > > XLogRecPtrIsInvalid() already includes them. > > > > Other than that, the v3 patch looks good to me. > > I've updated the patch based on Amul's suggestion and pushed it. Thanks! Thanks for pushing the patch. Regards, Vignesh