MIME-Version: 1.0
References: 
 <CAHut+PszSntkUgN+Qa9matGY6MLEoFGSuVbuKDgnnTdZ7YPRwg@mail.gmail.com>
 <74359511-9F84-481E-B133-D2F68775D1CE@gmail.com>
 <CAHut+PvAaR3h1wyGgO+761Oa_ywjFToX9AmKNnHhQX6e-N=k_w@mail.gmail.com>
 <CAHut+PtBNKnBVcidXbx4c-ifq44KRb+J4dCUh-2-2sccy0w3Pg@mail.gmail.com>
 <CAHut+Pt=M3AFJjSFHAzgvuxtuQJDnB38FPrA9EH3PsSvZkLcdw@mail.gmail.com>
In-Reply-To: 
 <CAHut+Pt=M3AFJjSFHAzgvuxtuQJDnB38FPrA9EH3PsSvZkLcdw@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Tue, 14 Apr 2026 11:21:40 +0530
Message-ID: 
 <CALDaNm06akDhu1RVVRhYuSXPT-TsWZyCOSci8tFCOvfiYaP4AQ@mail.gmail.com>
Subject: Re: Add missing period to DETAIL messages
To: Peter Smith <smithpb2250@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm06akDhu1RVVRhYuSXPT-TsWZyCOSci8tFCOvfiYaP4AQ%40mail.gmail.com>
Precedence: bulk

On Mon, 13 Apr 2026 at 06:36, Peter Smith <smithpb2250@gmail.com> wrote:
>
> (here's the missing attachment)
>
> On Mon, Apr 13, 2026 at 11:04=E2=80=AFAM Peter Smith <smithpb2250@gmail.c=
om> wrote:
> >
> > Found one more oversight.
> >
> > PSA v3.

Should these also be updated:
1) ginfuncs.c
if (opaq->flags !=3D (GIN_DATA | GIN_LEAF | GIN_COMPRESSED))
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("input page is not a compressed GIN data leaf page"),
errdetail("Flags %04X, expected %04X",
   opaq->flags,
   (GIN_DATA | GIN_LEAF | GIN_COMPRESSED))));

2) shell_archive.c
ereport(lev,
(errmsg("archive command failed with exit code %d",
WEXITSTATUS(rc)),
errdetail("The failed archive command was: %s",
   xlogarchcmd)));

3) shell_archive.c
ereport(lev,
(errmsg("archive command was terminated by exception 0x%X",
WTERMSIG(rc)),
errhint("See C include file \"ntstatus.h\" for a description of the
hexadecimal value."),
errdetail("The failed archive command was: %s",
   xlogarchcmd)));

4) shell_archive.c
ereport(lev,
(errmsg("archive command was terminated by signal %d: %s",
WTERMSIG(rc), pg_strsignal(WTERMSIG(rc))),
errdetail("The failed archive command was: %s",
   xlogarchcmd)));

5) shell_archive.c
ereport(lev,
(errmsg("archive command exited with unrecognized status %d",
rc),
errdetail("The failed archive command was: %s",
   xlogarchcmd)));

6) matview.c
ereport(ERROR,
(errcode(ERRCODE_CARDINALITY_VIOLATION),
errmsg("new data for materialized view \"%s\" contains duplicate rows
without any null columns",
RelationGetRelationName(matviewRel)),
errdetail("Row: %s",
   SPI_getvalue(SPI_tuptable->vals[0], SPI_tuptable->tupdesc, 1))));

Regards,
Vignesh