MIME-Version: 1.0
References: 
 <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
 <CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
 <CALDaNm0zJuUon52OEx5SpMoP8LEGJh+=PyYqwmcD7Zh97_dnJg@mail.gmail.com>
 <CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Thu, 16 Apr 2026 16:25:31 +0530
Message-ID: 
 <CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000008abd69064f91ac5a"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r%2BP4GaWnac%3Dg%40mail.gmail.com>
Precedence: bulk

--0000000000008abd69064f91ac5a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 16 Apr 2026 at 09:42, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Mon, Apr 13, 2026 at 4:10=E2=80=AFPM vignesh C <vignesh21@gmail.com> w=
rote:
> > I felt these also should be updated, the attached v2 version patch
> > includes the changes for the same.
>
> Thanks for updating the patch!
>
> -       applyPtr =3D (latestApplyPtr =3D=3D InvalidXLogRecPtr) ?
> +       applyPtr =3D (XLogRecPtrIsInvalid(latestApplyPtr)) ?
>
> XLogRecPtrIsValid() should be used here, instead?

Yes, that seems better, the attached v3 version patch has the changes
for the same.

Regards,
Vignesh

--0000000000008abd69064f91ac5a
Content-Type: application/octet-stream;
	name="v3-0001-Use-XLogRecPtr-validity-helper-macros-consistentl.patch"
Content-Disposition: attachment;
	filename="v3-0001-Use-XLogRecPtr-validity-helper-macros-consistentl.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo1d4g7k0>
X-Attachment-Id: f_mo1d4g7k0

RnJvbSA0ZGEyMzM4MjY4ZjBjNzUyNGEyZmY5NmMxMmM1OTg1MTJiM2UwMTljIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWduZXNoIEMgPHZpZ25lc2gyMUBnbWFpbC5jb20+CkRhdGU6
IEZyaSwgMTAgQXByIDIwMjYgMTA6MTI6MzggKzA1MzAKU3ViamVjdDogW1BBVENIIHYzXSBVc2Ug
WExvZ1JlY1B0ciB2YWxpZGl0eSBoZWxwZXIgbWFjcm9zIGNvbnNpc3RlbnRseQoKUmVwbGFjZSBk
aXJlY3QgY29tcGFyaXNvbnMgYWdhaW5zdCBJbnZhbGlkWExvZ1JlY1B0ciBhbmQgbmVnYXRlZApY
TG9nUmVjUHRySXNJbnZhbGlkKCkgY2hlY2tzIHdpdGggdGhlIGNvcnJlc3BvbmRpbmcKWExvZ1Jl
Y1B0cklzVmFsaWQoKS9YTG9nUmVjUHRySXNJbnZhbGlkKCkgaGVscGVyIG1hY3Jvcy4KClRoaXMg
aW1wcm92ZXMgcmVhZGFiaWxpdHkgYW5kIGNvbnNpc3RlbmN5IGJ5IHVzaW5nIHRoZSBkZWRpY2F0
ZWQKWExvZ1JlY1B0ciB2YWxpZGl0eSBoZWxwZXJzIHRocm91Z2hvdXQgdGhlIGNvZGUsIHdpdGgg
bm8gaW50ZW5kZWQKYmVoYXZpb3JhbCBjaGFuZ2UuCi0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMv
cmVwYWNrX3dvcmtlci5jICB8IDIgKy0KIHNyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3dhbHJlY2Vp
dmVyLmMgfCA0ICsrLS0KIHNyYy9iaW4vcGdfd2FsZHVtcC9hcmNoaXZlX3dhbGR1bXAuYyAgfCA0
ICsrLS0KIDMgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoK
ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3JlcGFja193b3JrZXIuYyBiL3NyYy9i
YWNrZW5kL2NvbW1hbmRzL3JlcGFja193b3JrZXIuYwppbmRleCA1YmQwMjBlMDE4NC4uMzYyZTA3
NjZjNDEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3JlcGFja193b3JrZXIuYwor
KysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9yZXBhY2tfd29ya2VyLmMKQEAgLTI2OCw3ICsyNjgs
NyBAQCByZXBhY2tfc2V0dXBfbG9naWNhbF9kZWNvZGluZyhPaWQgcmVsaWQpCiAJY3R4LT5yZWFk
ZXItPnJvdXRpbmUucGFnZV9yZWFkID0gcmVhZF9sb2NhbF94bG9nX3BhZ2Vfbm9fd2FpdDsKIAog
CS8qIFNvbWUgV0FMIHJlY29yZHMgc2hvdWxkIGhhdmUgYmVlbiByZWFkLiAqLwotCUFzc2VydChj
dHgtPnJlYWRlci0+RW5kUmVjUHRyICE9IEludmFsaWRYTG9nUmVjUHRyKTsKKwlBc3NlcnQoWExv
Z1JlY1B0cklzVmFsaWQoY3R4LT5yZWFkZXItPkVuZFJlY1B0cikpOwogCiAJLyoKIAkgKiBJbml0
aWFsaXplIHJlcGFja19jdXJyZW50X3NlZ21lbnQgc28gdGhhdCB3ZSBjYW4gbm90aWNlIFdBTCBz
ZWdtZW50CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi93YWxyZWNlaXZlci5j
IGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vd2FscmVjZWl2ZXIuYwppbmRleCA1ZWU2NDMxMDkx
ZS4uNWVhYjg3NjI1ZGIgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3dhbHJl
Y2VpdmVyLmMKKysrIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vd2FscmVjZWl2ZXIuYwpAQCAt
MTE2OSw4ICsxMTY5LDggQEAgWExvZ1dhbFJjdlNlbmRSZXBseShib29sIGZvcmNlLCBib29sIHJl
cXVlc3RSZXBseSwgYm9vbCBjaGVja0FwcGx5KQogCS8qIENvbnN0cnVjdCBhIG5ldyBtZXNzYWdl
ICovCiAJd3JpdGVQdHIgPSBMb2dzdHJlYW1SZXN1bHQuV3JpdGU7CiAJZmx1c2hQdHIgPSBMb2dz
dHJlYW1SZXN1bHQuRmx1c2g7Ci0JYXBwbHlQdHIgPSAobGF0ZXN0QXBwbHlQdHIgPT0gSW52YWxp
ZFhMb2dSZWNQdHIpID8KLQkJR2V0WExvZ1JlcGxheVJlY1B0cihOVUxMKSA6IGxhdGVzdEFwcGx5
UHRyOworCWFwcGx5UHRyID0gKFhMb2dSZWNQdHJJc1ZhbGlkKGxhdGVzdEFwcGx5UHRyKSkgPwor
CQlsYXRlc3RBcHBseVB0ciA6IEdldFhMb2dSZXBsYXlSZWNQdHIoTlVMTCk7CiAKIAlyZXNldFN0
cmluZ0luZm8oJnJlcGx5X21lc3NhZ2UpOwogCXBxX3NlbmRieXRlKCZyZXBseV9tZXNzYWdlLCBQ
cVJlcGxNc2dfU3RhbmRieVN0YXR1c1VwZGF0ZSk7CmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX3dh
bGR1bXAvYXJjaGl2ZV93YWxkdW1wLmMgYi9zcmMvYmluL3BnX3dhbGR1bXAvYXJjaGl2ZV93YWxk
dW1wLmMKaW5kZXggNzhiMDNiYzFmODUuLjc5OTE1YzBhMGNlIDEwMDY0NAotLS0gYS9zcmMvYmlu
L3BnX3dhbGR1bXAvYXJjaGl2ZV93YWxkdW1wLmMKKysrIGIvc3JjL2Jpbi9wZ193YWxkdW1wL2Fy
Y2hpdmVfd2FsZHVtcC5jCkBAIC0yMTYsMTEgKzIxNiwxMSBAQCBpbml0X2FyY2hpdmVfcmVhZGVy
KFhMb2dEdW1wUHJpdmF0ZSAqcHJpdmF0ZUluZm8sCiAJICogV2l0aCB0aGUgV0FMIHNlZ21lbnQg
c2l6ZSBhdmFpbGFibGUsIHdlIGNhbiBub3cgaW5pdGlhbGl6ZSB0aGUKIAkgKiBkZXBlbmRlbnQg
c3RhcnQgYW5kIGVuZCBzZWdtZW50IG51bWJlcnMuCiAJICovCi0JQXNzZXJ0KCFYTG9nUmVjUHRy
SXNJbnZhbGlkKHByaXZhdGVJbmZvLT5zdGFydHB0cikpOworCUFzc2VydChYTG9nUmVjUHRySXNW
YWxpZChwcml2YXRlSW5mby0+c3RhcnRwdHIpKTsKIAlYTEJ5dGVUb1NlZyhwcml2YXRlSW5mby0+
c3RhcnRwdHIsIHByaXZhdGVJbmZvLT5zdGFydF9zZWdubywKIAkJCQlwcml2YXRlSW5mby0+c2Vn
c2l6ZSk7CiAKLQlpZiAoIVhMb2dSZWNQdHJJc0ludmFsaWQocHJpdmF0ZUluZm8tPmVuZHB0cikp
CisJaWYgKFhMb2dSZWNQdHJJc1ZhbGlkKHByaXZhdGVJbmZvLT5lbmRwdHIpKQogCQlYTEJ5dGVU
b1NlZyhwcml2YXRlSW5mby0+ZW5kcHRyLCBwcml2YXRlSW5mby0+ZW5kX3NlZ25vLAogCQkJCQlw
cml2YXRlSW5mby0+c2Vnc2l6ZSk7CiAKLS0gCjIuNDMuMAoK
--0000000000008abd69064f91ac5a--