public inbox for [email protected]  

help / color / mirror / Atom feed

From: vignesh C <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: Adding a pg_get_owned_sequence function?
Date: Mon, 8 Jan 2024 10:54:39 +0530
Message-ID: <CALDaNm0_nn-LXSJCXQ6EYiGKjVO8fVO8AemgEVZFQPPdx0=fkg@mail.gmail.com> (raw)
In-Reply-To: <20231024162929.GA871220@nathanxps13>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<20231024162929.GA871220@nathanxps13>

On Tue, 24 Oct 2023 at 22:00, Nathan Bossart <[email protected]> wrote:
>
> On Tue, Sep 12, 2023 at 03:53:28PM +0100, Dagfinn Ilmari Mannsåker wrote:
> > Tom Lane <[email protected]> writes:
> >> It's possible that we could get away with just summarily changing
> >> the argument type from text to regclass.  ISTR that we did exactly
> >> that with nextval() years ago, and didn't get too much push-back.
> >> But we couldn't do the same for the return type.  Also, this
> >> approach does nothing for the concern about the name being
> >> misleading.
> >
> > Maybe we should go all the way the other way, and call it
> > pg_get_identity_sequence() and claim that "serial" is a legacy form of
> > identity columns?
>
> Hm.  Could we split it into two functions, pg_get_owned_sequence() and
> pg_get_identity_sequence()?  I see that commit 3012061 [0] added support
> for identity columns to pg_get_serial_sequence() because folks expected
> that to work, so maybe that's a good reason to keep them together.  If we
> do elect to keep them combined, I'd be okay with renaming it to
> pg_get_identity_sequence() along with your other proposed changes.

I have changed the status of the patch to "Waiting on Author" as
Nathan's comments have not yet been followed up.

Regards,
Vignesh

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Adding a pg_get_owned_sequence function?
  In-Reply-To: <CALDaNm0_nn-LXSJCXQ6EYiGKjVO8fVO8AemgEVZFQPPdx0=fkg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox