public inbox for [email protected]  

help / color / mirror / Atom feed

From: vignesh C <[email protected]>
To: [email protected] <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Mark Dilger <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Smith, Peter <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Optionally automatically disable logical replication subscriptions on error
Date: Mon, 8 Nov 2021 18:44:34 +0530
Message-ID: <CALDaNm0bXsyrXg3dQGbAhkUDGKnFXtM6mKk8d-8VFLo6wz3ZJA@mail.gmail.com> (raw)
In-Reply-To: <TYCPR01MB837384DA6C879A709EBF30D1ED8B9@TYCPR01MB8373.jpnprd01.prod.outlook.com>
References: <[email protected]>
	<CAA4eK1KkhsNAW3=XxOdVRD9+RcQG5PRRFBFzAMibMG0YFFmAmg@mail.gmail.com>
	<[email protected]>
	<CAA4eK1KM23D06_rUEsgnTFUpABoeCCoTun2TMrQzWgxWOYY7fA@mail.gmail.com>
	<[email protected]>
	<CAD21AoB+QH4or-QDiakALZp6pkXiAaGxfGcsvNYJoDHk9kknZw@mail.gmail.com>
	<[email protected]>
	<CAD21AoCPSU-MBHkortBnELO7Hu0tLsX5GoOEbSYzyxKBPkKvBg@mail.gmail.com>
	<TYCPR01MB837384DA6C879A709EBF30D1ED8B9@TYCPR01MB8373.jpnprd01.prod.outlook.com>

On Tue, Nov 2, 2021 at 4:12 PM [email protected]
<[email protected]> wrote:
>
> On Monday, June 28, 2021 1:47 PM Masahiko Sawada <[email protected]> wrote:
> > On Mon, Jun 21, 2021 at 11:26 AM Mark Dilger
> > <[email protected]> wrote:
> > > > On Jun 20, 2021, at 7:17 PM, Masahiko Sawada
> > <[email protected]> wrote:
> > > >
> > > > I will submit the patch.
> > >
> > > Great, thanks!
> >
> > I've submitted the patches on that thread[1]. There are three patches:
> > skipping the transaction on the subscriber side, reporting error details in the
> > errcontext, and reporting the error details to the stats collector. Feedback is
> > very welcome.
> >
> > [1]
> > https://www.postgresql.org/message-id/CAD21AoBU4jGEO6AXcykQ9y7tat0R
> > rB5--8ZoJgfcj%2BLPs7nFZQ%40mail.gmail.com
> Hi, thanks Sawada-san for keep updating the skip xid patch in the thread.
>
> This thread has stopped since the patch submission.
> I've rebased the 'disable_on_error' option
> so that it can be applied on top of skip xid shared in [1].
> I've written Mark Dilger as the original author in the commit message.
>
> This patch is simply rebased to reactive this thread.
> So there are still pending item to discuss for example,
> how we should deal with multiple errors of several table sync workers.
>
> I extracted only 'disable_on_error' option
> because the skip xid and the latest error message fulfill the motivation
> to make it easy to write TAP tests already I felt.
>

Thanks for the updated patch. Please create a Commitfest entry for
this. It will help to have a look at CFBot results for the patch, also
if required rebase and post a patch on top of Head.

Regards,
Vignesh

view thread (74+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Optionally automatically disable logical replication subscriptions on error
  In-Reply-To: <CALDaNm0bXsyrXg3dQGbAhkUDGKnFXtM6mKk8d-8VFLo6wz3ZJA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox