public inbox for [email protected]
help / color / mirror / Atom feedFrom: vignesh C <[email protected]>
To: Sergey Tatarintsev <[email protected]>
Cc: Shlok Kyal <[email protected]>
Cc: [email protected]
Subject: Re: Restrict publishing of partitioned table with a foreign table as partition
Date: Tue, 4 Feb 2025 18:16:24 +0530
Message-ID: <CALDaNm0sYZN+E5A9Br3JEBkdWL9t7obSFtNa5_n7h=jokWoB5A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CANhcyEWTNKm-ewnOVL9EB4MA-Zbt8BP1rmuXtD=TVHKmXL3xGA@mail.gmail.com>
<[email protected]>
<CANhcyEWmD18iRFE_aatDoT3tuUEHG6-__BtUaHktiTR4Rey=vQ@mail.gmail.com>
<[email protected]>
On Fri, 31 Jan 2025 at 10:38, Sergey Tatarintsev
<[email protected]> wrote:
>
> Ok, but maybe it will be correct to raise an WARNING (or at least LOG)
> that some tables was skipped during publication. What do you think?
>
> And I think we need check tables which was really published in case of
> 'FOR ALL TABLES' and 'FOR TABLES IN SCHEMA' in our tests. See attach.
>
> Also it looks strange - we raise an ERROR for partitioned tables
> containing foreign partitions , but just skip foreign tables as itself.
> I think there should be the same behavior in both cases - raise an ERROR
> or skip.
I believe this behavior is acceptable. We should throw an error for
partitioned tables that contain foreign partitions, as this would
include the data from these foreign tables during the initial sync,
while incremental changes would not be replicated. However, in the
case of foreign tables, neither the initial sync nor the incremental
sync will occur. Additionally, it is documented in [1] that foreign
tables are not supported, so this behavior is in line with the
documentation and is acceptable.
[1] - https://www.postgresql.org/docs/current/logical-replication-restrictions.html
Regards,
Vignesh
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Restrict publishing of partitioned table with a foreign table as partition
In-Reply-To: <CALDaNm0sYZN+E5A9Br3JEBkdWL9t7obSFtNa5_n7h=jokWoB5A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox