MIME-Version: 1.0
References: 
 <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
 <CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Mon, 13 Apr 2026 12:40:06 +0530
Message-ID: 
 <CALDaNm0zJuUon52OEx5SpMoP8LEGJh+=PyYqwmcD7Zh97_dnJg@mail.gmail.com>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000d54b94064f522cbd"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm0zJuUon52OEx5SpMoP8LEGJh%2B%3DPyYqwmcD7Zh97_dnJg%40mail.gmail.com>
Precedence: bulk

--000000000000d54b94064f522cbd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 10 Apr 2026 at 20:16, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Fri, Apr 10, 2026 at 3:11=E2=80=AFPM vignesh C <vignesh21@gmail.com> w=
rote:
> >
> > Hi,
> >
> > This small cleanup patch updates src/bin/pg_waldump/archive_waldump.c
> > to use the recently introduced XLogRecPtrIsValid() helper instead of
> > negating XLogRecPtrIsInvalid(). The current code uses double-negative
> > checks such as:
> > Assert(!XLogRecPtrIsInvalid(privateInfo->startptr));
> > if (!XLogRecPtrIsInvalid(privateInfo->endptr))
> >
> > This patch changes them to:
> > Assert(XLogRecPtrIsValid(privateInfo->startptr));
> > if (XLogRecPtrIsValid(privateInfo->endptr))
> >
> > This improves readability without changing behavior. The attached
> > patch has the changes for the same.
>
> Commit a2b02293bc6 switched various places to use XLogRecPtrIsValid(),
> but it looks like later commits accidentally introduced uses of
> XLogRecPtrIsInvalid() again. So +1 for this change.
>
> Also, that commit replaced direct comparisons with InvalidXLogRecPtr with
> XLogRecPtrIsValid(). I noticed two such comparisons [1]. Should these be
> updated as well?

I felt these also should be updated, the attached v2 version patch
includes the changes for the same.

Regards,
Vignesh

--000000000000d54b94064f522cbd
Content-Type: application/octet-stream;
	name="v2-0001-Use-XLogRecPtr-validity-helper-macros-consistentl.patch"
Content-Disposition: attachment;
	filename="v2-0001-Use-XLogRecPtr-validity-helper-macros-consistentl.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnwuqubx0>
X-Attachment-Id: f_mnwuqubx0

RnJvbSBhMGZkMWY2MDQ5MWEzMTVjNzQ1ODQ2OGE4MTU3YTZmNzlkZDM4NGRlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWduZXNoIEMgPHZpZ25lc2gyMUBnbWFpbC5jb20+CkRhdGU6
IEZyaSwgMTAgQXByIDIwMjYgMTA6MTI6MzggKzA1MzAKU3ViamVjdDogW1BBVENIIHYyXSBVc2Ug
WExvZ1JlY1B0ciB2YWxpZGl0eSBoZWxwZXIgbWFjcm9zIGNvbnNpc3RlbnRseQoKUmVwbGFjZSBk
aXJlY3QgY29tcGFyaXNvbnMgYWdhaW5zdCBJbnZhbGlkWExvZ1JlY1B0ciBhbmQgbmVnYXRlZApY
TG9nUmVjUHRySXNJbnZhbGlkKCkgY2hlY2tzIHdpdGggdGhlIGNvcnJlc3BvbmRpbmcKWExvZ1Jl
Y1B0cklzVmFsaWQoKS9YTG9nUmVjUHRySXNJbnZhbGlkKCkgaGVscGVyIG1hY3Jvcy4KClRoaXMg
aW1wcm92ZXMgcmVhZGFiaWxpdHkgYW5kIGNvbnNpc3RlbmN5IGJ5IHVzaW5nIHRoZSBkZWRpY2F0
ZWQKWExvZ1JlY1B0ciB2YWxpZGl0eSBoZWxwZXJzIHRocm91Z2hvdXQgdGhlIGNvZGUsIHdpdGgg
bm8gaW50ZW5kZWQKYmVoYXZpb3JhbCBjaGFuZ2UuCi0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMv
cmVwYWNrX3dvcmtlci5jICB8IDIgKy0KIHNyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3dhbHJlY2Vp
dmVyLmMgfCAyICstCiBzcmMvYmluL3BnX3dhbGR1bXAvYXJjaGl2ZV93YWxkdW1wLmMgIHwgNCAr
Ky0tCiAzIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRp
ZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21tYW5kcy9yZXBhY2tfd29ya2VyLmMgYi9zcmMvYmFj
a2VuZC9jb21tYW5kcy9yZXBhY2tfd29ya2VyLmMKaW5kZXggNWJkMDIwZTAxODQuLjM2MmUwNzY2
YzQxIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy9yZXBhY2tfd29ya2VyLmMKKysr
IGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvcmVwYWNrX3dvcmtlci5jCkBAIC0yNjgsNyArMjY4LDcg
QEAgcmVwYWNrX3NldHVwX2xvZ2ljYWxfZGVjb2RpbmcoT2lkIHJlbGlkKQogCWN0eC0+cmVhZGVy
LT5yb3V0aW5lLnBhZ2VfcmVhZCA9IHJlYWRfbG9jYWxfeGxvZ19wYWdlX25vX3dhaXQ7CiAKIAkv
KiBTb21lIFdBTCByZWNvcmRzIHNob3VsZCBoYXZlIGJlZW4gcmVhZC4gKi8KLQlBc3NlcnQoY3R4
LT5yZWFkZXItPkVuZFJlY1B0ciAhPSBJbnZhbGlkWExvZ1JlY1B0cik7CisJQXNzZXJ0KFhMb2dS
ZWNQdHJJc1ZhbGlkKGN0eC0+cmVhZGVyLT5FbmRSZWNQdHIpKTsKIAogCS8qCiAJICogSW5pdGlh
bGl6ZSByZXBhY2tfY3VycmVudF9zZWdtZW50IHNvIHRoYXQgd2UgY2FuIG5vdGljZSBXQUwgc2Vn
bWVudApkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vd2FscmVjZWl2ZXIuYyBi
L3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3dhbHJlY2VpdmVyLmMKaW5kZXggMDlmZGU5MmJmZDcu
LjAxMzYyZmQzZTk1IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi93YWxyZWNl
aXZlci5jCisrKyBiL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3dhbHJlY2VpdmVyLmMKQEAgLTEx
NjksNyArMTE2OSw3IEBAIFhMb2dXYWxSY3ZTZW5kUmVwbHkoYm9vbCBmb3JjZSwgYm9vbCByZXF1
ZXN0UmVwbHksIGJvb2wgY2hlY2tBcHBseSkKIAkvKiBDb25zdHJ1Y3QgYSBuZXcgbWVzc2FnZSAq
LwogCXdyaXRlUHRyID0gTG9nc3RyZWFtUmVzdWx0LldyaXRlOwogCWZsdXNoUHRyID0gTG9nc3Ry
ZWFtUmVzdWx0LkZsdXNoOwotCWFwcGx5UHRyID0gKGxhdGVzdEFwcGx5UHRyID09IEludmFsaWRY
TG9nUmVjUHRyKSA/CisJYXBwbHlQdHIgPSAoWExvZ1JlY1B0cklzSW52YWxpZChsYXRlc3RBcHBs
eVB0cikpID8KIAkJR2V0WExvZ1JlcGxheVJlY1B0cihOVUxMKSA6IGxhdGVzdEFwcGx5UHRyOwog
CiAJcmVzZXRTdHJpbmdJbmZvKCZyZXBseV9tZXNzYWdlKTsKZGlmZiAtLWdpdCBhL3NyYy9iaW4v
cGdfd2FsZHVtcC9hcmNoaXZlX3dhbGR1bXAuYyBiL3NyYy9iaW4vcGdfd2FsZHVtcC9hcmNoaXZl
X3dhbGR1bXAuYwppbmRleCA3OGIwM2JjMWY4NS4uNzk5MTVjMGEwY2UgMTAwNjQ0Ci0tLSBhL3Ny
Yy9iaW4vcGdfd2FsZHVtcC9hcmNoaXZlX3dhbGR1bXAuYworKysgYi9zcmMvYmluL3BnX3dhbGR1
bXAvYXJjaGl2ZV93YWxkdW1wLmMKQEAgLTIxNiwxMSArMjE2LDExIEBAIGluaXRfYXJjaGl2ZV9y
ZWFkZXIoWExvZ0R1bXBQcml2YXRlICpwcml2YXRlSW5mbywKIAkgKiBXaXRoIHRoZSBXQUwgc2Vn
bWVudCBzaXplIGF2YWlsYWJsZSwgd2UgY2FuIG5vdyBpbml0aWFsaXplIHRoZQogCSAqIGRlcGVu
ZGVudCBzdGFydCBhbmQgZW5kIHNlZ21lbnQgbnVtYmVycy4KIAkgKi8KLQlBc3NlcnQoIVhMb2dS
ZWNQdHJJc0ludmFsaWQocHJpdmF0ZUluZm8tPnN0YXJ0cHRyKSk7CisJQXNzZXJ0KFhMb2dSZWNQ
dHJJc1ZhbGlkKHByaXZhdGVJbmZvLT5zdGFydHB0cikpOwogCVhMQnl0ZVRvU2VnKHByaXZhdGVJ
bmZvLT5zdGFydHB0ciwgcHJpdmF0ZUluZm8tPnN0YXJ0X3NlZ25vLAogCQkJCXByaXZhdGVJbmZv
LT5zZWdzaXplKTsKIAotCWlmICghWExvZ1JlY1B0cklzSW52YWxpZChwcml2YXRlSW5mby0+ZW5k
cHRyKSkKKwlpZiAoWExvZ1JlY1B0cklzVmFsaWQocHJpdmF0ZUluZm8tPmVuZHB0cikpCiAJCVhM
Qnl0ZVRvU2VnKHByaXZhdGVJbmZvLT5lbmRwdHIsIHByaXZhdGVJbmZvLT5lbmRfc2Vnbm8sCiAJ
CQkJCXByaXZhdGVJbmZvLT5zZWdzaXplKTsKIAotLSAKMi40My4wCgo=
--000000000000d54b94064f522cbd--