MIME-Version: 1.0
From: vignesh C <vignesh21@gmail.com>
Date: Wed, 15 Apr 2026 18:42:47 +0530
Message-ID: 
 <CALDaNm1-Fx6Msw6zcRuSjgQdw6asdTyp2DwP-4TCKGYAT+ndsA@mail.gmail.com>
Subject: Fix tab completion after EXCEPT (...) in IMPORT FOREIGN SCHEMA
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000949344064f7f7912"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm1-Fx6Msw6zcRuSjgQdw6asdTyp2DwP-4TCKGYAT%2BndsA%40mail.gmail.com>
Precedence: bulk

--000000000000949344064f7f7912
Content-Type: text/plain; charset="UTF-8"

Hi all,

While reviewing tab completion behavior, I noticed an issue after
EXCEPT (...) support was added to CREATE PUBLICATION.
Currently, after typing:
IMPORT FOREIGN SCHEMA public EXCEPT (t1)

psql correctly suggests FROM SERVER. However, the existing completion
rule uses a generic:
TailMatches("EXCEPT", "(*)")

Previously this was safe because no other command used EXCEPT (...).
Now that CREATE PUBLICATION also supports EXCEPT (...), the same rule
can incorrectly match publication commands and suggest FROM SERVER
there as well.

The attached patch fixes this by restricting the EXCEPT (...) path to
IMPORT FOREIGN SCHEMA using HeadMatches(), while preserving the
existing LIMIT TO (...) behavior.

Regards,
Vignesh

--000000000000949344064f7f7912
Content-Type: application/octet-stream;
	name="0001-Fix-tab-completion-after-EXCEPT-in-IMPORT-FOREIGN-SC.patch"
Content-Disposition: attachment;
	filename="0001-Fix-tab-completion-after-EXCEPT-in-IMPORT-FOREIGN-SC.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo02jlem0>
X-Attachment-Id: f_mo02jlem0

RnJvbSAwNTU4YWVhYWQ2YjAxODgwNGFhY2Y2MGVmMDBiYjRkYzNhZDYyZTdlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWduZXNoIEMgPHZpZ25lc2gyMUBnbWFpbC5jb20+CkRhdGU6
IFdlZCwgMTUgQXByIDIwMjYgMTg6MzA6MDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBGaXggdGFi
IGNvbXBsZXRpb24gYWZ0ZXIgRVhDRVBUKCkgaW4gSU1QT1JUIEZPUkVJR04gU0NIRU1BCgpUYWIg
Y29tcGxldGlvbiBmb3IgSU1QT1JUIEZPUkVJR04gU0NIRU1BIGluY29ycmVjdGx5IHN1Z2dlc3Rl
ZCBGUk9NClNFUlZFUiBhZnRlciBFWENFUFQgKC4uLiksIGJlY2F1c2UgRVhDRVBUICguLi4pIGlz
IG5vdyBhbHNvIHZhbGlkIGluCkNSRUFURSBhbmQgQUxURVIgUFVCTElDQVRJT04uCgpQcmV2aW91
c2x5LCB0aGUgZ2VuZXJpYyBUYWlsTWF0Y2hlcygiRVhDRVBUIiwgIigqKSIpIGNoZWNrIHdhcyBz
YWZlCmJlY2F1c2Ugbm8gb3RoZXIgY29tbWFuZCB1c2VkICdFWENFUFQgKC4uLiknLiBBZnRlciBh
ZGRpbmcgc3VwcG9ydCBmb3IKJ0VYQ0VQVCAoLi4uKScgaW4gcHVibGljYXRpb24gY29tbWFuZHMs
IHRoZSBzYW1lIGNvbXBsZXRpb24gcnVsZSBzdGFydGVkCm1hdGNoaW5nIHVucmVsYXRlZCBzdGF0
ZW1lbnRzIGFuZCBpbmNvcnJlY3RseSBvZmZlcmVkICdGUk9NIFNFUlZFUicKdGhlcmUgYXMgd2Vs
bC4KCkZpeCB0aGlzIGJ5IHJlc3RyaWN0aW5nIHRoZSAnRVhDRVBUICguLi4pJyBjb21wbGV0aW9u
IHBhdGggdG8KJ0lNUE9SVCBGT1JFSUdOIFNDSEVNQScgdXNpbmcgSGVhZE1hdGNoZXMoKSwgd2hp
bGUga2VlcGluZyB0aGUKZXhpc3RpbmcgJ0xJTUlUIFRPICguLi4pJyBiZWhhdmlvciB1bmNoYW5n
ZWQuCgpUaGlzIGVuc3VyZXMgJ0ZST00gU0VSVkVSJyBpcyBzdWdnZXN0ZWQgb25seSBmb3IgdmFs
aWQKJ0lNUE9SVCBGT1JFSUdOIFNDSEVNQScgc3ludGF4LgotLS0KIHNyYy9iaW4vcHNxbC90YWIt
Y29tcGxldGUuaW4uYyB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwg
MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4u
YyBiL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4uYwppbmRleCA5OTkwZjgxODk0Mi4uODg0
NDQwOTZkYzEgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4uYworKysg
Yi9zcmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmluLmMKQEAgLTQ4OTksOSArNDg5OSwxMSBAQCBt
YXRjaF9wcmV2aW91c193b3JkcyhpbnQgcGF0dGVybl9pZCwKIAkJQ09NUExFVEVfV0lUSCgiU0NI
RU1BIik7CiAJZWxzZSBpZiAoTWF0Y2hlcygiSU1QT1JUIiwgIkZPUkVJR04iLCAiU0NIRU1BIiwg
TWF0Y2hBbnkpKQogCQlDT01QTEVURV9XSVRIKCJFWENFUFQgKCIsICJGUk9NIFNFUlZFUiIsICJM
SU1JVCBUTyAoIik7Ci0JZWxzZSBpZiAoVGFpbE1hdGNoZXMoIkxJTUlUIiwgIlRPIiwgIigqKSIp
IHx8CisJZWxzZSBpZiAoSGVhZE1hdGNoZXMoIklNUE9SVCIsICJGT1JFSUdOIiwgIlNDSEVNQSIs
IE1hdGNoQW55KSAmJgogCQkJIFRhaWxNYXRjaGVzKCJFWENFUFQiLCAiKCopIikpCiAJCUNPTVBM
RVRFX1dJVEgoIkZST00gU0VSVkVSIik7CisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIkxJTUlUIiwg
IlRPIiwgIigqKSIpKQorCQlDT01QTEVURV9XSVRIKCJGUk9NIFNFUlZFUiIpOwogCWVsc2UgaWYg
KFRhaWxNYXRjaGVzKCJGUk9NIiwgIlNFUlZFUiIsIE1hdGNoQW55KSkKIAkJQ09NUExFVEVfV0lU
SCgiSU5UTyIpOwogCWVsc2UgaWYgKFRhaWxNYXRjaGVzKCJGUk9NIiwgIlNFUlZFUiIsIE1hdGNo
QW55LCAiSU5UTyIpKQotLSAKMi40My4wCgo=
--000000000000949344064f7f7912--