MIME-Version: 1.0
References: 
 <CAHut+Pt3t_tCYwDStkj5fG4Z=YXrHvPBA7iGdh745QipC5zKeg@mail.gmail.com>
 <aeDs7iZUox1bbKAK@alvherre.pgsql>
 <CAHut+Psq7qmQSQCZA_HZcFv9ADCHDUPqCyFuTKfPDU-GUGihhQ@mail.gmail.com>
 <CAA4eK1LKQTHkVWdrS9vBfiaAf5kVuU-qOx_FD2u1F4zB9hz4PA@mail.gmail.com>
 <CAHut+Puic9YTrdj3B4BX1J-m=EJTtF5bhxk8cJpKJVrw6QWMLA@mail.gmail.com>
In-Reply-To: 
 <CAHut+Puic9YTrdj3B4BX1J-m=EJTtF5bhxk8cJpKJVrw6QWMLA@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Mon, 20 Apr 2026 10:34:47 +0530
Message-ID: 
 <CALDaNm12mTxd10yHcf2SyDfkpbfWqHJb=m90cwfaEJnEBbPOXQ@mail.gmail.com>
Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
To: Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm12mTxd10yHcf2SyDfkpbfWqHJb%3Dm90cwfaEJnEBbPOXQ%40mail.gmail.com>
Precedence: bulk

On Mon, 20 Apr 2026 at 08:27, Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Fri, Apr 17, 2026 at 3:24=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.=
com> wrote:
> >
> > On Fri, Apr 17, 2026 at 4:34=E2=80=AFAM Peter Smith <smithpb2250@gmail.=
com> wrote:
> > >
> > > On Fri, Apr 17, 2026 at 12:10=E2=80=AFAM =C3=81lvaro Herrera <alvherr=
e@kurilemu.de> wrote:
> > > >
> > > > On 2026-Apr-10, Peter Smith wrote:
> > > >
> > > > > # -- describe the tables
> > > > > # \d t1
> > > > >                 Table "public.t1"
> > > > > Column | Type   | Collation | Nullable | Default
> > > > > --------+---------+-----------+----------+---------
> > > > > a      | integer |           |          |
> > > > > Except Publications:
> > > > >   "pub1"
> > > >
> > > > I have a hard time understanding what an "except publication" is.  =
I
> > > > think this would be clearer if the header said "Excluded from publi=
cations:"
> > > >
> > >
> > > I agree that your suggestion is clearer.
> > >
> > > If we make that change, then should the "Publications:" footer also b=
e
> > > modified similarly (to "Included in publications:") so they match?
> > >
> > > e.g.
> > >
> > > CURRENTLY
> > >
> > > test_pub=3D# \d t1
> > >                  Table "public.t1"
> > >  Column |  Type   | Collation | Nullable | Default
> > > --------+---------+-----------+----------+---------
> > >  a      | integer |           |          |
> > > Publications:
> > >     "pub1"
> > >     "pub2"
> > > Except publications:
> > >     "pub3"
> > >
> > > ~~~
> > >
> > > SUGGESTION
> > >
> > > test_pub=3D# \d t1
> > >                  Table "public.t1"
> > >  Column |  Type   | Collation | Nullable | Default
> > > --------+---------+-----------+----------+---------
> > >  a      | integer |           |          |
> > > Included in publications:
> > >     "pub1"
> > >     "pub2"
> > > Excluded from publications:
> > >     "pub3"
> > >
> > > ~~~
> > >
> >
> > +1 for the proposal. It makes the description clear.
> >
>
> PSA  v3 patches.
>
> v3-0001 - Fixed the TABLE describe footer titles as suggested.
> - "Included in publications:"
> - "Excluded from publications:"
>
> v3-0002 - Made similar footer title changes for SEQUENCE describe
>
> v3-0003 - Made similar footer title changes for SHCEMA describe. In
> passing, I found that this \dn describe output was not even being
> tested, so I added the missing regression test.

I'm not sure separate patches are necessary for this change; it might
be better to merge them into a single patch. Other than that, the
changes look good.

Regards,
Vignesh