MIME-Version: 1.0
From: vignesh C <vignesh21@gmail.com>
Date: Fri, 10 Apr 2026 11:41:35 +0530
Message-ID: 
 <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
Subject: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000001c4931064f1502d1"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T%3Dhau8UTAU0%2BeLQQ%40mail.gmail.com>
Precedence: bulk

--0000000000001c4931064f1502d1
Content-Type: text/plain; charset="UTF-8"

Hi,

This small cleanup patch updates src/bin/pg_waldump/archive_waldump.c
to use the recently introduced XLogRecPtrIsValid() helper instead of
negating XLogRecPtrIsInvalid(). The current code uses double-negative
checks such as:
Assert(!XLogRecPtrIsInvalid(privateInfo->startptr));
if (!XLogRecPtrIsInvalid(privateInfo->endptr))

This patch changes them to:
Assert(XLogRecPtrIsValid(privateInfo->startptr));
if (XLogRecPtrIsValid(privateInfo->endptr))

This improves readability without changing behavior. The attached
patch has the changes for the same.

Regards,
Vignesh

--0000000000001c4931064f1502d1
Content-Type: application/octet-stream;
	name="0001-Remove-double-negative-XLogRecPtr-checks.patch"
Content-Disposition: attachment;
	filename="0001-Remove-double-negative-XLogRecPtr-checks.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnsic83r0>
X-Attachment-Id: f_mnsic83r0

RnJvbSAzYjgzMDhiOTkwN2FmYTE5MzAwZDhkYmNlOWNlNTc5NGI0MzE5YTgzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWduZXNoIEMgPHZpZ25lc2gyMUBnbWFpbC5jb20+CkRhdGU6
IEZyaSwgMTAgQXByIDIwMjYgMTA6MTI6MzggKzA1MzAKU3ViamVjdDogW1BBVENIXSBSZW1vdmUg
ZG91YmxlLW5lZ2F0aXZlIFhMb2dSZWNQdHIgY2hlY2tzCgpSZXBsYWNlIG5lZ2F0ZWQgWExvZ1Jl
Y1B0cklzSW52YWxpZCgpIGNoZWNrcyBpbgppbml0X2FyY2hpdmVfcmVhZGVyKCkgd2l0aCBYTG9n
UmVjUHRySXNWYWxpZCgpLgoKVGhpcyBpbXByb3ZlcyByZWFkYWJpbGl0eSBieSBhdm9pZGluZyBk
b3VibGUgbmVnYXRpdmVzLAp3aXRoIG5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkLgotLS0K
IHNyYy9iaW4vcGdfd2FsZHVtcC9hcmNoaXZlX3dhbGR1bXAuYyB8IDQgKystLQogMSBmaWxlIGNo
YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMv
YmluL3BnX3dhbGR1bXAvYXJjaGl2ZV93YWxkdW1wLmMgYi9zcmMvYmluL3BnX3dhbGR1bXAvYXJj
aGl2ZV93YWxkdW1wLmMKaW5kZXggZTRhNGJmNDRhN2UuLmZmNGM5Mjc2ZDMxIDEwMDY0NAotLS0g
YS9zcmMvYmluL3BnX3dhbGR1bXAvYXJjaGl2ZV93YWxkdW1wLmMKKysrIGIvc3JjL2Jpbi9wZ193
YWxkdW1wL2FyY2hpdmVfd2FsZHVtcC5jCkBAIC0yMTYsMTEgKzIxNiwxMSBAQCBpbml0X2FyY2hp
dmVfcmVhZGVyKFhMb2dEdW1wUHJpdmF0ZSAqcHJpdmF0ZUluZm8sCiAJICogV2l0aCB0aGUgV0FM
IHNlZ21lbnQgc2l6ZSBhdmFpbGFibGUsIHdlIGNhbiBub3cgaW5pdGlhbGl6ZSB0aGUKIAkgKiBk
ZXBlbmRlbnQgc3RhcnQgYW5kIGVuZCBzZWdtZW50IG51bWJlcnMuCiAJICovCi0JQXNzZXJ0KCFY
TG9nUmVjUHRySXNJbnZhbGlkKHByaXZhdGVJbmZvLT5zdGFydHB0cikpOworCUFzc2VydChYTG9n
UmVjUHRySXNWYWxpZChwcml2YXRlSW5mby0+c3RhcnRwdHIpKTsKIAlYTEJ5dGVUb1NlZyhwcml2
YXRlSW5mby0+c3RhcnRwdHIsIHByaXZhdGVJbmZvLT5zdGFydF9zZWdubywKIAkJCQlwcml2YXRl
SW5mby0+c2Vnc2l6ZSk7CiAKLQlpZiAoIVhMb2dSZWNQdHJJc0ludmFsaWQocHJpdmF0ZUluZm8t
PmVuZHB0cikpCisJaWYgKFhMb2dSZWNQdHJJc1ZhbGlkKHByaXZhdGVJbmZvLT5lbmRwdHIpKQog
CQlYTEJ5dGVUb1NlZyhwcml2YXRlSW5mby0+ZW5kcHRyLCBwcml2YXRlSW5mby0+ZW5kX3NlZ25v
LAogCQkJCQlwcml2YXRlSW5mby0+c2Vnc2l6ZSk7CiAKLS0gCjIuNDMuMAoK
--0000000000001c4931064f1502d1--