MIME-Version: 1.0
References: <fce84be6-3158-4b9c-9b40-a403c49d2966@proxel.se>
 <gmwcpdepbuyvh7pgodnef7qdk67vrtrs46ppjx5rgufljjktou@n2wfjnxlphap>
In-Reply-To: <gmwcpdepbuyvh7pgodnef7qdk67vrtrs46ppjx5rgufljjktou@n2wfjnxlphap>
From: vignesh C <vignesh21@gmail.com>
Date: Thu, 13 Mar 2025 20:11:49 +0530
Message-ID: 
 <CALDaNm1G3qSNgVA2543BmB+dimT7FLGYksY5iLBmcLe8Rj-1dg@mail.gmail.com>
Subject: Re: Add support for EXTRA_REGRESS_OPTS for meson
To: Andres Freund <andres@anarazel.de>
Cc: Andreas Karlsson <andreas@proxel.se>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm1G3qSNgVA2543BmB%2BdimT7FLGYksY5iLBmcLe8Rj-1dg%40mail.gmail.com>
Precedence: bulk

On Thu, 27 Feb 2025 at 18:51, Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2025-02-27 13:53:17 +0100, Andreas Karlsson wrote:
> > We use EXTRA_REGRESS_OPTS to make sure the whole test suite passes with=
 our
> > extension loaded and since I prefer develop in meson over using autotoo=
ls
> > and make the lack of support for EXTRA_REGRESS_OPTS in meson
> > has bugged me for a while.
>
> Yep, we should add support for that.  TEMP_CONFIG probably too.
>
>
> > Question: Would it make sense to rename it to PG_REGRESS_EXTRA_OPTS or
> > something similar while we already touch touch this code to make the va=
rious
> > options easier to remember?
>
> I'd not tackle that at the same time personally.
>
>
> > @@ -51,7 +52,12 @@ env_dict =3D {**os.environ,
> >  if "PG_TEST_EXTRA" not in env_dict and args.pg_test_extra:
> >      env_dict["PG_TEST_EXTRA"] =3D args.pg_test_extra
> >
> > -sp =3D subprocess.Popen(args.test_command, env=3Denv_dict, stdout=3Dsu=
bprocess.PIPE)
> > +if args.testname in ['regress', 'isolation', 'ecpg'] and 'EXTRA_REGRES=
S_OPTS' in env_dict:
> > +    test_command =3D args.test_command + shlex.split(env_dict['EXTRA_R=
EGRESS_OPTS'])
> > +else:
> > +    test_command =3D args.test_command
> > +
> > +sp =3D subprocess.Popen(test_command, env=3Denv_dict, stdout=3Dsubproc=
ess.PIPE)
> >  # Meson categorizes a passing TODO test point as bad
> >  # (https://github.com/mesonbuild/meson/issues/13183).  Remove the TODO
> >  # directive, so Meson computes the file result like Perl does.  This c=
ould
>
> I hacked up something similar before, for TEMP_CONFIG, and found that I n=
eeded
> to do something like this:
>
> +if 'TEMP_CONFIG' in os.environ and \
> +    args.testname in ['regress', 'isolation', 'ecpg']:
> +        # be careful to insert before non-option args, otherwise it'll f=
ail
> +        # e.g. on windows
> +        args.test_command.insert(1, '--temp-config=3D'+os.environ['TEMP_=
CONFIG'])

Could you please upload a v2 to address this? In the meantime, I=E2=80=99ve
updated the commitfest entry status to 'Waiting on Author.' Kindly
update the status once the new version is posted.

Regards,
Vignesh