MIME-Version: 1.0
References: 
 <CALDaNm3tjY44HoSwY84=XGEbTg0ruVfD4hAMTm=TgBqVysH4Qw@mail.gmail.com>
 <cd3189f8-aaed-4ef6-a6b6-da72c1251f34@iki.fi>
 <CALDaNm2y+nf-V9tjKwvbPprobZs1t_UrcCpJ0qYD5-KkOUFAyg@mail.gmail.com>
In-Reply-To: 
 <CALDaNm2y+nf-V9tjKwvbPprobZs1t_UrcCpJ0qYD5-KkOUFAyg@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Mon, 22 Sep 2025 14:28:35 +0530
Message-ID: 
 <CALDaNm1NtWVosSSb9mp3OKic60em5HF2zmURC77MLWyYLMWqyw@mail.gmail.com>
Subject: Re: Random pg_upgrade 004_subscription test failure on drongo
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000f83df9063f600660"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm1NtWVosSSb9mp3OKic60em5HF2zmURC77MLWyYLMWqyw%40mail.gmail.com>
Precedence: bulk

--000000000000f83df9063f600660
Content-Type: text/plain; charset="UTF-8"

On Fri, 21 Mar 2025 at 18:54, vignesh C <vignesh21@gmail.com> wrote:
>
> On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> >
> >
> > Hmm, this problem isn't limited to this one pg_upgrade test, right? It
> > could happen with any pg_upgrade invocation. And perhaps in a running
> > server too, if a relfilenumber is reused quickly. In dropdb() and
> > DropTableSpace() we do this:
> >
> > WaitForProcSignalBarrier(EmitProcSignalBarrier(PROCSIGNAL_BARRIER_SMGRRELEASE));
> >
> > Should we do the same here? Not sure where exactly to put that; perhaps
> > in mdcreate(), if the creation fails with STATUS_DELETE_PENDING.
>
> How about a patch similar to the attached one? I have run pg_upgrade
> tests multiple times, but unfortunately, I was unable to reproduce the
> issue or verify these changes.

CFBot reported an issue in one of the machines, here is an updated
version for the same.

Regards,
Vignesh

--000000000000f83df9063f600660
Content-Type: application/octet-stream;
	name="v2-0001-Fix-issue-with-file-handle-retention-during-CREAT.patch"
Content-Disposition: attachment;
	filename="v2-0001-Fix-issue-with-file-handle-retention-during-CREAT.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mfuw7e6s0>
X-Attachment-Id: f_mfuw7e6s0

RnJvbSBmMDc2ZWM1MTQ2MzEwMzRlMDgxNzQwMjkxZDA2OWExZjIwZmJiMGExIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWduZXNoIDx2aWduZXNoMjFAZ21haWwuY29tPgpEYXRlOiBG
cmksIDIxIE1hciAyMDI1IDE4OjI0OjQ4ICswNTMwClN1YmplY3Q6IFtQQVRDSCB2Ml0gRml4IGlz
c3VlIHdpdGggZmlsZSBoYW5kbGUgcmV0ZW50aW9uIGR1cmluZyBDUkVBVEUKIERBVEFCQVNFIGlu
IHBnX3Jlc3RvcmUKCkR1cmluZyB1cGdyYWRlcywgd2hlbiBwZ19yZXN0b3JlIHBlcmZvcm1zIENS
RUFURSBEQVRBQkFTRSwgdGhlCmJnd3JpdGVyIG9yIGNoZWNrcG9pbnRlciBtYXkgZmx1c2ggYnVm
ZmVycyBhbmQgaG9sZCBhIGZpbGUgaGFuZGxlCmZvciB0aGUgdGFibGUuIFRoaXMgY2F1c2VzIGlz
c3VlcyBpZiB0aGUgdGFibGUgbmVlZHMgdG8gYmUgcmUtY3JlYXRlZApsYXRlciAoZS5nLiwgYWZ0
ZXIgYSBUUlVOQ0FURSBjb21tYW5kKSwgZXNwZWNpYWxseSBvbiBPU2VzIGxpa2Ugb2xkZXIKdmVy
c2lvbnMgb2YgV2luZG93cywgd2hlcmUgdW5saW5rZWQgZmlsZXMgYXJlbid0IGZ1bGx5IHJlbW92
ZWQgdW50aWwKdGhleSBhcmUgbm8gbG9uZ2VyIG9wZW4uCgpUaGlzIGNvbW1pdCBmaXhlcyB0aGUg
aXNzdWUgYnkgY2hlY2tpbmcgZm9yIFNUQVRVU19ERUxFVEVfUEVORElORyBhbmQKY2FsbGluZyBX
YWl0Rm9yUHJvY1NpZ25hbEJhcnJpZXIsIGVuc3VyaW5nIHRoYXQgYWxsIHNtZ3IgZmlsZSBkZXNj
cmlwdG9ycwphcmUgY2xvc2VkIGFjcm9zcyBhbGwgYmFja2VuZHMgYmVmb3JlIHJldHJ5aW5nIHRo
ZSBmaWxlIG9wZXJhdGlvbi4KLS0tCiBzcmMvYmFja2VuZC9zdG9yYWdlL3NtZ3IvbWQuYyB8IDI1
ICsrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25z
KCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9zbWdyL21kLmMgYi9zcmMvYmFj
a2VuZC9zdG9yYWdlL3NtZ3IvbWQuYwppbmRleCAyY2NiMGZhY2ViNS4uYTk3YWZlZGFmZGQgMTAw
NjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3N0b3JhZ2Uvc21nci9tZC5jCisrKyBiL3NyYy9iYWNrZW5k
L3N0b3JhZ2Uvc21nci9tZC5jCkBAIC0zMSwxMCArMzEsMjAgQEAKICNpbmNsdWRlICJtaXNjYWRt
aW4uaCIKICNpbmNsdWRlICJwZ190cmFjZS5oIgogI2luY2x1ZGUgInBnc3RhdC5oIgorCisjaWYg
ZGVmaW5lZChXSU4zMikgJiYgIWRlZmluZWQoX19DWUdXSU5fXykKKyNpbmNsdWRlICJwb3J0L3dp
bjMybnRkbGwuaCIKKyNlbmRpZgorCiAjaW5jbHVkZSAic3RvcmFnZS9haW8uaCIKICNpbmNsdWRl
ICJzdG9yYWdlL2J1Zm1nci5oIgogI2luY2x1ZGUgInN0b3JhZ2UvZmQuaCIKICNpbmNsdWRlICJz
dG9yYWdlL21kLmgiCisKKyNpZiBkZWZpbmVkKFdJTjMyKSAmJiAhZGVmaW5lZChfX0NZR1dJTl9f
KQorI2luY2x1ZGUgInN0b3JhZ2UvcHJvY3NpZ25hbC5oIgorI2VuZGlmCisKICNpbmNsdWRlICJz
dG9yYWdlL3JlbGZpbGVsb2NhdG9yLmgiCiAjaW5jbHVkZSAic3RvcmFnZS9zbWdyLmgiCiAjaW5j
bHVkZSAic3RvcmFnZS9zeW5jLmgiCkBAIC0yMTQsNiArMjI0LDkgQEAgbWRjcmVhdGUoU01nclJl
bGF0aW9uIHJlbG4sIEZvcmtOdW1iZXIgZm9ya251bSwgYm9vbCBpc1JlZG8pCiAJTWRmZFZlYyAg
ICAqbWRmZDsKIAlSZWxQYXRoU3RyCXBhdGg7CiAJRmlsZQkJZmQ7CisjaWYgZGVmaW5lZChXSU4z
MikgJiYgIWRlZmluZWQoX19DWUdXSU5fXykKKwlib29sCQlyZXRyeWF0dGVtcHRlZCA9IGZhbHNl
OworI2VuZGlmCiAKIAlpZiAoaXNSZWRvICYmIHJlbG4tPm1kX251bV9vcGVuX3NlZ3NbZm9ya251
bV0gPiAwKQogCQlyZXR1cm47CQkJCQkvKiBjcmVhdGVkIGFuZCBvcGVuZWQgYWxyZWFkeS4uLiAq
LwpAQCAtMjM1LDYgKzI0OCw5IEBAIG1kY3JlYXRlKFNNZ3JSZWxhdGlvbiByZWxuLCBGb3JrTnVt
YmVyIGZvcmtudW0sIGJvb2wgaXNSZWRvKQogCiAJcGF0aCA9IHJlbHBhdGgocmVsbi0+c21ncl9y
bG9jYXRvciwgZm9ya251bSk7CiAKKyNpZiBkZWZpbmVkKFdJTjMyKSAmJiAhZGVmaW5lZChfX0NZ
R1dJTl9fKQorcmV0cnk6CisjZW5kaWYKIAlmZCA9IFBhdGhOYW1lT3BlbkZpbGUocGF0aC5zdHIs
IF9tZGZkX29wZW5fZmxhZ3MoKSB8IE9fQ1JFQVQgfCBPX0VYQ0wpOwogCiAJaWYgKGZkIDwgMCkK
QEAgLTI0NSw2ICsyNjEsMTUgQEAgbWRjcmVhdGUoU01nclJlbGF0aW9uIHJlbG4sIEZvcmtOdW1i
ZXIgZm9ya251bSwgYm9vbCBpc1JlZG8pCiAJCQlmZCA9IFBhdGhOYW1lT3BlbkZpbGUocGF0aC5z
dHIsIF9tZGZkX29wZW5fZmxhZ3MoKSk7CiAJCWlmIChmZCA8IDApCiAJCXsKKyNpZiBkZWZpbmVk
KFdJTjMyKSAmJiAhZGVmaW5lZChfX0NZR1dJTl9fKQorCQkJaWYgKCFyZXRyeWF0dGVtcHRlZCAm
JiBwZ19SdGxHZXRMYXN0TnRTdGF0dXMoKSA9PSBTVEFUVVNfREVMRVRFX1BFTkRJTkcpCisJCQl7
CisJCQkJcmV0cnlhdHRlbXB0ZWQgPSB0cnVlOworCQkJCVdhaXRGb3JQcm9jU2lnbmFsQmFycmll
cihFbWl0UHJvY1NpZ25hbEJhcnJpZXIoUFJPQ1NJR05BTF9CQVJSSUVSX1NNR1JSRUxFQVNFKSk7
CisJCQkJZ290byByZXRyeTsKKwkJCX0KKyNlbmRpZgorCiAJCQkvKiBiZSBzdXJlIHRvIHJlcG9y
dCB0aGUgZXJyb3IgcmVwb3J0ZWQgYnkgY3JlYXRlLCBub3Qgb3BlbiAqLwogCQkJZXJybm8gPSBz
YXZlX2Vycm5vOwogCQkJZXJlcG9ydChFUlJPUiwKLS0gCjIuNDMuMAoK
--000000000000f83df9063f600660--