Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCgvq-00053L-AK for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Jan 2023 13:02:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pCgvn-0007sT-AT for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Jan 2023 13:02:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCgvm-0007sJ-Vv for pgsql-hackers@lists.postgresql.org; Tue, 03 Jan 2023 13:02:15 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pCgvk-0003Rd-44 for pgsql-hackers@postgresql.org; Tue, 03 Jan 2023 13:02:13 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-14455716674so36658244fac.7 for ; Tue, 03 Jan 2023 05:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mmi7axknrc0nJJm8zuaOXNyXdxgjtC6sosunS8gHwUY=; b=UCYYcsGx+0MaB3y28xr7We65hOHsKFQAQRiDfJV1LahcjGb1F4FyD7bW9dOIVEpz3Z WPM1TsMY0X1zGURt89Fg9axKoxc3L7yPfcJY1k+oQFrHh/catMmamLVB8q7il2FrbYs8 Rn5e8l991Nqhb8uLMdoZqKQ5oliS4tRU2Vm//QiveqVzmMJ91hLCmNJkRPbsoL+aUB3g KH1bcEr8iyFI3juNdlGmko4wg4sIayNtkkRCqDwa0wiQmJzD4f+i/mmSU6H5MxYfcdlU dV/dSbY2BpdOQcluOsoIwa6mRCJ0NzM7tLzXgq2u899qjFmM8sqrroHI4E5m09Qsqspb 5O2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mmi7axknrc0nJJm8zuaOXNyXdxgjtC6sosunS8gHwUY=; b=OlXoi1hpyfFOKEOv2JZ9FbkFsKzbNlOD4OOeyh3JZJW16Q8ylViQ/skAvmf8nMApLU Hag2xa4wVIr1+oMPiwhOSEQPaLZ0WrgH6MshK2cfrX/4Xi4n6MIlh1zWuVsgPyq+0dDZ 12Ft8dldbWtdFzQI3xs6LONuwZ7g26WjYSGxrZWG6PU5bquEGzJzWjLHyux9F8Pj8HNR kTFJkVHbCur/ZpYWhFI/qbXmiXUErz+Uw36eHiH8gXQ2fY5IbKDqCXrcdDx8CoGSaaAh 7F7RADCSfo5l0C3sogkC8bv4xrpU2bxLCKRp/Tpu3LHYHLAkhmwRG+/lS96BZgVJ8yje +geA== X-Gm-Message-State: AFqh2kowDcHhIH5EU7copesdkFoRMZHB6deZmMoXBir5OBqPqnl1oVNG C4yiuP5m+fHaJEweEM+0Qyqy0+WPTAC+MRrAy/A= X-Google-Smtp-Source: AMrXdXsjCc6Sy4n+5mOUfIbWA1Cru5x2dwPLh5jYLVNmCcybgVRy3DHZ8fizjg+bWIrAJrBC1R7Dx6k3hAnu0swViOk= X-Received: by 2002:a05:6871:4589:b0:150:1ad:685c with SMTP id nl9-20020a056871458900b0015001ad685cmr2204809oab.160.1672750931135; Tue, 03 Jan 2023 05:02:11 -0800 (PST) MIME-Version: 1.0 References: <27D90FFC-B897-4BC5-B4F5-9047B9886AA3@yandex-team.ru> <15CA416B-3446-462D-902B-4883DD3ADEE6@yandex-team.ru> <3130B767-FEB7-4F18-AE90-DD95B4367316@yandex-team.ru> <20220219214223.w4bmhiozeimcqhzb@alap3.anarazel.de> <01FF6FFC-7379-43EA-B04A-673C98ABFAAF@yandex-team.ru> <452d01f7e331458f56ad79bef537c31b@postgrespro.ru> <6BABE00C-64BD-4F5D-A071-32B42FAAEB76@yandex-team.ru> <01b29498849ef738be9e786660f98639@postgrespro.ru> In-Reply-To: <01b29498849ef738be9e786660f98639@postgrespro.ru> From: vignesh C Date: Tue, 3 Jan 2023 18:31:59 +0530 Message-ID: Subject: Re: MultiXact\SLRU buffers configuration To: i.lazarev@postgrespro.ru Cc: Andrey Borodin , Yura Sokolov , Andres Freund , Thomas Munro , Gilles Darold , Tomas Vondra , Tomas Vondra , Alexander Korotkov , Anastasia Lubennikova , Daniel Gustafsson , Kyotaro Horiguchi , pgsql-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, 19 Aug 2022 at 21:18, wrote: > > Andrey Borodin wrote 2022-08-18 06:35: > > > > I like the idea of one knob instead of one per each SLRU. Maybe we > > even could deduce sane value from NBuffers? That would effectively > > lead to 0 knobs :) > > > > Your patch have a prefix "v22-0006", does it mean there are 5 previous > > steps of the patchset? > > > > Thank you! > > > > > > Best regards, Andrey Borodin. > > Not sure it's possible to deduce from NBuffers only. > slru_buffers_scale_shift looks like relief valve for systems with ultra > scaled NBuffers. > > Regarding v22-0006 I just tried to choose index unique for this thread > so now it's fixed to 0001 indexing. The patch does not apply on top of HEAD as in [1], please post a rebased patch: === Applying patches on top of PostgreSQL commit ID 325bc54eed4ea0836a0bb715bb18342f0c1c668a === === applying patch ./v23-0001-bucketed-SLRUs-simplified.patch patching file src/include/miscadmin.h ... patching file src/backend/utils/misc/guc.c Hunk #1 FAILED at 32. Hunk #2 FAILED at 2375. 2 out of 2 hunks FAILED -- saving rejects to file src/backend/utils/misc/guc.c.rej [1] - http://cfbot.cputube.org/patch_41_2627.log Regards, Vignesh