public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v6 07/10] is vs are plural 2+ messages / 2 participants [nested] [flat]
* [PATCH v6 07/10] is vs are plural @ 2019-04-04 23:57 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Justin Pryzby @ 2019-04-04 23:57 UTC (permalink / raw) Should backpatch to v12 --- doc/src/sgml/ref/alter_table.sgml | 2 +- doc/src/sgml/sources.sgml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml index b2eb7097a9..fa848e0bdf 100644 --- a/doc/src/sgml/ref/alter_table.sgml +++ b/doc/src/sgml/ref/alter_table.sgml @@ -889,7 +889,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM from the parent table will be created in the partition, if they don't already exist. If any of the <literal>CHECK</literal> constraints of the table being - attached is marked <literal>NO INHERIT</literal>, the command will fail; + attached are marked <literal>NO INHERIT</literal>, the command will fail; such constraints must be recreated without the <literal>NO INHERIT</literal> clause. </para> diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgml index 283c3e0357..12704c6fdf 100644 --- a/doc/src/sgml/sources.sgml +++ b/doc/src/sgml/sources.sgml @@ -466,8 +466,8 @@ Hint: the addendum enough for error messages. Detail and hint messages can be relegated to a verbose mode, or perhaps a pop-up error-details window. Also, details and hints would normally be suppressed from the server log to save - space. Reference to implementation details is best avoided since users - aren't expected to know the details. + space. References to implementation details are best avoided since users + aren't expected to know them. </para> </simplesect> -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0008-doc-backup-manifests.patch" ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Add test module for Table Access Method @ 2024-01-14 11:09 vignesh C <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: vignesh C @ 2024-01-14 11:09 UTC (permalink / raw) To: Michael Paquier <[email protected]>; +Cc: FabrÃzio de Royes Mello <[email protected]>; pgsql-hackers On Thu, 28 Sept 2023 at 10:23, Michael Paquier <[email protected]> wrote: > > On Sat, Jun 03, 2023 at 07:42:36PM -0400, FabrÃzio de Royes Mello wrote: > > So in order to improve things a bit in this area I'm proposing to add a > > test module for Table Access Method similar what we already have for Index > > Access Method. > > > > This code is based on the "blackhole_am" implemented by Michael Paquier: > > https://github.com/michaelpq/pg_plugins/tree/main/blackhole_am > > dummy_index_am has included from the start additional coverage for the > various internal add_*_reloption routines, that were never covered in > the core tree. Except if I am missing something, I am not seeing some > of the extra usefulness for the patch you've sent here. I have changed the status of commitfest entry to "Returned with Feedback" as Michael's comments have not yet been resolved. Please handle the comments and update the commitfest entry accordingly. Regards, Vignesh ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-01-14 11:09 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-04-04 23:57 [PATCH v6 07/10] is vs are plural Justin Pryzby <[email protected]> 2024-01-14 11:09 Re: Add test module for Table Access Method vignesh C <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox