MIME-Version: 1.0
References: 
 <CALDaNm3tjY44HoSwY84=XGEbTg0ruVfD4hAMTm=TgBqVysH4Qw@mail.gmail.com>
 <cd3189f8-aaed-4ef6-a6b6-da72c1251f34@iki.fi>
In-Reply-To: <cd3189f8-aaed-4ef6-a6b6-da72c1251f34@iki.fi>
From: vignesh C <vignesh21@gmail.com>
Date: Mon, 17 Mar 2025 15:49:23 +0530
Message-ID: 
 <CALDaNm2LzW9iQB1=Q5PhMUvhzvYFeGkJFO+3tD8+r6bKS3whoA@mail.gmail.com>
Subject: Re: Random pg_upgrade 004_subscription test failure on drongo
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm2LzW9iQB1%3DQ5PhMUvhzvYFeGkJFO%2B3tD8%2Br6bKS3whoA%40mail.gmail.com>
Precedence: bulk

On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
> Hmm, this problem isn't limited to this one pg_upgrade test, right? It
> could happen with any pg_upgrade invocation. And perhaps in a running
> server too, if a relfilenumber is reused quickly.

Yes, it can happen with these scenarios.

> In dropdb() and DropTableSpace() we do this:
>
> WaitForProcSignalBarrier(EmitProcSignalBarrier(PROCSIGNAL_BARRIER_SMGRRELEASE));
>
> Should we do the same here? Not sure where exactly to put that; perhaps
> in mdcreate(), if the creation fails with STATUS_DELETE_PENDING.

I felt mdcreate would be a good place to fix this issue.

Regards,
Vignesh