public inbox for [email protected]
help / color / mirror / Atom feedFrom: vignesh C <[email protected]>
To: Thomas Munro <[email protected]>
Cc: Juan José Santamaría Flecha <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Using AF_UNIX sockets always for tests on Windows
Date: Thu, 1 Feb 2024 21:58:30 +0530
Message-ID: <CALDaNm2PkKuBFG4su2s9iGAAkPv+sapo=SKFe8NqoearSAy8KA@mail.gmail.com> (raw)
In-Reply-To: <CALDaNm12QffiviYms84kif2HhRnjSr_0DzjW5FzDdQzB-w6cKg@mail.gmail.com>
References: <CA+hUKGK30uLx9dpgkYwomgH0WVLUHytkChDgf3iUM2zp0pf_nA@mail.gmail.com>
<CAC+AXB0VubLbhsuXkYb9aL5d5q3=w7kR1GFZmBp8bRJzj8gtFQ@mail.gmail.com>
<CA+hUKGJkBm0kKLrZax_SSMPYBzZtaeU5CsiUj4NUm9LBp4YnfA@mail.gmail.com>
<CALDaNm12QffiviYms84kif2HhRnjSr_0DzjW5FzDdQzB-w6cKg@mail.gmail.com>
On Sun, 21 Jan 2024 at 18:01, vignesh C <[email protected]> wrote:
>
> On Wed, 22 Mar 2023 at 09:59, Thomas Munro <[email protected]> wrote:
> >
> > Thanks Tom, Andres, Juan José, Andrew for your feedback. I agree that
> > it's a better "OS harmonisation" outcome if we can choose both ways on
> > both OSes. I will leave the 0003 patch aside for now due to lack of
> > time, but here's a rebase of the first two patches. Since this is
> > really just more cleanup-obsolete-stuff background work, I'm going to
> > move it to the next CF.
> >
> > 0001 -- Teach mkdtemp() to care about permissions on Windows.
> > Reviewed by Juan José, who confirmed my blind-coded understanding and
> > showed an alternative version but didn't suggest doing it that way.
> > It's a little confusing that NULL "attributes" means something
> > different from NULL "descriptor", so I figured I should highlight that
> > difference more clearly with some new comments. I guess one question
> > is "why should we expect the calling process to have the default
> > access token?"
> >
> > 0002 -- Use AF_UNIX for pg_regress. This one removes a couple of
> > hundred Windows-only lines that set up SSPI stuff, and some comments
> > about a signal handling hazard that -- as far as I can tell by reading
> > manuals -- was never really true.
> >
> > 0003 -- TAP testing adjustments needs some more work based on feedback
> > already given, not included in this revision.
>
> The patch does not apply anymore:
> patch -p1 < v3-0002-Always-use-AF_UNIX-sockets-in-pg_regress-on-Windo.patch
> patching file src/test/regress/pg_regress.c
> ...
> Hunk #6 FAILED at 781.
> ...
> 1 out of 10 hunks FAILED -- saving rejects to file
> src/test/regress/pg_regress.c.rej
With no update to the thread and the patch not applying I'm marking
this as returned with feedback. Please feel free to resubmit to the
next CF when there is a new version of the patch.
Regards,
Vignesh
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Using AF_UNIX sockets always for tests on Windows
In-Reply-To: <CALDaNm2PkKuBFG4su2s9iGAAkPv+sapo=SKFe8NqoearSAy8KA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox