MIME-Version: 1.0
References: <GaJE0VEMyKS42oPVKkRIwUHOG3VUfJCP_0Qb3ZcnetGLbTXmcgMqioYUL2H_3mIgIpZgRqBq1MTHY-WohgYqxDeD7D8Q8lWXTrfh1bcJHI0=@pm.me>
 <Y41H/RJ1jDBUrtns@paquier.xyz> <CALDaNm3s0MHr1iw716JsacmA4yyCFn4tCw1=3c6Sm2xjvBVYDA@mail.gmail.com>
 <20230111.121033.1472938035248120882.horikyota.ntt@gmail.com> <Y75cCLswLiFULAy1@paquier.xyz>
In-Reply-To: <Y75cCLswLiFULAy1@paquier.xyz>
From: vignesh C <vignesh21@gmail.com>
Date: Wed, 11 Jan 2023 22:29:25 +0530
Message-ID: <CALDaNm2Tjb6dwAVNr0WbE4wa8TG4VzcngO3CzRNLupG8bkmG4g@mail.gmail.com>
Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, mths.dev@pm.me, 
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CALDaNm2Tjb6dwAVNr0WbE4wa8TG4VzcngO3CzRNLupG8bkmG4g%40mail.gmail.com>
Precedence: bulk

On Wed, 11 Jan 2023 at 12:19, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote:
> > It suggests the *kinds* of objects that are part of the extension, but
> > lists the objects of that kind regardless of dependency.  I read
> > Michael suggested (and I agree) to restrict the objects (not kinds) to
> > actually be a part of the extension. (And not for object kinds.)
>
> Yeah, that's what I meant.  Now, if Vignesh does not want to extend
> that, that's fine for me as well at the end on second thought, as this
> involves much more code for each DROP path depending on the object
> type involved.
>
> Adding the object names after DROP/ADD is useful on its own, and we
> already have some completion once the object type is specified, so
> simpler is perhaps just better here.

I too felt keeping it simpler is better. How about using the simple
first version of patch itself?

Regards,
Vignesh