MIME-Version: 1.0
References: <15691075-5172-ad49-e7ae-89b82c1f0cfc@enterprisedb.com>
 <202112101323.gdbduksd5w5z@alvherre.pgsql>
 <CAHut+Pt0xG2zPCDAp1MtUAgZ17gy5ODWsFPdJormwNz7qyZJ0w@mail.gmail.com>
 <CAA4eK1KSmRSJO9H=gPT1p8NvvVTWaSQXk0CYL5v3WLwNMoSN4g@mail.gmail.com>
 <CAHut+PuA3JPmE-Vc=SV7CwkcLYxmMXk-BJgoqNrPZbexaC5=Rg@mail.gmail.com>
 <CAHut+PvOuc9=_4TbASc5=VUqh16UWtFO3GzcKQK_5m1hrW3vqg@mail.gmail.com>
In-Reply-To: 
 <CAHut+PvOuc9=_4TbASc5=VUqh16UWtFO3GzcKQK_5m1hrW3vqg@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Tue, 16 Aug 2022 22:34:26 +0530
Message-ID: 
 <CALDaNm2briFD4+sT-JX_borfHQvbbmyRgTgpgj1m1RFE8p1ieg@mail.gmail.com>
Subject: Re: Column Filtering in Logical Replication
To: Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm2briFD4%2BsT-JX_borfHQvbbmyRgTgpgj1m1RFE8p1ieg%40mail.gmail.com>
Precedence: bulk

On Mon, Aug 8, 2022 at 2:08 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> PSA patch version v1* for a new "Column Lists" pgdocs section
>
> This is just a first draft, but I wanted to post it as-is, with the
> hope that I can get some feedback while continuing to work on it.

Few comments:
1) Row filters mentions that "It has no effect on TRUNCATE commands.",
the same is not present in case of column filters. We should keep the
changes similarly for consistency.
--- a/doc/src/sgml/ref/create_publication.sgml
+++ b/doc/src/sgml/ref/create_publication.sgml
@@ -90,8 +90,7 @@ CREATE PUBLICATION <replaceable
class="parameter">name</replaceable>
      <para>
       When a column list is specified, only the named columns are replicated.
       If no column list is specified, all columns of the table are replicated
-      through this publication, including any columns added later.  If a column
-      list is specified, it must include the replica identity columns.
+      through this publication, including any columns added later.

2) The document says that "if the table uses REPLICA IDENTITY FULL,
specifying a column list is not allowed.":
+   publishes only <command>INSERT</command> operations. Furthermore, if the
+   table uses <literal>REPLICA IDENTITY FULL</literal>, specifying a column
+   list is not allowed.
+  </para>

Did you mean specifying a column list during create publication for
REPLICA IDENTITY FULL table like below scenario:
postgres=# create table t2(c1 int, c2 int, c3 int);
CREATE TABLE
postgres=# alter table t2 replica identity full ;
ALTER TABLE
postgres=# create publication pub1 for table t2(c1,c2);
CREATE PUBLICATION

If so, the document says specifying column list is not allowed, but
creating a publication with column list on replica identity full was
successful.

Regards,
Vignesh