MIME-Version: 1.0
References: 
 <CAMbWs49atE64_JjqrF2+BBZvG-h7afL89wCghg_GmvOHPB_LbQ@mail.gmail.com>
 <CAKU4AWpGo7wXEQqvsv13s=Cto3k9QbucW5DJtjwD1a0dF9iTgA@mail.gmail.com>
 <CAApHDvp+O0PtZMWomyYg=RE68d1wBnc-yxjJsDK3hmYBnP=-qw@mail.gmail.com>
 <CAMbWs49+p6hBxXJHFiSwOtPCSkAHwhJj3hTpCR_pmMiUUVLZ1Q@mail.gmail.com>
 <CAApHDvrTwpgYG9UGjBJpMrey36LMpwtEx_2RWrByxSq7NnKqdA@mail.gmail.com>
 <CAMbWs488_uMqmyQo0Cq-XrDSiEqiXCnfJtCyhXrWn_HdBen3Tw@mail.gmail.com>
 <CAMbWs4_GhDa7+qRbdhLzMTXKZr2naiJc7C+tE1BcK5UVjxqncA@mail.gmail.com>
 <600a153e-191b-952d-7090-cad5097b798f@gmail.com>
 <CAMbWs49bPXs6SVFxJnV4zh_nH6AV0nhHRiJb+E+vFHy9xnvKCA@mail.gmail.com>
 <c1dcaa58-6b62-ddf3-1efc-fa56a50f8608@gmail.com>
 <CAMbWs49ppLP7oToSj4MiMJ6tbt-nRz-Mwy+ZZMcauAAVJk4gPA@mail.gmail.com>
In-Reply-To: 
 <CAMbWs49ppLP7oToSj4MiMJ6tbt-nRz-Mwy+ZZMcauAAVJk4gPA@mail.gmail.com>
From: vignesh C <vignesh21@gmail.com>
Date: Sat, 27 Jan 2024 08:59:04 +0530
Message-ID: 
 <CALDaNm2jEJv92Lw=+cGuAQbbMfus7HvAqKeTCtdmk6uCHc9bKA@mail.gmail.com>
Subject: Re: Support run-time partition pruning for hash join
To: Richard Guo <guofenglinux@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 David Rowley <dgrowleyml@gmail.com>,
	Andy Fan <zhihui.fan1213@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm2jEJv92Lw%3D%2BcGuAQbbMfus7HvAqKeTCtdmk6uCHc9bKA%40mail.gmail.com>
Precedence: bulk

On Tue, 7 Nov 2023 at 13:25, Richard Guo <guofenglinux@gmail.com> wrote:
>
>
> On Mon, Nov 6, 2023 at 11:00=E2=80=AFPM Alexander Lakhin <exclusion@gmail=
.com> wrote:
>>
>> Please look at a warning and an assertion failure triggered by the
>> following script:
>> set parallel_setup_cost =3D 0;
>> set parallel_tuple_cost =3D 0;
>> set min_parallel_table_scan_size =3D '1kB';
>>
>> create table t1 (i int) partition by range (i);
>> create table t1_1 partition of t1 for values from (1) to (2);
>> create table t1_2 partition of t1 for values from (2) to (3);
>> insert into t1 values (1), (2);
>>
>> create table t2(i int);
>> insert into t2 values (1), (2);
>> analyze t1, t2;
>>
>> select * from t1 right join t2 on t1.i =3D t2.i;
>>
>> 2023-11-06 14:11:37.398 UTC|law|regression|6548f419.392cf5|WARNING:  Joi=
n partition pruning $0 has not been performed yet.
>> TRAP: failed Assert("node->as_prune_state"), File: "nodeAppend.c", Line:=
 846, PID: 3747061
>
>
> Thanks for the report!  I failed to take care of the parallel-hashjoin
> case, and I have to admit that it's not clear to me yet how we should do
> join partition pruning in that case.
>
> For now I think it's better to just avoid performing join partition
> pruning for parallel hashjoin, so that the patch doesn't become too
> complex for review.  We can always extend it in the future.
>
> I have done that in v5.  Thanks for testing!

CFBot shows that the patch does not apply anymore as in [1]:
=3D=3D=3D Applying patches on top of PostgreSQL commit ID
924d046dcf55887c98a1628675a30f4b0eebe556 =3D=3D=3D
=3D=3D=3D applying patch
./v5-0001-Support-run-time-partition-pruning-for-hash-join.patch
...
patching file src/include/nodes/plannodes.h
...
patching file src/include/optimizer/cost.h
Hunk #1 FAILED at 211.
1 out of 1 hunk FAILED -- saving rejects to file
src/include/optimizer/cost.h.rej

Please post an updated version for the same.

[1] - http://cfbot.cputube.org/patch_46_4512.log

Regards,
Vignesh