MIME-Version: 1.0
References: 
 <CALDaNm3tjY44HoSwY84=XGEbTg0ruVfD4hAMTm=TgBqVysH4Qw@mail.gmail.com>
 <cd3189f8-aaed-4ef6-a6b6-da72c1251f34@iki.fi>
In-Reply-To: <cd3189f8-aaed-4ef6-a6b6-da72c1251f34@iki.fi>
From: vignesh C <vignesh21@gmail.com>
Date: Fri, 21 Mar 2025 18:54:31 +0530
Message-ID: 
 <CALDaNm2y+nf-V9tjKwvbPprobZs1t_UrcCpJ0qYD5-KkOUFAyg@mail.gmail.com>
Subject: Re: Random pg_upgrade 004_subscription test failure on drongo
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000006d1d8a0630da2dae"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm2y%2Bnf-V9tjKwvbPprobZs1t_UrcCpJ0qYD5-KkOUFAyg%40mail.gmail.com>
Precedence: bulk

--0000000000006d1d8a0630da2dae
Content-Type: text/plain; charset="UTF-8"

On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
>
> Hmm, this problem isn't limited to this one pg_upgrade test, right? It
> could happen with any pg_upgrade invocation. And perhaps in a running
> server too, if a relfilenumber is reused quickly. In dropdb() and
> DropTableSpace() we do this:
>
> WaitForProcSignalBarrier(EmitProcSignalBarrier(PROCSIGNAL_BARRIER_SMGRRELEASE));
>
> Should we do the same here? Not sure where exactly to put that; perhaps
> in mdcreate(), if the creation fails with STATUS_DELETE_PENDING.

How about a patch similar to the attached one? I have run pg_upgrade
tests multiple times, but unfortunately, I was unable to reproduce the
issue or verify these changes.

Regards,
Vignesh

--0000000000006d1d8a0630da2dae
Content-Type: application/octet-stream;
	name="v1-0001-Fix-issue-with-file-handle-retention-during-CREAT.patch"
Content-Disposition: attachment;
	filename="v1-0001-Fix-issue-with-file-handle-retention-during-CREAT.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m8ita5l30>
X-Attachment-Id: f_m8ita5l30

RnJvbSBjMjU2YTQ1MWY5YWI2NGM3ODdmYjhlMDY5Y2E3NTYxZjJjNGRhMTQ1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWduZXNoIDx2aWduZXNoMjFAZ21haWwuY29tPgpEYXRlOiBG
cmksIDIxIE1hciAyMDI1IDE4OjI0OjQ4ICswNTMwClN1YmplY3Q6IFtQQVRDSCB2MV0gRml4IGlz
c3VlIHdpdGggZmlsZSBoYW5kbGUgcmV0ZW50aW9uIGR1cmluZyBDUkVBVEUKIERBVEFCQVNFIGlu
IHBnX3Jlc3RvcmUKCkR1cmluZyB1cGdyYWRlcywgd2hlbiBwZ19yZXN0b3JlIHBlcmZvcm1zIENS
RUFURSBEQVRBQkFTRSwgdGhlCmJnd3JpdGVyIG9yIGNoZWNrcG9pbnRlciBtYXkgZmx1c2ggYnVm
ZmVycyBhbmQgaG9sZCBhIGZpbGUgaGFuZGxlCmZvciB0aGUgdGFibGUuIFRoaXMgY2F1c2VzIGlz
c3VlcyBpZiB0aGUgdGFibGUgbmVlZHMgdG8gYmUgcmUtY3JlYXRlZApsYXRlciAoZS5nLiwgYWZ0
ZXIgYSBUUlVOQ0FURSBjb21tYW5kKSwgZXNwZWNpYWxseSBvbiBPU2VzIGxpa2Ugb2xkZXIKdmVy
c2lvbnMgb2YgV2luZG93cywgd2hlcmUgdW5saW5rZWQgZmlsZXMgYXJlbid0IGZ1bGx5IHJlbW92
ZWQgdW50aWwKdGhleSBhcmUgbm8gbG9uZ2VyIG9wZW4uCgpUaGlzIGNvbW1pdCBmaXhlcyB0aGUg
aXNzdWUgYnkgY2hlY2tpbmcgZm9yIFNUQVRVU19ERUxFVEVfUEVORElORyBhbmQKY2FsbGluZyBX
YWl0Rm9yUHJvY1NpZ25hbEJhcnJpZXIsIGVuc3VyaW5nIHRoYXQgYWxsIHNtZ3IgZmlsZSBkZXNj
cmlwdG9ycwphcmUgY2xvc2VkIGFjcm9zcyBhbGwgYmFja2VuZHMgYmVmb3JlIHJldHJ5aW5nIHRo
ZSBmaWxlIG9wZXJhdGlvbi4KLS0tCiBzcmMvYmFja2VuZC9zdG9yYWdlL3NtZ3IvbWQuYyB8IDE2
ICsrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspCgpkaWZm
IC0tZ2l0IGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9zbWdyL21kLmMgYi9zcmMvYmFja2VuZC9zdG9y
YWdlL3NtZ3IvbWQuYwppbmRleCBmMzIyMGY5OGRjNC4uOWE3OTVhNjYxZGUgMTAwNjQ0Ci0tLSBh
L3NyYy9iYWNrZW5kL3N0b3JhZ2Uvc21nci9tZC5jCisrKyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2Uv
c21nci9tZC5jCkBAIC0zNCw2ICszNCw3IEBACiAjaW5jbHVkZSAic3RvcmFnZS9idWZtZ3IuaCIK
ICNpbmNsdWRlICJzdG9yYWdlL2ZkLmgiCiAjaW5jbHVkZSAic3RvcmFnZS9tZC5oIgorI2luY2x1
ZGUgInN0b3JhZ2UvcHJvY3NpZ25hbC5oIgogI2luY2x1ZGUgInN0b3JhZ2UvcmVsZmlsZWxvY2F0
b3IuaCIKICNpbmNsdWRlICJzdG9yYWdlL3NtZ3IuaCIKICNpbmNsdWRlICJzdG9yYWdlL3N5bmMu
aCIKQEAgLTIwNCw2ICsyMDUsOSBAQCBtZGNyZWF0ZShTTWdyUmVsYXRpb24gcmVsbiwgRm9ya051
bWJlciBmb3JrbnVtLCBib29sIGlzUmVkbykKIAlNZGZkVmVjICAgICptZGZkOwogCVJlbFBhdGhT
dHIJcGF0aDsKIAlGaWxlCQlmZDsKKyNpZiBkZWZpbmVkKFdJTjMyKSAmJiAhZGVmaW5lZChfX0NZ
R1dJTl9fKQorCWJvb2wJCXJldHJ5YXR0ZW1wdGVkID0gZmFsc2U7CisjZW5kaWYKIAogCWlmIChp
c1JlZG8gJiYgcmVsbi0+bWRfbnVtX29wZW5fc2Vnc1tmb3JrbnVtXSA+IDApCiAJCXJldHVybjsJ
CQkJCS8qIGNyZWF0ZWQgYW5kIG9wZW5lZCBhbHJlYWR5Li4uICovCkBAIC0yMjUsNiArMjI5LDkg
QEAgbWRjcmVhdGUoU01nclJlbGF0aW9uIHJlbG4sIEZvcmtOdW1iZXIgZm9ya251bSwgYm9vbCBp
c1JlZG8pCiAKIAlwYXRoID0gcmVscGF0aChyZWxuLT5zbWdyX3Jsb2NhdG9yLCBmb3JrbnVtKTsK
IAorI2lmIGRlZmluZWQoV0lOMzIpICYmICFkZWZpbmVkKF9fQ1lHV0lOX18pCityZXRyeToKKyNl
bmRpZgogCWZkID0gUGF0aE5hbWVPcGVuRmlsZShwYXRoLnN0ciwgX21kZmRfb3Blbl9mbGFncygp
IHwgT19DUkVBVCB8IE9fRVhDTCk7CiAKIAlpZiAoZmQgPCAwKQpAQCAtMjM1LDYgKzI0MiwxNSBA
QCBtZGNyZWF0ZShTTWdyUmVsYXRpb24gcmVsbiwgRm9ya051bWJlciBmb3JrbnVtLCBib29sIGlz
UmVkbykKIAkJCWZkID0gUGF0aE5hbWVPcGVuRmlsZShwYXRoLnN0ciwgX21kZmRfb3Blbl9mbGFn
cygpKTsKIAkJaWYgKGZkIDwgMCkKIAkJeworI2lmIGRlZmluZWQoV0lOMzIpICYmICFkZWZpbmVk
KF9fQ1lHV0lOX18pCisJCQlpZiAoIXJldHJ5YXR0ZW1wdGVkICYmIHBnX1J0bEdldExhc3ROdFN0
YXR1cygpID09IFNUQVRVU19ERUxFVEVfUEVORElORykKKwkJCXsKKwkJCQlyZXRyeWF0dGVtcHRl
ZCA9IHRydWU7CisJCQkJV2FpdEZvclByb2NTaWduYWxCYXJyaWVyKEVtaXRQcm9jU2lnbmFsQmFy
cmllcihQUk9DU0lHTkFMX0JBUlJJRVJfU01HUlJFTEVBU0UpKTsKKwkJCQlnb3RvIHJldHJ5Owor
CQkJfQorI2VuZGlmCisKIAkJCS8qIGJlIHN1cmUgdG8gcmVwb3J0IHRoZSBlcnJvciByZXBvcnRl
ZCBieSBjcmVhdGUsIG5vdCBvcGVuICovCiAJCQllcnJubyA9IHNhdmVfZXJybm87CiAJCQllcmVw
b3J0KEVSUk9SLAotLSAKMi40My4wCgo=
--0000000000006d1d8a0630da2dae--