MIME-Version: 1.0
References: 
 <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <CAPpHfdsEtAWhpcPEaUky+gO20=rz0P03OskAS0c8teuTtHP9hQ@mail.gmail.com>
 <CALT9ZEGTFdwrP+jO1tKxHHeGPM-enMm734MP0wCwJTQZDembYA@mail.gmail.com>
 <CAPpHfdst=eqJ8-n=yhSk=5Xk2QHLF90HWryHWgARuityB3=b7A@mail.gmail.com>
 <CA+TgmobHYix=Nn8D4RUHa6fhUVPR88KGAMq1pBfnGfOfEjRixA@mail.gmail.com>
 <CAPpHfdt_Apbzjx-q2moST3VyNq9Shx8ByGxTF-aqBs3Gaf_n-Q@mail.gmail.com>
 <CA+TgmoY0=bT_xBP8csR=MFE=FxGE2n2-me2-31jBOgEcLvW7ug@mail.gmail.com>
 <CAPpHfdtp3_H_Rp1ubVYGUnnF0fXbam7+OOG_EMnWos1x2a_3Zg@mail.gmail.com>
 <859476bf-3cb0-455e-b093-b8ab5ef17f0e@postgrespro.ru>
 <CA+TgmoZux8hzQ0=1-Rvigm9VuojW0aHiGSzL+G_g43qyrLGiSg@mail.gmail.com>
 <f56c654f-f152-4dc8-b221-4d4484bed612@postgrespro.ru>
 <CAPpHfdtXDuBaHscJn-wada6Kaf3fxmS4k-1TTVhpS+Kx=uveyw@mail.gmail.com>
 <4e2764f7-f6be-478f-8d7f-f921dbd10f5f@postgrespro.ru>
 <CAPpHfdv2V2tsvVn5LYyrJkzmPA==vbdCEKiT8j9yaaiDTfaQtA@mail.gmail.com>
 <ff30dc7e-ebca-42a2-9d49-a66c9a3c7ee5@postgrespro.ru>
In-Reply-To: <ff30dc7e-ebca-42a2-9d49-a66c9a3c7ee5@postgrespro.ru>
From: vignesh C <vignesh21@gmail.com>
Date: Mon, 17 Mar 2025 12:25:16 +0530
Message-ID: 
 <CALDaNm3V5DQSbZGxhYH+3MMMm-YdgOg+RdJ-ni6D0TZx_=Xd7w@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Dmitry Koval <d.koval@postgrespro.ru>
Cc: Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CALDaNm3V5DQSbZGxhYH%2B3MMMm-YdgOg%2BRdJ-ni6D0TZx_%3DXd7w%40mail.gmail.com>
Precedence: bulk

On Mon, 3 Feb 2025 at 21:08, Dmitry Koval <d.koval@postgrespro.ru> wrote:
>
> Hi, Alexander!
> Thanks for your advices and recommendations!
>
>  >I don't think we need a separate 0003 patch with refactoring.  It's
>  >probably good idea to keep this functionality as a separate patch, but
>  >let's make then it a 0001, which prepares functions used by 0002 and
>  >0003.
>
> Done. 0003 was created separately to better understand what changes were
> made after the verified changes 0001 and 0002.
>
>  >Please, check my thoughts on how this patch could be further
>  >developed.  Given amount of work to be done, I doubt that'a a subject
>  >for pg18.  But I think you could continue this work, and we could
>  >consider it for early pg19 cycle.
>
> Good. I'll try to collect and summarize the opinions of colleagues on
> these issues [1], and then put them up for discussion in this thread.

I noticed that Alvaro's comments from [1] have not yet been addressed,
I have changed the status of commitfest entry to "Waiting on Author",
please address them and update it to "Needs review".
[1] - https://www.postgresql.org/message-id/202502031640.zem6orjmmxoz@alvherre.pgsql

Regards,
Vignesh